Tapping on page control doesn't update new tab button |
||||
Issue descriptionTapping on page control doesn't update new tab button. Also, tapping on page control, then swiping on scrollView messes up some internal state such that tapping on page control is disabled. Thanks to michaeldo@ for discovering.
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b213eb0d4ad27dc3972762d8d07c881766b66638 commit b213eb0d4ad27dc3972762d8d07c881766b66638 Author: edchin <edchin@chromium.org> Date: Tue Mar 27 03:20:07 2018 [ios] Synchronize tab grid page control with scroll view Previously there was a bug where there was a mismatch of internal states between the page control and the scroll view. It is important that they both are synchronized with the same current page. This CL fixes the lack of synchronization. TBR=marq@chromium.org Bug: 825898 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I284460d9581a05f780057ef53715484254978859 Reviewed-on: https://chromium-review.googlesource.com/981302 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#545953} [modify] https://crrev.com/b213eb0d4ad27dc3972762d8d07c881766b66638/ios/chrome/browser/ui/tab_grid/tab_grid_page_control.mm [modify] https://crrev.com/b213eb0d4ad27dc3972762d8d07c881766b66638/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Mar 28 2018
,
Mar 28 2018
The NextAction date has arrived: 2018-03-28
,
Mar 28 2018
,
Apr 26 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by edchin@chromium.org
, Mar 26 2018