We would like websites to be able to: - display content below the display cutout - turn the above on/off - be able to know the "margin" for the cutout Most likely, we could implement the Safari iOS API.
Design doc: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e6422d9fe150341f5b80869b86109c0d039e08c commit 2e6422d9fe150341f5b80869b86109c0d039e08c Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Jun 21 16:43:21 2018 [Display Cutout] Link Blink feature and Chrome feature The MediaControlsExpandGesture feature in Blink should be linked to the Chrome feature. BUG= 825890 Change-Id: Ic070d901e7d9b52aa208d89e178eb5c17c93b3d4 Reviewed-on: https://chromium-review.googlesource.com/1108568 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569300} [modify] https://crrev.com/2e6422d9fe150341f5b80869b86109c0d039e08c/content/child/runtime_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/981a543f9e743001a6e492a006873de3a5953747 commit 981a543f9e743001a6e492a006873de3a5953747 Author: Becca Hughes <beccahughes@chromium.org> Date: Sat Jun 23 00:16:40 2018 [CSS Env Vars] Add some WPT tests Adds some WPT tests to test env() with @supports as well as fallback values. BUG= 825890 Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d Reviewed-on: https://chromium-review.googlesource.com/1111023 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569852} [add] https://crrev.com/981a543f9e743001a6e492a006873de3a5953747/third_party/WebKit/LayoutTests/external/wpt/css/css-env/at-supports.tentative.html [add] https://crrev.com/981a543f9e743001a6e492a006873de3a5953747/third_party/WebKit/LayoutTests/external/wpt/css/css-env/env-in-custom-properties.tentative.html [add] https://crrev.com/981a543f9e743001a6e492a006873de3a5953747/third_party/WebKit/LayoutTests/external/wpt/css/css-env/fallback-nested-var.tentative.html [add] https://crrev.com/981a543f9e743001a6e492a006873de3a5953747/third_party/WebKit/LayoutTests/external/wpt/css/css-env/seralization-round-tripping.tentative.html [add] https://crrev.com/981a543f9e743001a6e492a006873de3a5953747/third_party/WebKit/LayoutTests/external/wpt/css/css-env/supports-script.tentative.html [add] https://crrev.com/981a543f9e743001a6e492a006873de3a5953747/third_party/WebKit/LayoutTests/external/wpt/css/css-env/syntax.tentative.html [add] https://crrev.com/981a543f9e743001a6e492a006873de3a5953747/third_party/WebKit/LayoutTests/external/wpt/css/css-env/unknown-env-names-override-previous.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3ef4dca85a813239db2059e143167f71c9a6181 commit a3ef4dca85a813239db2059e143167f71c9a6181 Author: Nico Weber <thakis@chromium.org> Date: Sat Jun 23 23:46:43 2018 Revert "[CSS Env Vars] Add some WPT tests" This reverts commit 981a543f9e743001a6e492a006873de3a5953747. Reason for revert: These tests have been failing since they were added: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/20683 Original change's description: > [CSS Env Vars] Add some WPT tests > > Adds some WPT tests to test env() with @supports as well > as fallback values. > > BUG= 825890 > > Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d > Reviewed-on: https://chromium-review.googlesource.com/1111023 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569852} TBR=mlamouri@chromium.org,beccahughes@chromium.org,futhark@chromium.org Change-Id: I32fbe3682558bdd2d117c8f647750e5d8bcbf740 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825890 Reviewed-on: https://chromium-review.googlesource.com/1112982 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569916} [delete] https://crrev.com/e34ed96660bacf0eca4ad48c6054cbc021154396/third_party/WebKit/LayoutTests/external/wpt/css/css-env/at-supports.tentative.html [delete] https://crrev.com/e34ed96660bacf0eca4ad48c6054cbc021154396/third_party/WebKit/LayoutTests/external/wpt/css/css-env/env-in-custom-properties.tentative.html [delete] https://crrev.com/e34ed96660bacf0eca4ad48c6054cbc021154396/third_party/WebKit/LayoutTests/external/wpt/css/css-env/fallback-nested-var.tentative.html [delete] https://crrev.com/e34ed96660bacf0eca4ad48c6054cbc021154396/third_party/WebKit/LayoutTests/external/wpt/css/css-env/seralization-round-tripping.tentative.html [delete] https://crrev.com/e34ed96660bacf0eca4ad48c6054cbc021154396/third_party/WebKit/LayoutTests/external/wpt/css/css-env/supports-script.tentative.html [delete] https://crrev.com/e34ed96660bacf0eca4ad48c6054cbc021154396/third_party/WebKit/LayoutTests/external/wpt/css/css-env/syntax.tentative.html [delete] https://crrev.com/e34ed96660bacf0eca4ad48c6054cbc021154396/third_party/WebKit/LayoutTests/external/wpt/css/css-env/unknown-env-names-override-previous.tentative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25013557d5cdb7648067118d1071514a421eadcb commit 25013557d5cdb7648067118d1071514a421eadcb Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Jun 25 19:02:08 2018 Reland "[CSS Env Vars] Add some WPT tests" This is a reland of 981a543f9e743001a6e492a006873de3a5953747 This adds a bugfix that adds a DetachFromParent method that we call in StyleEngine. This stops the global environment variables instance holding a reference to the document one after the document has been disposed. Original change's description: > [CSS Env Vars] Add some WPT tests > > Adds some WPT tests to test env() with @supports as well > as fallback values. > > BUG= 825890 > > Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d > Reviewed-on: https://chromium-review.googlesource.com/1111023 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569852} Bug: 825890 Change-Id: If828b977d62145fb1ea9bb710a48d76307a054d5 Reviewed-on: https://chromium-review.googlesource.com/1113877 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#570117} [add] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/WebKit/LayoutTests/external/wpt/css/css-env/at-supports.tentative.html [add] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/WebKit/LayoutTests/external/wpt/css/css-env/env-in-custom-properties.tentative.html [add] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/WebKit/LayoutTests/external/wpt/css/css-env/fallback-nested-var.tentative.html [add] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/WebKit/LayoutTests/external/wpt/css/css-env/seralization-round-tripping.tentative.html [add] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/WebKit/LayoutTests/external/wpt/css/css-env/supports-script.tentative.html [add] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/WebKit/LayoutTests/external/wpt/css/css-env/syntax.tentative.html [add] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/WebKit/LayoutTests/external/wpt/css/css-env/unknown-env-names-override-previous.tentative.html [modify] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/blink/renderer/core/css/document_style_environment_variables.cc [modify] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/blink/renderer/core/css/style_engine.cc [modify] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/blink/renderer/core/css/style_environment_variables.cc [modify] https://crrev.com/25013557d5cdb7648067118d1071514a421eadcb/third_party/blink/renderer/core/css/style_environment_variables.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2163df73d200e1c0d4a0d54047cdf881c1916256 commit 2163df73d200e1c0d4a0d54047cdf881c1916256 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jul 17 18:06:50 2018 [Display Cutout] Add UKM metrics Add a Layout.DisplayCutout.StateChanged UKM event that is recorded when display cutout state changes. BUG= 825890 Change-Id: I7b134117ea847505e62f3690d0ac45ab02db8e1f Reviewed-on: https://chromium-review.googlesource.com/1117638 Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#575717} [modify] https://crrev.com/2163df73d200e1c0d4a0d54047cdf881c1916256/content/browser/BUILD.gn [add] https://crrev.com/2163df73d200e1c0d4a0d54047cdf881c1916256/content/browser/display_cutout/OWNERS [add] https://crrev.com/2163df73d200e1c0d4a0d54047cdf881c1916256/content/browser/display_cutout/display_cutout_browsertest.cc [add] https://crrev.com/2163df73d200e1c0d4a0d54047cdf881c1916256/content/browser/display_cutout/display_cutout_constants.h [delete] https://crrev.com/6f2f737f77255c3eb39154b6e0cc735bc44da764/content/browser/display_cutout_browsertest.cc [modify] https://crrev.com/2163df73d200e1c0d4a0d54047cdf881c1916256/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/2163df73d200e1c0d4a0d54047cdf881c1916256/content/test/BUILD.gn [modify] https://crrev.com/2163df73d200e1c0d4a0d54047cdf881c1916256/tools/metrics/ukm/ukm.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b5a43489e869691ca3939295312f313b392fae5 commit 3b5a43489e869691ca3939295312f313b392fae5 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jul 17 22:31:55 2018 [Display Cutout] Move DisplayCutoutHostImpl out Move DisplayCutoutHostImpl out of WebContentsImpl into its own file. BUG= 825890 Change-Id: Id759fa7c9fd880648ec35baac853a046d90959ab Reviewed-on: https://chromium-review.googlesource.com/1131847 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#575810} [modify] https://crrev.com/3b5a43489e869691ca3939295312f313b392fae5/content/browser/BUILD.gn [add] https://crrev.com/3b5a43489e869691ca3939295312f313b392fae5/content/browser/display_cutout/display_cutout_host_impl.cc [add] https://crrev.com/3b5a43489e869691ca3939295312f313b392fae5/content/browser/display_cutout/display_cutout_host_impl.h [modify] https://crrev.com/3b5a43489e869691ca3939295312f313b392fae5/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/3b5a43489e869691ca3939295312f313b392fae5/content/browser/web_contents/web_contents_impl.h
Should this and the launch bug be closed?
Comment 1 by mlamouri@chromium.org
, Apr 13 2018