New issue
Advanced search Search tips

Issue 825888 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Bug
Q2



Sign in to add a comment

The regular Close All closes all regular and incognito tabs.

Project Member Reported by edchin@chromium.org, Mar 26 2018

Issue description

the regular Close All closes all regular and incognito tabs.


 

Comment 1 by edchin@chromium.org, Mar 26 2018

Components: UI>Browser

Comment 2 by cmasso@google.com, Apr 5 2018

Labels: -Pri-2 Pri-0
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e71c567b5036a67033d8648159017023d0f80316

commit e71c567b5036a67033d8648159017023d0f80316
Author: edchin <edchin@chromium.org>
Date: Fri Apr 06 18:05:34 2018

[ios] Close All in regular tabs also closes incognito tabs

Bug:  825888 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib47af308aef7797fd682f647e8cfa7481c466a0f
Reviewed-on: https://chromium-review.googlesource.com/999306
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548856}
[modify] https://crrev.com/e71c567b5036a67033d8648159017023d0f80316/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Issue verified 
Version: Chrome Canary  67.0.3394.0
Device: iPhone 6
iOS: 11.2.6

"Close All" close regular and incognito tabs.
https://drive.google.com/open?id=1BGINAUKmkW5o3VCCTjsBm8xhrDZnc6Mj
Labels: Proj-UIRefresh

Sign in to add a comment