New issue
Advanced search Search tips

Issue 825880 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Viewport width client hint value on main frame requests is off by a factor of 2x

Project Member Reported by tbansal@chromium.org, Mar 26 2018 
On Mac OS X, I see main frame viewport width client hint value as 2560 while the value on subresources is 1280. The values should match.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7360dcc2e71580ab481fa9856e95153ad3d528

commit cf7360dcc2e71580ab481fa9856e95153ad3d528
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Mar 26 19:32:59 2018

Include device scale factor when computing viewport width client hint on desktop

Bug:  825880 
Change-Id: I7c4e8abee53788e4c0f5fcd7857dde087b5ec6e3
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/980919
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545862}
[modify] https://crrev.com/cf7360dcc2e71580ab481fa9856e95153ad3d528/chrome/browser/client_hints/client_hints.cc

Comment 2 by tbansal@chromium.org, Mar 27 2018

Status: Fixed (was: Started)
►

Sign in to add a comment