Add dashboard error handling to src side merge script |
||
Issue descriptionWhen the perf dashboard upload fails we need to: 1) Return 1 here: https://cs.chromium.org/chromium/src/tools/perf/process_perf_results.py?q=process_perf_results&sq=package:chromium&l=129 so that the step will fail and we will notice there is an error 2) Adding a indication in the "links" section of the json so there is an indication on the buildbot step that there was an upload failure and not just a benchmark failure.
,
Apr 2 2018
For the first one here the step does fail since the shard fails, the problem is that telemetry is failing so there are no json test results written and therefore the buildbot step doesn't list what tests are broken. A user can click on the failed shard but it is harder to determine what is going on since they don't know what test to look for a failure with. I think this is a rarer case (ie something we have setup wrong which is why we run into it) so I don't think this is high priority, but we could potentially add another link to the json test results and create a stream listing the telemetry failures in it. I think we can close this bug as is for the dashboard upload failures. This does correctly surface those errors.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
||
►
Sign in to add a comment |
||
Comment 1 by ashleymarie@chromium.org
, Apr 2 2018