New issue
Advanced search Search tips

Issue 825849 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Drags don't support RTL in the MD download shelf

Project Member Reported by sdy@chromium.org, Mar 26 2018

Issue description

Chrome Version: 67.0.3379.0
OS: macOS

What steps will reproduce the problem?
(1) (In RTL) Download a file.
(2) Drag it from the shelf.

What is the expected result?
Lookin' good.

What happens instead?
It's LTR. See screenshot.
 
rtl_drag.png
25.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20551064d1dd275d1264d4b2543e8b9fb1f934f8

commit 20551064d1dd275d1264d4b2543e8b9fb1f934f8
Author: Sidney San Martín <sdy@chromium.org>
Date: Mon Mar 26 19:32:23 2018

Fix RTL when dragging downloads and make dragging more Mac-like.

RTL was missing from this particular part of MD downloads. This change:

1. Adds RTL support.

2. Changes the look slightly overall to match dragging on macOS: instead of a
   representation of the file appearing under the mouse pointer, dragging
   creates a copy of the icon and text seen in the shelf, which start off in
   their original spots. (I tried this while I was working on RTL).

Change-Id: I766d61227d04541f1beecf93adf87464da5a020b
Bug:  825849 
Reviewed-on: https://chromium-review.googlesource.com/979195
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545861}
[modify] https://crrev.com/20551064d1dd275d1264d4b2543e8b9fb1f934f8/chrome/browser/ui/cocoa/download/md_download_item_view.mm

Labels: TE-Verified-M67 TE-Verified-67.0.3381.0
Tested the issue using #67.0.3381.0  on Mac 10.13.3 as per the steps mentioned below.

Steps:
!. Enabled #mac-rtl in chrome://flags, and launched Chrome with --enable-#mac-md-download-shelf
2, Enabled Arabic language
3. Navigated to NTP
4. Clicked on save as
5. Dragged the downloaded file from the self
6. No such behavior is seen as attached screenshot

Please find the screencast, Hence adding verified labels.

Thanks!!

RTL.mp4
1.8 MB View Download

Comment 3 by sdy@chromium.org, Apr 9 2018

Status: Verified (was: Started)
Thanks!

Sign in to add a comment