New issue
Advanced search Search tips

Issue 825848 link

Starred by 1 user
Status: Verified
Owner:
sdy@chromium.org
Closed: Apr 2018
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

RTL broken for dangerous downloads in the MD download shelf

Project Member Reported by sdy@chromium.org, Mar 26 2018 
Chrome Version: 67.0.3379.0
OS: macOS

What steps will reproduce the problem?
(1) (In RTL) Start a dangerous download from https://testsafebrowsing.appspot.com/ or https://docs.oracle.com/javase/tutorial/uiswing/examples/misc/index.html.
(2) Look at the shelf.

What is the expected result?
Lookin' good.

What happens instead?
Not so good. See screenshots.

I think this has been the case since MD downloads launched.
rtl_danger_1.png
14.6 KB View Download
rtl_danger_2.png
12.3 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf6e249fbaa8f2261e968bc51a9e49ce66a25b7c

commit bf6e249fbaa8f2261e968bc51a9e49ce66a25b7c
Author: Sidney San Martín <sdy@chromium.org>
Date: Tue Mar 27 03:34:37 2018

Fix RTL layout issues with dangerous downloads under MD downloads.

See the bug for screenshots of the problem.

Change-Id: I1db68491c72833efd979696cc98359e1c59acdfb
Bug:  825848 
Reviewed-on: https://chromium-review.googlesource.com/979194
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545979}
[modify] https://crrev.com/bf6e249fbaa8f2261e968bc51a9e49ce66a25b7c/chrome/browser/ui/cocoa/download/md_download_item_view.mm

Comment 2 by susan.boorgula@chromium.org, Mar 29 2018

Labels: Needs-Feedback
sdy@ Thanks for the issue.

Tested this issue on Mac OS 10.12.6 on the reported version 67.0.3379.0 and the latest Canary 67.0.3383.0 by following the below steps.

1. Launched Chrome and enabled the flag #mac-rtl.
2. From the above link, clicked on 'Should show a "dangerous host" warning' link and attached is the screen shot of the download shelf.
Same behavior is observed on the reported version and the latest Canary.
3. Tried launching chrome by changing the language to Arabic from terminal (defaults write com.google.Chrome AppleLanguages '(ar)'), and could observe the same behavior.

Attached are the screen shots for reference.

sdy@ Request you to please check this issue and help us in verifying the fix.

Thanks..
825848-reported.png
163 KB View Download
825848-M67Canary.png
157 KB View Download

Comment 3 by sdy@chromium.org, Apr 10 2018

Status: Verified (was: Started)
►

Sign in to add a comment