https://chromium-review.googlesource.com/c/chromium/src/+/966484

Not sure if this is used by the blink_perf tests, but this cl landed around the same time this started failing. I tried looking at the output of a passing blink_perf.bindings test and couldn't find event-target-wrapper

So it looks like some functionality was removed in that CL that disabled some tests that are now failing: 


blink_perf.dom/TraverseChildNodes.html
blink_perf.dom/click_webkit_user_select_none.html
blink_perf.bindings/event-target-wrapper.html

I reverted the CL so the waterfall so the tests can cycle green again.  

can one of you comment on whether or not this code is still used since this code was removed?

I wasn't sure whether that code was still used it was added many years ago, and the last change was about a year ago, and so I speculatively removed it.

It appears to be used to disable a few perf tests. Perhaps those few perf tests could be removed/fixed/moved.

That is up to the benchmark owners.  I will leave it to them to comment and/or remove the benchmarks since it seems that haven't run in some time.  Removing them would be preferable.

adithyas@, could you have a look at what's going on here?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d617c7d028ee4114a3a0dd48767c208df634b307

commit d617c7d028ee4114a3a0dd48767c208df634b307
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Tue Apr 10 14:04:06 2018

Remove some performance tests that have been disabled for years

- TraverseChildNodes.html has been disabled since it's creation in 2013
- event-target-wrapper.html has been disabled for almost 4 years
  (https://crrev.com/11fa29bfc9db3ab9befd51719fdd086394570449) and is a
  "manual" test, it's unclear whether we actually use it
- click_webkit_user_select_none.html was disabled
  (https://crrev.com/8c2c59c239e9d02eb14d88fa7596d0e15caba70d) 2 weeks
  after it was created, and never fixed after

Bug:  825837 
Change-Id: Ied18ae861d704f99e215360aecc1caf1a127d97c
Reviewed-on: https://chromium-review.googlesource.com/1003081
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549515}
[delete] https://crrev.com/0bd16722c5dae2e907eca74c02ed0a03c41737d9/third_party/WebKit/PerformanceTests/Bindings/event-target-wrapper.html
[delete] https://crrev.com/0bd16722c5dae2e907eca74c02ed0a03c41737d9/third_party/WebKit/PerformanceTests/DOM/TraverseChildNodes.html
[delete] https://crrev.com/0bd16722c5dae2e907eca74c02ed0a03c41737d9/third_party/WebKit/PerformanceTests/DOM/click_webkit_user_select_none.html
[modify] https://crrev.com/d617c7d028ee4114a3a0dd48767c208df634b307/third_party/WebKit/PerformanceTests/Skipped

I have removed the tests listed in #2, so maybe it's worth trying to remove the expectations file again? There are a lot of other tests in that file though, I'm not really sure about their status.

Hm, well, if those few tests were the only ones that were failing after removing the expectations file, then I think removing it probably won't result in any new failures, and if it does, then we could revert again?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813658756b466a0d235536249752c32b3e19b75d

commit 813658756b466a0d235536249752c32b3e19b75d
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Apr 12 19:55:11 2018

Reland "Remove "Skipped" file and Port.skips_perf_test"

This reverts commit 0d5e363089648f237f01341b28143fb27f5261f3.

Reason for revert: The tests that were failing after the first time
landing this have now been removed ( crbug.com/825837 ).

R=eyaich@chromium.org

Bug:  825837 
Change-Id: Ibbd16ba0976863870ebb4cb00fc72a6bae3b9e0e
Reviewed-on: https://chromium-review.googlesource.com/1005738
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550321}
[delete] https://crrev.com/b5cdaa98071a53cbbf138f0e2c3d93e74770ef86/third_party/WebKit/PerformanceTests/Skipped
[modify] https://crrev.com/813658756b466a0d235536249752c32b3e19b75d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/813658756b466a0d235536249752c32b3e19b75d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813658756b466a0d235536249752c32b3e19b75d

commit 813658756b466a0d235536249752c32b3e19b75d
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Apr 12 19:55:11 2018

Reland "Remove "Skipped" file and Port.skips_perf_test"

This reverts commit 0d5e363089648f237f01341b28143fb27f5261f3.

Reason for revert: The tests that were failing after the first time
landing this have now been removed ( crbug.com/825837 ).

R=eyaich@chromium.org

Bug:  825837 
Change-Id: Ibbd16ba0976863870ebb4cb00fc72a6bae3b9e0e
Reviewed-on: https://chromium-review.googlesource.com/1005738
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550321}
[delete] https://crrev.com/b5cdaa98071a53cbbf138f0e2c3d93e74770ef86/third_party/WebKit/PerformanceTests/Skipped
[modify] https://crrev.com/813658756b466a0d235536249752c32b3e19b75d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/813658756b466a0d235536249752c32b3e19b75d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

As far as I know, this test is now to failing on those builders, please re-open if it's still an issue :-)

* The above should read: "this test is now _not_ failing"