New issue
Advanced search Search tips

Issue 825834 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MacViews: fix NOTIMPLEMENTEDs

Project Member Reported by lgrey@chromium.org, Mar 26 2018

Issue description

An inexhaustive list, will be updated:

views::NativeWidgetMac::FrameTypeChanged
views::NativeWidgetMac::SetVisibilityAnimationTransition
views::NativeViewHostMac::InstallClip
gfx::Rect content::WebContentsViewMac::GetViewBounds()
views::NativeWidgetMac::StackAtTop()
gfx::NativeWindow (anonymous namespace)::GetModalTransient(gfx::NativeWindow)
gfx::NativeCursor views::GetNativeEastWestResizeCursor
 
Labels: MacViews-Cleanup Target-69

Comment 2 Deleted

Comment 3 by gov...@chromium.org, Mar 27 2018

Labels: M-69

Comment 4 by lgrey@chromium.org, Apr 16 2018

Description: Show this description
Status: Assigned (was: Available)

Comment 6 by lgrey@chromium.org, May 7 2018

Description: Show this description

Comment 7 by lgrey@chromium.org, May 18 2018

Description: Show this description
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7dcbe00932474e0e19b66d8cb4d2fa626ce5b54

commit a7dcbe00932474e0e19b66d8cb4d2fa626ce5b54
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Jun 04 20:30:48 2018

MacViews: return screen coordinates for windowless events in |EventLocationFromNative|

Previously, we were returning 0,0 in this case. Returning screen coordinates matches
AppKit and is roughly congruent with what Windows does in this case.

Bug: 825834
Change-Id: I40082ba93d4f595c01ce98ca0c3f7289e56d05f2
Reviewed-on: https://chromium-review.googlesource.com/1078935
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564217}
[modify] https://crrev.com/a7dcbe00932474e0e19b66d8cb4d2fa626ce5b54/ui/events/cocoa/events_mac.mm
[modify] https://crrev.com/a7dcbe00932474e0e19b66d8cb4d2fa626ce5b54/ui/events/cocoa/events_mac_unittest.mm

Comment 9 by lgrey@chromium.org, Jun 12 2018

Description: Show this description
Labels: -M-69
Labels: M-69
Labels: Group-Cleanup
Labels: -M-69 -Target-69 M-70 Target-70
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/002dfaef6957632740a412c3d69af0913536e1dd

commit 002dfaef6957632740a412c3d69af0913536e1dd
Author: Leonard Grey <lgrey@chromium.org>
Date: Thu Nov 08 22:18:47 2018

Mac: Disallow dragging tab into blocked tabstrip

This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
though I'm pretty sure the thing that happens right now when you open
a certificate prompt and drag a tab into the parent window is bad.

This introduces a new method because we're not sure if it matches the
Aura semantics, and this is better than the nothing we were doing previously.

Bug: 825834
Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
Reviewed-on: https://chromium-review.googlesource.com/c/1315956
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606619}
[modify] https://crrev.com/002dfaef6957632740a412c3d69af0913536e1dd/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/002dfaef6957632740a412c3d69af0913536e1dd/chrome/browser/ui/views/tabs/tab_drag_controller.h

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/899b84ea267b8ce6ce522d2cf3b34453be3ac164

commit 899b84ea267b8ce6ce522d2cf3b34453be3ac164
Author: Leonard Grey <lgrey@chromium.org>
Date: Fri Nov 09 14:18:15 2018

Revert "Mac: Disallow dragging tab into blocked tabstrip"

This reverts commit 002dfaef6957632740a412c3d69af0913536e1dd.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=903706#c1

Original change's description:
> Mac: Disallow dragging tab into blocked tabstrip
> 
> This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
> though I'm pretty sure the thing that happens right now when you open
> a certificate prompt and drag a tab into the parent window is bad.
> 
> This introduces a new method because we're not sure if it matches the
> Aura semantics, and this is better than the nothing we were doing previously.
> 
> Bug: 825834
> Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
> Reviewed-on: https://chromium-review.googlesource.com/c/1315956
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606619}

TBR=ellyjones@chromium.org,lgrey@chromium.org

Change-Id: If2a6470657f160a0e7fa2fd9978078ab46ae048a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 825834
Reviewed-on: https://chromium-review.googlesource.com/c/1329341
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606828}
[modify] https://crrev.com/899b84ea267b8ce6ce522d2cf3b34453be3ac164/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/899b84ea267b8ce6ce522d2cf3b34453be3ac164/chrome/browser/ui/views/tabs/tab_drag_controller.h

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c1e2ba516be28fa3f8680b4a025576cb5894f51

commit 6c1e2ba516be28fa3f8680b4a025576cb5894f51
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Nov 12 15:00:10 2018

Reland "Mac: Disallow dragging tab into blocked tabstrip"

This is a reland of 002dfaef6957632740a412c3d69af0913536e1dd

Original change's description:
> Mac: Disallow dragging tab into blocked tabstrip
> 
> This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
> though I'm pretty sure the thing that happens right now when you open
> a certificate prompt and drag a tab into the parent window is bad.
> 
> This introduces a new method because we're not sure if it matches the
> Aura semantics, and this is better than the nothing we were doing previously.
> 
> Bug: 825834
> Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
> Reviewed-on: https://chromium-review.googlesource.com/c/1315956
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606619}

Bug: 825834
Change-Id: Ice8fa3f991e3e672a2266c444e281bbad1b47819
Reviewed-on: https://chromium-review.googlesource.com/c/1329350
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607224}
[modify] https://crrev.com/6c1e2ba516be28fa3f8680b4a025576cb5894f51/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/6c1e2ba516be28fa3f8680b4a025576cb5894f51/chrome/browser/ui/views/tabs/tab_drag_controller.h

Sign in to add a comment