Fix concurrent visitation of JSFunction, JSRegex, JSArrayBuffer |
||
Issue descriptionJSFunction, JSRegex, JSArrayBuffer have their own visitor_id, but they are also JSObjects. Concurrent marker should run the snapshotting protocol for them too.
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/1d2496319eb31d52de16cfef55c84c2e27d691f3 commit 1d2496319eb31d52de16cfef55c84c2e27d691f3 Author: Ulan Degenbaev <ulan@chromium.org> Date: Mon Mar 26 17:03:42 2018 [heap] Remove custom visitor for JSRegex. JSRegex does not have custom body descriptor and uses JSObject body descriptor, so it should just use JSObject visitor id. Bug: chromium:825828 Change-Id: Iae22315da7ab83bb4ac919586c883120621761c8 Reviewed-on: https://chromium-review.googlesource.com/980752 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52228} [modify] https://crrev.com/1d2496319eb31d52de16cfef55c84c2e27d691f3/src/heap/objects-visiting.h [modify] https://crrev.com/1d2496319eb31d52de16cfef55c84c2e27d691f3/src/objects.cc [modify] https://crrev.com/1d2496319eb31d52de16cfef55c84c2e27d691f3/src/objects/map.h
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7e78e45b909fd499bb03ceae8fa89cd712ab30a5 commit 7e78e45b909fd499bb03ceae8fa89cd712ab30a5 Author: Ulan Degenbaev <ulan@chromium.org> Date: Mon Mar 26 17:29:03 2018 [heap] Use snapshotting protocol for all JSObject subclasses. Bug: chromium:825828 Change-Id: I1f27c08fa8febe521412fddb6ae964969671764b Reviewed-on: https://chromium-review.googlesource.com/980933 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52230} [modify] https://crrev.com/7e78e45b909fd499bb03ceae8fa89cd712ab30a5/src/heap/concurrent-marking.cc [modify] https://crrev.com/7e78e45b909fd499bb03ceae8fa89cd712ab30a5/src/heap/objects-visiting-inl.h [modify] https://crrev.com/7e78e45b909fd499bb03ceae8fa89cd712ab30a5/src/heap/objects-visiting.h
,
Apr 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by u...@chromium.org
, Mar 26 2018