histogram uploads started failing across all chromium.perf dashboard |
||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromium.perf/waterfall If you look at one example win 10 perf of the most recent failing build: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%2010%20Perf/builds/2284 It is failing on add_reserved_diagnostics: VPYTHON_VIRTUALENV_ROOT: E:\b\c\vpython VS110COMNTOOLS: C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\Tools\ WINDIR: C:\WINDOWS Set PYTHONPATH: E:\b\rr\tmpdnoi8m\rw\checkout\scripts;E:\b\rr\tmpdnoi8m\rw\checkout\site_config;E:\b\rr\tmpdnoi8m\rw\checkout\scripts\tools;E:\b\c\vpython\61b49b\Scripts\python27.zip;E:\b\c\vpython\61b49b\DLLs;E:\b\c\vpython\61b49b\lib;E:\b\c\vpython\61b49b\lib\plat-win;E:\b\c\vpython\61b49b\lib\lib-tk;E:\b\c\vpython\61b49b\Scripts;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\Lib;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\DLLs;E:\b\c\vpython\61b49b Traceback (most recent call last): File "E:\b\c\b\Win_10_Perf\src\third_party\catapult\tracing\bin\add_reserved_diagnostics", line 116, in <module> sys.exit(main()) File "E:\b\c\b\Win_10_Perf\src\third_party\catapult\tracing\bin\add_reserved_diagnostics", line 76, in main with tempfile.NamedTemporaryFile() as temp: NameError: global name 'tempfile' is not defined Sending result 2 of 2 to dashboard. Error uploading histogram data: HTTP Response 400: Bad Request step returned non-zero exit code: 1 This CL was landed on Saturday: https://chromium-review.googlesource.com/c/catapult/+/973895 Assigning to Simon to revert?
,
Mar 27 2018
,
Mar 28 2018
Can we verify this? I still see quite a few dashboard failures for the dummy benchmarks across the waterfall https://uberchromegw.corp.google.com/i/chromium.perf/waterfall
,
Mar 28 2018
,
Mar 28 2018
Looks like it broke again. After the first breakage, we added a lot of testing, the bin caller doesn't have test coverage though. Will land a fix and these will clear up.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/10232e9c96f4aa6faa53ae3abb29b190d2582aa6 commit 10232e9c96f4aa6faa53ae3abb29b190d2582aa6 Author: Simon <simonhatch@chromium.org> Date: Wed Mar 28 15:39:57 2018 Histogram - Missing json import in bin/add_reserved_diagnostics TBR=eakuefner@chromium.org Bug: chromium:825805 Change-Id: I2c3a9dcd60b8e3e6318d462fb9f5fda4fb7c38c5 Reviewed-on: https://chromium-review.googlesource.com/984152 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> [modify] https://crrev.com/10232e9c96f4aa6faa53ae3abb29b190d2582aa6/tracing/bin/add_reserved_diagnostics
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f635a65b9c16ea558df348a76cae77fcc390eaa commit 8f635a65b9c16ea558df348a76cae77fcc390eaa Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Mar 28 19:38:28 2018 Roll src/third_party/catapult/ 71fd6b902..10232e9c9 (1 commit) https://chromium.googlesource.com/catapult.git/+log/71fd6b902fc9..10232e9c96f4 $ git log 71fd6b902..10232e9c9 --date=short --no-merges --format='%ad %ae %s' 2018-03-28 simonhatch Histogram - Missing json import in bin/add_reserved_diagnostics Created with: roll-dep src/third_party/catapult BUG= chromium:825805 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I77fb42fb45083006a53974c0aa4a10dff759f844 Reviewed-on: https://chromium-review.googlesource.com/984344 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546569} [modify] https://crrev.com/8f635a65b9c16ea558df348a76cae77fcc390eaa/DEPS
,
Oct 3
|
||||
►
Sign in to add a comment |
||||
Comment 1 by eakuefner@chromium.org
, Mar 26 2018