New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825796 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 825604
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.5%-2% regression in thread_times.tough_compositor_cases at 544793:544908

Project Member Reported by sullivan@chromium.org, Mar 26 2018

Issue description

Split off Android regressions from  bug 825596  since that has a Windows root cause.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 26 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=825796

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c8b67749c3821215526df9433cc3bf500a191a5178116eb986389a1d97256300


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 26 2018

Cc: nyquist@chromium.org jinsuk...@chromium.org boliu@chromium.org
Owner: jinsuk...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11df8c93440000

Android: Consolidate scroll status update in GestureListenerManager by jinsukkim@chromium.org
https://chromium.googlesource.com/chromium/src/+/3b0346f62fabc05705488b163540cd09784b7e01

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/15d31f7d440000
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/13ccd6ed440000
Cc: dtu@chromium.org
+dtu, another case of confusing UI for try jobs in #6 and #7.

For clarity, the metric shown in the graph that "couldn't reproduce a difference" is success rate: the benchmark ran correctly 100% of the time in both runs. To dig into the performance metrics, you'll need to look at the results by clicking "Analyze Benchmark Results" link:

#6: https://pinpoint-dot-chromeperf.appspot.com/results2/15d31f7d440000
#7: https://pinpoint-dot-chromeperf.appspot.com/results2/13ccd6ed440000

We're working on making it show the right metric.

Comment 9 by dtu@chromium.org, Mar 27 2018

If you click the "+" on the bisect job result page (from comment 3) it will show the right metric. If you click the "+" on the jobs listing page, it will run without a specific metric.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df7bcac1a864f3e62c6267807ac60ad37b35e25

commit 0df7bcac1a864f3e62c6267807ac60ad37b35e25
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed Mar 28 22:48:50 2018

Android: Fix error in action mode on scroll

Fixes a mistake in the refactoring https://crrrev.com/c/965863.
This caused the reported UI error, and likely to have caused
other regressions as it affected scroll.

Bug:  825593 , 825597 , 825604 , 825796 ,826247

Change-Id: I606c2e94b43f3b5b40fe5a02c5b6aaf3db21dd70
Reviewed-on: https://chromium-review.googlesource.com/981472
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546637}
[modify] https://crrev.com/0df7bcac1a864f3e62c6267807ac60ad37b35e25/content/public/android/java/src/org/chromium/content/browser/GestureListenerManagerImpl.java

Mergedinto: 825604
Status: Duplicate (was: Assigned)

Sign in to add a comment