Increase tap target for "Done" button in tab grid on phones |
||||||||||
Issue descriptionWe should probably increase the tap target a bit in both modes (portrait and landscape) to easily switch between opening and closing tab grid.
,
Mar 26 2018
I agree it might be weird but the current setup is not ideal either. Could we perhaps try extending it a bit and see how it feels?
,
Mar 26 2018
,
Mar 26 2018
I'm happy to give it a try. I am assigning this to me.
,
Apr 6 2018
,
Apr 10 2018
Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable? If a fix is in active development, please set the status to Started. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
,
Apr 16 2018
,
Apr 26 2018
,
Jun 22 2018
This doesn't seem as important as other bugs; dropping to P2 unless you object
,
Jun 25 2018
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a6346e3f1912afb92d8a35a7977eaaa9386e770 commit 7a6346e3f1912afb92d8a35a7977eaaa9386e770 Author: edchin <edchin@chromium.org> Date: Mon Jun 25 23:17:04 2018 [ios] Extend done button in tab grid The done button tap target should be expanded so that the user can tap the same spot when entering and exiting the tab grid. This CL also fixes the ellipsis when changing the "Close All" button text to "Undo". Bug: 825787 , 849193 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I352e9654419c670f6dea431003a9c189ed639156 Reviewed-on: https://chromium-review.googlesource.com/1114149 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570228} [modify] https://crrev.com/7a6346e3f1912afb92d8a35a7977eaaa9386e770/ios/chrome/browser/ui/tab_grid/BUILD.gn [modify] https://crrev.com/7a6346e3f1912afb92d8a35a7977eaaa9386e770/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm [modify] https://crrev.com/7a6346e3f1912afb92d8a35a7977eaaa9386e770/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
,
Jun 25 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by edchin@chromium.org
, Mar 26 2018