Issue metadata
Sign in to add a comment
|
Regression: Unable to drag extension icon from chrome toolbar to wrench menu.
Reported by
db...@etouch.net,
Mar 26 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3379.0 Revision 1a1fb435932e9d87bebcdb0a0b2c5e2f3de3a694-refs/heads/master@{#545319}(64 bit) OS: Mac(10.12.6,10.13.1, 10.13.4) URL: https://chrome.google.com/webstore/detail/honey/bmnlcjabgnpnenekpadlanbbkooimhnj/related?hl=en-GB What steps will reproduce the problem? (1) Launch chrome, navigate to above URL and click on ADD TO CHROME button. (2) Drag extension icon from chrome toolbar to wrench menu and observe. Actual: Unable to drag extension icon from chrome toolbar to wrench menu. Expected: Extension icon should be able to drag to wrench menu. This is a regression issue broken in ‘M-67’ and using per-revision bisect providing the bisect results, Good Build:67.0.3378.0(Revision: 544932) Bad Build:67.0.3379.0(Revision: 545319) You are probably looking for a change made after 544962 (known good), but no later than 544963 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/fae199abc147d925470e745e0fa2752775d4fa63..bd465948ea74fbf1d40c495832e4306c07c13406 Suspect:https://chromium.googlesource.com/chromium/src/+/bd465948ea74fbf1d40c495832e4306c07c13406 @Ahmed Fakhry: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note:Issue is Not seen on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS.
,
Mar 29 2018
Similarly for this bug, can you please take a look? Thanks!
,
May 2 2018
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e132a7eb3c39e5839444aff108d783c2a68b92c2 commit e132a7eb3c39e5839444aff108d783c2a68b92c2 Author: spqchan <spqchan@chromium.org> Date: Thu May 03 15:24:19 2018 [Mac] Fix padding in browser actions container The horizontal padding around the browser actions container was incorrectly reduced. This causes issues where you can't resize the omnibox (because the extensions now overlap the gripper) or drag the extensions into the wrench menu Bug: 825378 , 825782 Change-Id: I66061a67546fab679c280a8d816b78dbe19b876e Reviewed-on: https://chromium-review.googlesource.com/1040914 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555740} [modify] https://crrev.com/e132a7eb3c39e5839444aff108d783c2a68b92c2/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
,
May 3 2018
spqchan@ could you please try your fix in all modes of the setting --top-chrome-md in chrome://flags or via command-line, to make sure it would work in all case. Thank you!
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba01abd5b57c78d4e1259428d7e8dfe3ca3fc6e4 commit ba01abd5b57c78d4e1259428d7e8dfe3ca3fc6e4 Author: spqchan <spqchan@chromium.org> Date: Wed May 09 18:21:50 2018 [Mac] Fix padding in browser actions container The horizontal padding around the browser actions container was incorrectly reduced. This causes issues where you can't resize the omnibox (because the extensions now overlap the gripper) or drag the extensions into the wrench menu (cherry picked from commit e132a7eb3c39e5839444aff108d783c2a68b92c2) Bug: 825378 , 825782 Change-Id: I66061a67546fab679c280a8d816b78dbe19b876e Reviewed-on: https://chromium-review.googlesource.com/1040914 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555740} Reviewed-on: https://chromium-review.googlesource.com/1052670 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#536} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/ba01abd5b57c78d4e1259428d7e8dfe3ca3fc6e4/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
,
May 29 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Mar 26 2018