Non-Regression:Folder drop down doesn't get opens in files app menu when we hit Enter key |
|||||
Issue descriptionChrome Version:66.0.3359.52/10452.27.0 beta channel Falco,Gnawty OS:chrome OS What steps will reproduce the problem? (1)Sign into user >>Open files app >>Keep focus highlight on My Drive which has drop down>>Hit Enter and Observe Actual: On hitting Enter key,My Drive folder opens but the folder drop down doesn't get opened in Context menu Expected:On hitting Enter,My Drive folder should open along with the folder drop down in menu This is a Non-Regression issue seen from M-62. Note:Issue is not seen in Windows,Linux OS Attached the screencast for reference.. @Fukino: Could you please confirm the issue.
,
Mar 28 2018
,
Nov 19
,
Nov 20
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1411c3034c28644a2628419b2a9ac28950350739 commit 1411c3034c28644a2628419b2a9ac28950350739 Author: Sam McNally <sammc@chromium.org> Date: Wed Nov 21 04:05:51 2018 Select "My Drive" when selecting "Google Drive" with the keyboard. Bug: 825779 Change-Id: I19fb082887c3383ba6e5d4db43cc20bfab7c999c Reviewed-on: https://chromium-review.googlesource.com/c/1345376 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609910} [modify] https://crrev.com/1411c3034c28644a2628419b2a9ac28950350739/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc [modify] https://crrev.com/1411c3034c28644a2628419b2a9ac28950350739/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/1411c3034c28644a2628419b2a9ac28950350739/ui/file_manager/integration_tests/file_manager/keyboard_operations.js
,
Nov 21
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/765fd08a2920138cef4adccf6706349116d6a2af commit 765fd08a2920138cef4adccf6706349116d6a2af Author: Sam McNally <sammc@chromium.org> Date: Fri Nov 23 02:21:11 2018 Fix handling of clicks on the Google Drive expand icon. https://crrev.com/609910 made activating "Google Drive" via the enter key expand it and select "My Drive". However, it also made clicking on the expand icon have that effect. Correct this by plumbing through the event target so the same conditions apply for click events as before. Bug: 825779 Change-Id: I38661323ce1aa5fc9eeec9968aae09259c9dc84d Reviewed-on: https://chromium-review.googlesource.com/c/1347970 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610516} [modify] https://crrev.com/765fd08a2920138cef4adccf6706349116d6a2af/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by weifangsun@chromium.org
, Mar 27 2018Labels: -Pri-2 -M-66 M-67 Pri-3
Owner: ----
Status: Available (was: Assigned)