New issue
Advanced search Search tips

Issue 825748 link

Starred by 1 user
Status: Fixed
Owner:
h...@chromium.org
Closed: Mar 2018
Cc:
thakis@chromium.org
inglorion@chromium.org
r...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 823655



Sign in to add a comment

sbox_integration_tests and remoting_unit_tests fail with tip-of-tree Clang on Windows

Project Member Reported by h...@chromium.org, Mar 26 2018 
It's showing across all the tot windows builds. For example:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1159

It doesn't reproduce with pinned Clang, so it looks like a real Clang regression. I've started bisection.


[ RUN      ] RdpClientTest.Basic
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	ATL::IDispEventSimpleImpl<1,remoting::RdpClientWindow,&_GUID_336d5562_efa8_482e_8cb3_c5c0fc7a7db6>::InvokeFromFuncInfo [0x000000013FF02AF8+120]
	ATL::IDispEventSimpleImpl<1,remoting::RdpClientWindow,&_GUID_336d5562_efa8_482e_8cb3_c5c0fc7a7db6>::Invoke [0x000000013FEFB40D+221]
	(No symbol) [0x000007FEF0AD25BE]
	(No symbol) [0x0000000000378AD8]
	(No symbol) [0x0000000001D919D8]
	(No symbol) [0x000007FEF0D2CFD8]
	(No symbol) [0x000000000018B2C8]
	(No symbol) [0x000007FEF0A50001]
	(No symbol) [0x00000000002EEB20]


[ RUN      ] SyncPolicyTest.TestEvent
../../sandbox/win/src/sync_policy_test.cc(98): error: Expected equality of these values:
  SBOX_TEST_SUCCEEDED
    Which is: 632356865
  runner.RunTest(L"Event_CreateOpen f f")
    Which is: -441384949
../../sandbox/win/src/sync_policy_test.cc(99): error: Expected equality of these values:
  SBOX_TEST_SUCCEEDED
    Which is: 632356865
  runner.RunTest(L"Event_CreateOpen t f")
    Which is: -441384949
../../sandbox/win/src/sync_policy_test.cc(102): error: Expected equality of these values:
  SBOX_TEST_SUCCEEDED
    Which is: 632356865
  runner.RunTest(L"Event_CreateOpen f f test1")
    Which is: -441384949
../../sandbox/win/src/sync_policy_test.cc(103): error: Expected equality of these values:
  SBOX_TEST_SUCCEEDED
    Which is: 632356865
  runner.RunTest(L"Event_CreateOpen t f test2")
    Which is: -441384949

Comment 1 by h...@chromium.org, Mar 26 2018 

Bisection points to this:

Author: rnk
Date: Fri Mar 23 16:38:53 2018
New Revision: 328386

URL: http://llvm.org/viewvc/llvm-project?rev=328386&view=rev
Log:
[X86] Fix Windows `i1 zeroext` conventions to use i8 instead of i32

Both GCC and MSVC only look at the low byte of a boolean when it is
passed.



(Hugs props to the cross-build and run-swarmed.py which made this easy to bisect.)

Comment 2 by h...@chromium.org, Mar 26 2018

Status: Fixed (was: Started)
s/Hugs/Huge/ above.

mstorsjo already submitted a follow-up patch that appears to fix the problem: https://reviews.llvm.org/D44876

But until that's landed, I've gone ahead and reverted in r328482 to get green bots.

Comment 3 by r...@chromium.org, Mar 26 2018 

Sorry for the redness, thank you for the revert!
►

Sign in to add a comment