New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825725 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Right-clicking on Team Drive shows blank separators

Project Member Reported by sashab@chromium.org, Mar 26 2018

Issue description

See screenshots to compare with regular local Downloads folder and folder in Google Drive.

Weifang - which options would we like to appear in the context menu? Should they appear greyed-out, or not at all?
 
Team drive.png
24.9 KB View Download
local_folder.png
33.8 KB View Download
My drive folder.png
35.7 KB View Download

Comment 1 by sashab@chromium.org, Mar 26 2018

Summary: Right-clicking on Team Drive shows blank separators (was: Right-clicking on Team Drive gives extra horizontal rules)
We should support the same context menu options as My Drive. Any actions that are not applicable at the time that the menu is launched (ex. Paste into folder) should appear, but be greyed out.
Cc: weifangsun@chromium.org
Labels: M-68
Owner: ----
Status: Available (was: Assigned)
Cc: -sashab@chromium.org
Owner: sashab@chromium.org
Status: Started (was: Available)
Fix in progress; see attached screenshot.

All the same items appear as for My Drive, but are greyed out. 'New Folder' and 'Paste into Folder' appear not greyed-out when they are available.
team-drives-context-menu-new.png
21.4 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc8c131602c8e7997f0370732adf3d382dd02c0

commit acc8c131602c8e7997f0370732adf3d382dd02c0
Author: Sasha Morrissey <sashab@chromium.org>
Date: Fri Apr 13 04:23:37 2018

Fix context menu for Team Drives in Files.app

Fix the context menu for Team Drives in Files.app to show all available
options, but greyed out. Later, these will become available if the user
has the necessary permissions for that team drive.

This also fixes a bug where selecting 'New Folder' for a Team Drive
would not target the name of the new folder for editing. Now, creating
a new folder under a team drive using the context menu correctly focuses
the name text area for the new folder.

Bug:  825725 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I785e381369c892caa48a1a9141d296c8e7888d44
Reviewed-on: https://chromium-review.googlesource.com/996832
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550516}
[modify] https://crrev.com/acc8c131602c8e7997f0370732adf3d382dd02c0/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/acc8c131602c8e7997f0370732adf3d382dd02c0/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Comment 7 by sashab@chromium.org, Apr 13 2018

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc8c131602c8e7997f0370732adf3d382dd02c0

commit acc8c131602c8e7997f0370732adf3d382dd02c0
Author: Sasha Morrissey <sashab@chromium.org>
Date: Fri Apr 13 04:23:37 2018

Fix context menu for Team Drives in Files.app

Fix the context menu for Team Drives in Files.app to show all available
options, but greyed out. Later, these will become available if the user
has the necessary permissions for that team drive.

This also fixes a bug where selecting 'New Folder' for a Team Drive
would not target the name of the new folder for editing. Now, creating
a new folder under a team drive using the context menu correctly focuses
the name text area for the new folder.

Bug:  825725 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I785e381369c892caa48a1a9141d296c8e7888d44
Reviewed-on: https://chromium-review.googlesource.com/996832
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550516}
[modify] https://crrev.com/acc8c131602c8e7997f0370732adf3d382dd02c0/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/acc8c131602c8e7997f0370732adf3d382dd02c0/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Comment 9 by sashab@chromium.org, Jun 19 2018

Status: Assigned (was: Fixed)
Re-opening; the context menu for Team Drives became unavailable in the file tree at some point. Will look at re-enabling it.
Labels: -M-68 M-69
Status: Fixed (was: Assigned)

Sign in to add a comment