Issue metadata
Sign in to add a comment
|
Some base_unittests test crashes are not being reported as failures |
||||||||||||||||||||||
Issue descriptionIn e.g. FYI run https://ci.chromium.org/buildbot/chromium.fyi/Fuchsia/15265 three tests from base_unitttests fail, and are listed in the summary output, but the step is marked as passing.
,
Mar 26 2018
It looks like pkgfs namespace entries use a different fd transfer policy than farfs. Investigating.
,
Mar 26 2018
Sorry, didn't mean to derail the bug. This bug should be focused on the result processing infra. Here's a bug which discusses the issues on comment #2: https://bugs.chromium.org/p/chromium/issues/detail?id=826018
,
Mar 26 2018
It looks like the test output JSON is recording the test runs as CRASHED, and the outputs for the crashed tests are exposed as links in the test run summary page. Is there a policy somewhere that tells the trybot whether to handle crashes as failures? https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=945b3d6f19be5b3b1fcf75ad3e45fa3caa5420c8&as=output.json
,
Mar 26 2018
That's not quite the issue here; the recipe-side code that parses that JSON is (correctly) picking out the individual test failures. The process is exiting w/ a 0, though, so the recipes think that it has passed despite the contained failures.
,
Mar 26 2018
Ah... >_< Thanks John, that's an easy fix: https://chromium-review.googlesource.com/c/chromium/src/+/981438
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1022fce2628003b41923b7eef64341427c4c7ee commit c1022fce2628003b41923b7eef64341427c4c7ee Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Mar 27 03:04:36 2018 Fuchsia: return exit code from executables. The current implementation was masking error return values, making all test and executable runs return 0. This lead to waterfall errors being shown as green/passing. Bug: 825714 Change-Id: I977faf461fceb5b5cd2d3e8e22d0c0135c77ce71 Reviewed-on: https://chromium-review.googlesource.com/981438 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#545925} [modify] https://crrev.com/c1022fce2628003b41923b7eef64341427c4c7ee/build/fuchsia/runner_v2/exe_runner.py [modify] https://crrev.com/c1022fce2628003b41923b7eef64341427c4c7ee/build/fuchsia/runner_v2/test_runner.py
,
Mar 27 2018
I see test failures on the FYI bot. Hurrah! (and also: Booo!) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by w...@chromium.org
, Mar 26 2018