New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825709 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 831912



Sign in to add a comment

VK shows up but pressing the keys does not enter

Project Member Reported by satorux@chromium.org, Mar 26 2018

Issue description

Chrome Version       : 67.0.3376.0
OS Version: 10506.0.0

What steps will reproduce the problem?
1. Enter the tablet mode
2. Hit a text field -> VK shows up
3. Press the keys on the VK

What is the expected result?

Pressed keys are entered in the text field

What happens instead of that?

Nothing happens

Please provide any additional information below. Attach a screenshot if
possible.

I'm seeing this problem on my Pixelbook. It's still reproducible locally.

 
Cc: wuyingbing@chromium.org
Owner: iloahz@chromium.org
Status: Assigned (was: Available)
Assigning this to Li as he is looking at it.

Comment 3 by iloahz@chromium.org, Mar 27 2018

Hi Satorux@,

I was not able to reproduce this issue, even with 10506 flashed to a real device. Are you still consistently reproducing this issue? If so, can you please provide a more detailed repro step?

Also I found 2 other bugs could be related to this, http://crbug/826167 and http://crbug/826168, we'll look into them and get you updated.

Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfbb726b897c2bdafe0d9c684934ffb11e0d833e

commit dfbb726b897c2bdafe0d9c684934ffb11e0d833e
Author: Li Zhao <iloahz@chromium.org>
Date: Wed Apr 04 07:51:40 2018

Always allow call to setDraggableArea.

Virtual keyboard's extension may call this function when controller has
been destroyed(when system switch from virtual keyboard to physical
keyboard) or in full width mode, no need to throw exception in these
cases.

Bug:  825709 
Change-Id: I8e565f7b090f619d08814af55450ad0f437486cd
Reviewed-on: https://chromium-review.googlesource.com/994497
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Li Zhao <iloahz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548002}
[modify] https://crrev.com/dfbb726b897c2bdafe0d9c684934ffb11e0d833e/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/dfbb726b897c2bdafe0d9c684934ffb11e0d833e/ui/keyboard/container_full_width_behavior.cc

From the comment in the CL:
> maybe we could return a status code value rather than a boolean and the extension can choose to ignore error codes of type ERROR_THATS_NOT_APPLICABLE_TO_THE_CURRENT_CONTAINER_TYPE
the exception shown in the screenshots will be fixed by the commit in chromium.

and we think there might be some other bugs causing text not committing, since the fixed exception is not critical.

i'll keep investigating and update here.
Blockedon: 831912
Labels: M-66 M-67
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 13 2018

Labels: Merge-Request-66 Merge-Approved-67
Labels: -Merge-Approved-67 Merge-Request-67
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 14 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We are only 2 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 15 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/564d22b234a766bc56f04915c4ca1c72504c7728

commit 564d22b234a766bc56f04915c4ca1c72504c7728
Author: Yingbing Wu <wuyingbing@google.com>
Date: Tue Apr 17 02:28:36 2018

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-release-R67-10575.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/955472dd8ed5a59625d047a7d8d5b99402ef46b1

commit 955472dd8ed5a59625d047a7d8d5b99402ef46b1
Author: Yingbing Wu <wuyingbing@google.com>
Date: Tue Apr 17 02:28:39 2018

Comment 18 by josa...@google.com, Apr 17 2018

Owner: wuyingbing@chromium.org
This change appears to have broken the build on M66 

snippet:
input-tools-6.9.0.8.1-r1:  *  '/build/samus/tmp/portage/logs/app-i18n:input-tools-6.9.0.8.1-r1:20180417-073742.log'
=== Complete: job input-tools-6.9.0.8.1-r1 (0m2.7s) ===
Failed app-i18n/input-tools-6.9.0.8.1-r1 (in 0m2.7s). Your build has failed.
Pending 3/754, [Time 00:37:44 | Elapsed 41m51.6s | Load 2.13 5.94 9.05]
Packages failed:
	app-i18n/input-tools-6.9.0.8.1-r1
using /tmp/goma_tmp_dir.yg7DS3 as tmpdir
Killing compiler proxy.
compiler proxy status: http://127.0.0.1:8088 quit!
ERROR   : Tue Apr 17 00:37:46 PDT 2018
ERROR   :  PGID  PPID   PID     ELAPSED     TIME %CPU COMMAND
ERROR   : Arguments of 10: ./build_packages '--board=samus' '--accept_licenses=@CHROMEOS' '--withdebugsymbols' '--skip_chroot_upgrade' '--run_goma' '--withevents' '--eventfile=/mnt/host/source/buildbot_archive/samus-chrome-pre-flight-branch/R66-10452.68.0-rc10/build-events.json' 'virtual/target-os' 'virtual/target-os-dev' 'virtual/target-os-test' 'virtual/target-os-factory' 'virtual/target-os-factory-shim' 'chromeos-base/autotest-all'
ERROR   : Backtrace:  (most recent call is last)
ERROR   :  build_packages:329:main(), called: die_err_trap  
ERROR   : 
ERROR   : Command failed:
ERROR   :   Command '( if [[ "${FLAGS_run_goma}" -eq "${FLAGS_TRUE}" ]]; then
ERROR   :     info "Starting goma compiler_proxy."; goma_ctl="${GOMA_DIR:-${HOME}/goma}/goma_ctl.py"; "${goma_ctl}" restart; trap "'${goma_ctl}' stop" EXIT;
ERROR   : fi; set -o pipefail; sudo -E "${EMERGE_CMD[@]}" "${EMERGE_FLAGS[@]}" "${PACKAGES[@]}" | tee "${tmpfile}" )' exited with nonzero code: 1
00:37:47: ERROR: 

Full log:
https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos_release%2Fsamus-chrome-pre-flight-branch_release-R66-10452.B%2F223%2F%2B%2Frecipes%2Fsteps%2FBuildPackages%2F0%2Fstdout
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/5c99747908693a2aa6c06da3d3b6bbcb17cc0f08

commit 5c99747908693a2aa6c06da3d3b6bbcb17cc0f08
Author: Josafat Garcia <josafat@google.com>
Date: Tue Apr 17 15:12:06 2018

Comment 20 by josa...@google.com, Apr 17 2018

Labels: -Merge-Approved-66 -merge-merged-release-R66-10452.B
I have reverted this change in M66
removing merge labels for M66.  Feel free to request merge back with a new working CL 
Actual error is:

=== Start output for job input-tools-6.9.0.8.1-r1 (0m2.7s) ===
input-tools-6.9.0.8.1-r1: >>> Emerging (1 of 1) app-i18n/input-tools-6.9.0.8.1-r1::chromeos for /build/samus/
input-tools-6.9.0.8.1-r1: 00:37:42: INFO: RunCommand: /mnt/host/source/.cache/common/gsutil_4.27.tar.gz/gsutil/gsutil -o 'Boto:num_retries=10' cp -v -- gs://chromeos-localmirror-private/distfiles/input-tools-6.9.0.8.1.tar.gz /var/cache/chromeos-cache/distfiles/target/input-tools-6.9.0.8.1.tar.gz.tmp
input-tools-6.9.0.8.1-r1: !!! Fetched file: input-tools-6.9.0.8.1.tar.gz VERIFY FAILED!
input-tools-6.9.0.8.1-r1: !!! Reason: Filesize does not match recorded size
input-tools-6.9.0.8.1-r1: !!! Got:      59003699
input-tools-6.9.0.8.1-r1: !!! Expected: 59003698
input-tools-6.9.0.8.1-r1: Refetching... File renamed to '/var/cache/chromeos-cache/distfiles/target/input-tools-6.9.0.8.1.tar.gz._checksum_failure_.BJ6b7k'
input-tools-6.9.0.8.1-r1: 
input-tools-6.9.0.8.1-r1: !!! Couldn't download 'input-tools-6.9.0.8.1.tar.gz'. Aborting.
input-tools-6.9.0.8.1-r1:  * Fetch failed for 'app-i18n/input-tools-6.9.0.8.1-r1', Log file:
input-tools-6.9.0.8.1-r1:  *  '/build/samus/tmp/portage/logs/app-i18n:input-tools-6.9.0.8.1-r1:20180417-073742.log'
input-tools-6.9.0.8.1-r1: >>> Failed to emerge app-i18n/input-tools-6.9.0.8.1-r1 for /build/samus/, Log file:
input-tools-6.9.0.8.1-r1: >>>  '/build/samus/tmp/portage/logs/app-i18n:input-tools-6.9.0.8.1-r1:20180417-073742.log'
input-tools-6.9.0.8.1-r1: 
input-tools-6.9.0.8.1-r1:  * Messages for package app-i18n/input-tools-6.9.0.8.1-r1 merged to /build/samus/:
input-tools-6.9.0.8.1-r1: 
input-tools-6.9.0.8.1-r1:  * Fetch failed for 'app-i18n/input-tools-6.9.0.8.1-r1', Log file:
input-tools-6.9.0.8.1-r1:  *  '/build/samus/tmp/portage/logs/app-i18n:input-tools-6.9.0.8.1-r1:20180417-073742.log'
=== Complete: job input-tools-6.9.0.8.1-r1 (0m2.7s) ===


file size in Manifest file seems to be wrong.
Labels: Merge-Request-66
Project Member

Comment 23 by sheriffbot@chromium.org, Apr 18 2018

Labels: -Merge-Request-66 Merge-Review-66
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 19 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/c427f6523ec9b249fe3b7e8cb7eb424b39d63e5b

commit c427f6523ec9b249fe3b7e8cb7eb424b39d63e5b
Author: Yingbing Wu <wuyingbing@google.com>
Date: Thu Apr 19 03:20:25 2018

Project Member

Comment 25 by sheriffbot@chromium.org, Apr 19 2018

Cc: josa...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
anything else pending to be merged here? (otherwise please set as fixed)

Status: Fixed (was: Started)
Labels: -Merge-Approved-67 -Merge-Review-66

Sign in to add a comment