New issue
Advanced search Search tips

Issue 825679 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use of an invalid mutex in media::AudioOutputDevice::NotifyRenderCallbackOfError

Project Member Reported by ClusterFuzz, Mar 26 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6551447425253376

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Use of an invalid mutex
Crash Address: 
Crash State:
  media::AudioOutputDevice::NotifyRenderCallbackOfError
  media::AudioOutputDevice::OnDeviceAuthorized
  media::AudioOutputDevice::OnDeviceAuthorized
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=543351:543352

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6551447425253376

Additional requirements: Requires HTTP

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 26 2018

Components: Blink>Media>Audio Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 26 2018

Labels: Test-Predator-Auto-Owner
Owner: maxmorin@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/e1411c5f0257ee538349fdc70bd6d99a1206b116 (Reland "Fix yet another AudioOutputDevice crash.").

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Internals>Core
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows Pri-1
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e4caf1294020283a44cada9aa710fef337c717

commit 71e4caf1294020283a44cada9aa710fef337c717
Author: Max Morin <maxmorin@chromium.org>
Date: Mon Mar 26 10:20:19 2018

Fix another three missing calls to ARS::Stop().

It shouldn't be possible to have an infinite number of these bugs, so
I'll just keep fixing them and hope the Clusterfuzz reports come to an
end :).

Bug:  825679 
Change-Id: I899c87b7849cdf7cefc50976b247bce4307b89d2
Reviewed-on: https://chromium-review.googlesource.com/979801
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545753}
[modify] https://crrev.com/71e4caf1294020283a44cada9aa710fef337c717/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/71e4caf1294020283a44cada9aa710fef337c717/content/renderer/media/stream/track_audio_renderer.h
[modify] https://crrev.com/71e4caf1294020283a44cada9aa710fef337c717/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/71e4caf1294020283a44cada9aa710fef337c717/content/renderer/media/webrtc/webrtc_audio_renderer_unittest.cc

Project Member

Comment 5 by sheriffbot@chromium.org, Mar 26 2018

Labels: M-67
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 26 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by ClusterFuzz, Mar 27 2018

ClusterFuzz has detected this issue as fixed in range 545752:545753.

Detailed report: https://clusterfuzz.com/testcase?key=6551447425253376

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_tsan_chrome_mp
Platform Id: linux

Crash Type: Use of an invalid mutex
Crash Address: 
Crash State:
  media::AudioOutputDevice::NotifyRenderCallbackOfError
  media::AudioOutputDevice::OnDeviceAuthorized
  media::AudioOutputDevice::OnDeviceAuthorized
  
Sanitizer: thread (TSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=543351:543352
Fixed: https://clusterfuzz.com/revisions?job=linux_tsan_chrome_mp&range=545752:545753

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6551447425253376

Additional requirements: Requires HTTP

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Mar 27 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6551447425253376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: Merge-Request-66
Requesting merge of CL in Comment 4 to M66.
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Approving merge to M66. Branch:3359
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 28 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73590e189d8b99a53ee77c69ffcfbc9c150380d3

commit 73590e189d8b99a53ee77c69ffcfbc9c150380d3
Author: Max Morin <maxmorin@chromium.org>
Date: Wed Mar 28 06:56:55 2018

[M66] Fix another three missing calls to ARS::Stop().

It shouldn't be possible to have an infinite number of these bugs, so
I'll just keep fixing them and hope the Clusterfuzz reports come to an
end :).

Bug:  825679 
Change-Id: I899c87b7849cdf7cefc50976b247bce4307b89d2
Reviewed-on: https://chromium-review.googlesource.com/979801
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#545753}(cherry picked from commit 71e4caf1294020283a44cada9aa710fef337c717)
Reviewed-on: https://chromium-review.googlesource.com/983213
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#482}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/73590e189d8b99a53ee77c69ffcfbc9c150380d3/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/73590e189d8b99a53ee77c69ffcfbc9c150380d3/content/renderer/media/stream/track_audio_renderer.h
[modify] https://crrev.com/73590e189d8b99a53ee77c69ffcfbc9c150380d3/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/73590e189d8b99a53ee77c69ffcfbc9c150380d3/content/renderer/media/webrtc/webrtc_audio_renderer_unittest.cc

Labels: -ReleaseBlock-Stable

Sign in to add a comment