New issue
Advanced search Search tips

Issue 825670 link

Starred by 3 users
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

New QS: brightness animates every time opened

Project Member Reported by omrilio@chromium.org, Mar 25 2018 
Chrome Version: (67.0.3375.0)

What steps will reproduce the problem?
(1) open new QS

What is the expected result?
Opens QS

What happens instead?
opens QSand animates brightness control





Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by omrilio@chromium.org, Mar 25 2018 

video 📹
capture (2).webm
1.5 MB View Download

Comment 2 by tetsui@chromium.org, Mar 26 2018

Status: Assigned (was: Untriaged)

Comment 3 by tetsui@chromium.org, Apr 10 2018

Status: Started (was: Assigned)

Comment 4 by satorux@chromium.org, Apr 11 2018 

I just saw it too
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0

commit 866b53c3a7079e17b7d1d6bf551e4dc3f457dae0
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Apr 12 05:31:18 2018

Add UnifiedSystemTrayModel to store UI variables.

In UnifiedSystemTray, there are some UI specific variables that have to
be stored (across tray bubble lifetime).

* The tray bubble should keep the expanded/collapsed state when it's
  reopened.
* Brightness slider's value have to be cached.

This CL creates UnifiedSystemTrayModel to store these variables, which
is owned by UnifiedSystemTray.

TEST=manual
BUG= 825670 

Change-Id: I56a285d4fa6c334ccafe114c9664ac42900a6696
Reviewed-on: https://chromium-review.googlesource.com/1006134
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550020}
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/BUILD.gn
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/brightness/unified_brightness_slider_controller.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/brightness/unified_brightness_slider_controller.h
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/brightness/unified_brightness_view.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/brightness/unified_brightness_view.h
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/accessibility_feature_pod_controller_unittest.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/feature_pods_container_view.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/feature_pods_container_view.h
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/feature_pods_container_view_unittest.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/top_shortcuts_view_unittest.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray.h
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray_bubble.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray_controller.h
[add] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray_model.cc
[add] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray_model.h
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray_view.cc
[modify] https://crrev.com/866b53c3a7079e17b7d1d6bf551e4dc3f457dae0/ash/system/unified/unified_system_tray_view.h

Comment 7 by tetsui@chromium.org, Apr 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment