New issue
Advanced search Search tips

Issue 825644 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Merge v4.4.124 into chromeos-4.4

Project Member Reported by groeck@chromium.org, Mar 25 2018

Issue description

Merge v4.4.124 into chromeos-4.4
 

Comment 1 by groeck@chromium.org, Mar 26 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6b243349ec7c51c03d60683d7d94aa3dce0b6be8

commit 6b243349ec7c51c03d60683d7d94aa3dce0b6be8
Author: Jeremy Boone <jeremy.boone@nccgroup.trust>
Date: Tue Mar 27 03:16:37 2018

UPSTREAM: tpm_tis: fix potential buffer overruns caused by bit glitches on the bus

Discrete TPMs are often connected over slow serial buses which, on
some platforms, can have glitches causing bit flips.  In all the
driver _recv() functions, we need to use a u32 to unmarshal the
response size, otherwise a bit flip of the 31st bit would cause the
expected variable to go negative, which would then try to read a huge
amount of data.  Also sanity check that the expected amount of data is
large enough for the TPM header.

Signed-off-by: Jeremy Boone <jeremy.boone@nccgroup.trust>
Cc: stable@vger.kernel.org
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: James Morris <james.morris@microsoft.com>
(cherry picked from commit 6bb320ca4a4a7b5b3db8c8d7250cc40002046878)
Signed-off-by: Andrey Pronin <apronin@chromium.org>

BUG= chromium:825644 
TEST=build

Change-Id: I18e49910b6fff51d31181165efbaa0836b9f1c52
Reviewed-on: https://chromium-review.googlesource.com/981319
Commit-Ready: Andrey Pronin <apronin@chromium.org>
Tested-by: Andrey Pronin <apronin@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/6b243349ec7c51c03d60683d7d94aa3dce0b6be8/drivers/char/tpm/tpm_tis_core.c

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e855b93eb569c867d90c31c71a777b352bdbfa46

commit e855b93eb569c867d90c31c71a777b352bdbfa46
Author: Guenter Roeck <groeck@chromium.org>
Date: Thu Mar 29 21:53:16 2018

CHROMIUM: Merge 'v4.4.124' into chromeos-4.4

Merge of v4.4.124 into chromeos-4.4

Changes applied on top of 'v4.4.124' prior to merge:
    68d247554f7c CHROMIUM: Revert "genirq: Use irqd_get_trigger_type to compare the trigger type for shared IRQs"
    73da2b9e7901 CHROMIUM: Revert "tpm_tis: fix potential buffer overruns caused by bit glitches on the bus"

Changelog:
----------------------------------------------------------------
Abel Vesa (1):
      ARM: 8668/1: ftrace: Fix dynamic ftrace with DEBUG_RODATA and !FRAME_POINTER

Alexey Kardashevskiy (1):
      KVM: PPC: Book3S PR: Exit KVM on failed mapping

Alexey Khoroshilov (1):
      sm501fb: don't return zero on failure path in sm501fb_start()

Alexey Kodanev (1):
      ip6_vti: adjust vti mtu according to mtu of lower device

Anton Vasilyev (1):
      RDMA/ocrdma: Fix permissions for OCRDMA_RESET_STATS

Arnd Bergmann (1):
      cros_ec: fix nul-termination for firmware build info

Artemy Kovalyov (1):
      IB/umem: Fix use of npages/nmap fields

Benjamin Coddington (2):
      NFS: Fix missing pg_cleanup after nfs_pageio_cond_complete()
      nfsd4: permit layoutget of executable-only files

Bernd Faust (1):
      e1000e: fix timing for 82579 Gigabit Ethernet controller

Bharat Kumar Reddy Gooty (1):
      clk: ns2: Correct SDIO bits

Bjorn Helgaas (1):
      vgacon: Set VGA struct resource types

Christophe JAILLET (1):
      media: bt8xx: Fix err 'bt878_probe()'

Dan Carpenter (4):
      HSI: ssi_protocol: double free in ssip_pn_xmit()
      ASoC: Intel: Skylake: Uninitialized variable in probe_codec()
      mmc: host: omap_hsmmc: checking for NULL instead of IS_ERR()
      cifs: small underflow in cnvrtDosUnixTm()

Daniel Drake (1):
      mmc: avoid removing non-removable hosts during suspend

David Ahern (1):
      net: ipv6: send unsolicited NA on admin up

David Gibson (1):
      scsi: virtio_scsi: Always try to read VPD pages

Deepa Dinamani (1):
      time: Change posix clocks ops interfaces to use timespec64

Dmitry Monakhov (1):
      tcm_fileio: Prevent information leak for short reads

Dmitry Torokhov (1):
      Input: ar1021_i2c - fix too long name in driver's device table

Dong Aisheng (1):
      regulator: anatop: set default voltage selector for pcie

Edgar Cherkasov (1):
      i2c: i2c-scmi: add a MS HID

Emmanuel Grumbach (1):
      mac80211: don't parse encrypted management frames in ieee80211_frame_acked

Erez Shitrit (1):
      IB/ipoib: Avoid memory leak if the SA returns a different DGID

Eric Dumazet (1):
      tcp: remove poll() flakes with FastOpen

Feras Daoud (2):
      IB/ipoib: Fix deadlock between ipoib_stop and mcast join flow
      IB/ipoib: Update broadcast object if PKey value was changed in index 0

Filipe Manana (1):
      Btrfs: send, fix file hole not being preserved due to inline extent

Finn Thain (1):
      scsi: mac_esp: Replace bogus memory barrier with spinlock

Florian Fainelli (1):
      pinctrl: Really force states during suspend/resume

Gao Feng (1):
      netfilter: xt_CT: fix refcnt leak on error path

Geert Uytterhoeven (1):
      RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()

Greg Kroah-Hartman (1):
      Linux 4.4.124

Guenter Roeck (3):
      CHROMIUM: Revert "tpm_tis: fix potential buffer overruns caused by bit glitches on the bus"
      CHROMIUM: Revert "genirq: Use irqd_get_trigger_type to compare the trigger type for shared IRQs"
      Merge remote-tracking branch 'origin/linux/v4.4.124' into merge/chromeos-4.4-v4.4.124

Guoqing Jiang (1):
      md/raid10: wait up frozen array in handle_write_completed

Gustavo A. R. Silva (1):
      media: c8sectpfe: fix potential NULL pointer dereference in c8sectpfe_timer_interrupt

Hans de Goede (4):
      x86: i8259: export legacy_pic symbol
      rtc: cmos: Do not assume irq 8 for rtc when there are no legacy irqs
      genirq: Use irqd_get_trigger_type to compare the trigger type for shared IRQs
      ACPI / PMIC: xpower: Fix power_table addresses

James Smart (1):
      Fix driver usage of 128B WQEs when WQ_CREATE is V1.

Jarno Rajahalme (1):
      openvswitch: Delete conntrack entry clashing with an expectation.

Jasmin J (1):
      media/dvb-core: Race condition when writing to CAM

Jeremy Boone (2):
      tpm: fix potential buffer overruns caused by bit glitches on the bus
      tpm_tis: fix potential buffer overruns caused by bit glitches on the bus

Jerry Snitselaar (1):
      iommu/vt-d: clean up pr_irq if request_threaded_irq fails

Keerthy (1):
      mfd: palmas: Reset the POWERHOLD mux during power off

Kim Phillips (1):
      perf tests kmod-path: Don't fail if compressed modules aren't supported

Kishon Vijay Abraham I (1):
      ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP

Leon Romanovsky (1):
      RDMA/ucma: Fix access to non-initialized CM_ID object

Loic Poulain (1):
      Bluetooth: hci_qca: Avoid setup failure on missing rampatch

Maksim Salau (1):
      video: fbdev: udlfb: Fix buffer on stack

Maor Gottlieb (2):
      IB/mlx4: Take write semaphore when changing the vma struct
      IB/mlx4: Change vma from shared to private

Marek Vasut (1):
      spi: dw: Disable clock after unregistering the host

Mario Kleiner (1):
      drm/nouveau/kms: Increase max retries in scanout position queries.

Michael Trimarchi (1):
      power: supply: pda_power: move from timer to delayed_work

Mikhail Paulyshka (1):
      ALSA: hda - Fix headset microphone detection for ASUS N551 and N751

Ming Lei (1):
      mtip32xx: use runtime tag to initialize command header

Mohammed Shafi Shajakhan (1):
      ath: Fix updating radar flags for coutry code India

Moritz Fischer (2):
      rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks
      rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

NeilBrown (1):
      NFS: don't try to cross a mountpount when there isn't one there.

Pan Bian (5):
      wan: pc300too: abort path on failure
      qlcnic: fix unchecked return value
      mt7601u: check return value of alloc_skb
      rndis_wlan: add return value validation
      staging: wilc1000: fix unchecked return value

Parav Pandit (1):
      RDMA/cma: Use correct size when writing netlink stats

Pavel Shilovsky (1):
      CIFS: Enable encryption during session setup phase

Peter Ujfalusi (1):
      drm/omap: DMM: Check for DMM readiness after successful transaction commit

Prakash Kamliya (1):
      drm/msm: fix leak in failed get_pages

Robert Lippert (1):
      ipmi/watchdog: fix wdog hang on panic waiting for ipmi response

Robert Walker (1):
      coresight: Fix disabling of CoreSight TPIU

Ron Economos (1):
      media: [RESEND] media: dvb-frontends: Add delay to Si2168 restart

Sahara (1):
      pty: cancel pty slave port buf's work in tty_release

Sameer Wadgaonkar (1):
      staging: unisys: visorhba: fix s-Par to boot with option CONFIG_VMAP_STACK set to y

Santeri Toivonen (1):
      platform/x86: asus-nb-wmi: Add wapf4 quirk for the X302UA

Scott Wood (1):
      bnx2x: Align RX buffers

Sebastian Reichel (1):
      Input: twl4030-pwrbutton - use correct device for irq request

Sergei Trofimovich (1):
      ia64: fix module loading for gcc-5.4

Sergej Sawazki (1):
      clk: si5351: Rename internal plls to avoid name collisions

Shaohua Li (1):
      md/raid10: skip spare disk as 'first' disk

Shawn Nematbakhsh (1):
      platform/chrome: Use proper protocol transfer function

Shrirang Bagul (1):
      iio: st_pressure: st_accel: Initialise sensor platform data properly

Steve French (1):
      SMB3: Validate negotiate request must always be signed

Suman Anna (1):
      iommu/omap: Register driver before setting IOMMU ops

Thomas Gleixner (3):
      ACPI/processor: Fix error handling in __acpi_processor_start()
      ACPI/processor: Replace racy task affinity logic
      cpufreq/sh: Replace racy task affinity logic

Timmy Li (1):
      net: hns: fix ethtool_get_strings overflow in hns driver

Tsang-Shian Lin (1):
      rtlwifi: rtl_pci: Fix the bug when inactiveps is enabled.

Vignesh R (1):
      dmaengine: ti-dma-crossbar: Fix event mapping for TPCC_EVT_MUX_60_63

Vlad Tsyrklevich (1):
      infiniband/uverbs: Fix integer overflows

Yisheng Xie (1):
      staging: android: ashmem: Fix possible deadlock in ashmem_ioctl

yangbo lu (1):
      mmc: sdhci-of-esdhc: limit SD clock for ls1012a/ls1046a

 Makefile                                           |  2 +-
 arch/alpha/kernel/console.c                        |  1 +
 arch/arm/kernel/ftrace.c                           | 11 ++--
 arch/arm/mach-omap2/clockdomains7xx_data.c         |  2 +-
 arch/ia64/kernel/module.c                          |  4 +-
 arch/powerpc/kvm/book3s_64_mmu_host.c              |  5 +-
 arch/powerpc/kvm/book3s_pr.c                       |  6 ++-
 arch/x86/kernel/i8259.c                            |  1 +
 drivers/acpi/pmic/intel_pmic_xpower.c              | 50 ++++++++---------
 drivers/acpi/processor_driver.c                    | 10 +++-
 drivers/acpi/processor_throttling.c                | 62 +++++++++++++---------
 drivers/block/mtip32xx/mtip32xx.c                  | 36 ++++++++-----
 drivers/bluetooth/hci_qca.c                        |  3 ++
 drivers/char/ipmi/ipmi_watchdog.c                  |  8 +--
 drivers/char/tpm/tpm-interface.c                   |  5 ++
 drivers/char/tpm/tpm2-cmd.c                        |  6 +++
 drivers/clk/bcm/clk-ns2.c                          |  2 +-
 drivers/clk/clk-si5351.c                           |  2 +-
 drivers/cpufreq/sh-cpufreq.c                       | 45 +++++++++-------
 drivers/dma/ti-dma-crossbar.c                      | 10 +++-
 drivers/gpu/drm/msm/msm_gem.c                      | 14 +++--
 drivers/gpu/drm/nouveau/nouveau_display.c          |  2 +-
 drivers/gpu/drm/omapdrm/omap_dmm_tiler.c           |  5 ++
 drivers/hsi/clients/ssi_protocol.c                 |  5 +-
 drivers/hwtracing/coresight/coresight-tpiu.c       | 13 +++--
 drivers/i2c/busses/i2c-scmi.c                      |  4 ++
 drivers/iio/accel/st_accel_core.c                  |  7 +--
 drivers/iio/pressure/st_pressure_core.c            |  8 +--
 drivers/infiniband/core/cma.c                      |  5 +-
 drivers/infiniband/core/iwpm_util.c                |  1 +
 drivers/infiniband/core/umem.c                     |  2 +-
 drivers/infiniband/core/uverbs_cmd.c               | 13 ++++-
 drivers/infiniband/hw/mlx4/main.c                  |  6 ++-
 drivers/infiniband/hw/ocrdma/ocrdma_stats.c        |  2 +-
 drivers/infiniband/ulp/ipoib/ipoib_ib.c            | 13 +++++
 drivers/infiniband/ulp/ipoib/ipoib_main.c          | 16 ++++++
 drivers/infiniband/ulp/ipoib/ipoib_multicast.c     | 11 ++--
 drivers/input/misc/twl4030-pwrbutton.c             |  2 +-
 drivers/input/touchscreen/ar1021_i2c.c             |  2 +-
 drivers/iommu/intel-svm.c                          |  9 ++--
 drivers/iommu/omap-iommu.c                         | 21 ++++++--
 drivers/md/raid10.c                                |  6 +++
 drivers/media/dvb-core/dvb_ca_en50221.c            | 23 ++++++++
 drivers/media/dvb-frontends/si2168.c               |  3 ++
 drivers/media/pci/bt8xx/bt878.c                    |  3 +-
 .../media/platform/sti/c8sectpfe/c8sectpfe-core.c  |  4 +-
 drivers/mfd/palmas.c                               | 14 +++++
 drivers/mmc/core/core.c                            |  8 +++
 drivers/mmc/host/omap_hsmmc.c                      |  4 +-
 drivers/mmc/host/sdhci-of-esdhc.c                  | 14 +++++
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c    |  1 +
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c |  2 +-
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c  |  2 +-
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c  |  2 +-
 .../net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c    |  2 +-
 drivers/net/ethernet/intel/e1000e/netdev.c         |  6 +++
 .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c   |  2 +
 drivers/net/wan/pc300too.c                         |  1 +
 drivers/net/wireless/ath/regd.c                    | 19 ++++---
 drivers/net/wireless/mediatek/mt7601u/mcu.c        | 10 +++-
 drivers/net/wireless/realtek/rtlwifi/pci.c         |  7 +++
 drivers/net/wireless/rndis_wlan.c                  |  4 ++
 drivers/pinctrl/core.c                             | 24 ++++++---
 drivers/platform/chrome/cros_ec_sysfs.c            |  2 +-
 drivers/platform/x86/asus-nb-wmi.c                 |  9 ++++
 drivers/power/pda_power.c                          | 49 +++++++++--------
 drivers/ptp/ptp_clock.c                            | 18 +++----
 drivers/regulator/anatop-regulator.c               |  5 ++
 drivers/rtc/rtc-cmos.c                             | 17 ++++--
 drivers/rtc/rtc-ds1374.c                           | 10 +++-
 drivers/scsi/lpfc/lpfc_sli.c                       |  3 ++
 drivers/scsi/mac_esp.c                             | 33 ++++++++----
 drivers/scsi/virtio_scsi.c                         | 24 +++++++++
 drivers/spi/spi-dw-mmio.c                          |  2 +-
 drivers/staging/android/ashmem.c                   |  8 ++-
 drivers/staging/unisys/visorhba/visorhba_main.c    |  8 ++-
 drivers/staging/wilc1000/linux_mon.c               |  2 +
 drivers/target/target_core_file.c                  | 23 +++++---
 drivers/tty/tty_io.c                               |  2 +
 drivers/video/console/vgacon.c                     | 34 +++++++++---
 drivers/video/fbdev/sm501fb.c                      |  1 +
 drivers/video/fbdev/udlfb.c                        | 14 ++++-
 fs/btrfs/send.c                                    | 23 +++++++-
 fs/cifs/netmisc.c                                  |  6 +--
 fs/cifs/sess.c                                     | 22 ++++----
 fs/cifs/smb2pdu.c                                  | 11 ++--
 fs/nfs/pagelist.c                                  |  6 ++-
 fs/nfsd/nfs4proc.c                                 |  6 +--
 fs/nfsd/vfs.c                                      | 24 +++++++--
 include/linux/posix-clock.h                        | 10 ++--
 kernel/time/posix-clock.c                          | 34 ++++++++----
 net/ipv4/tcp_input.c                               | 16 +++---
 net/ipv6/ip6_vti.c                                 | 20 +++++++
 net/ipv6/ndisc.c                                   |  2 +
 net/mac80211/status.c                              |  1 +
 net/netfilter/xt_CT.c                              | 11 +++-
 net/openvswitch/conntrack.c                        | 30 ++++++++++-
 sound/pci/hda/patch_realtek.c                      | 12 ++++-
 sound/soc/intel/skylake/skl.c                      |  2 +-
 tools/perf/tests/kmod-path.c                       |  2 +
 100 files changed, 799 insertions(+), 296 deletions(-)

BUG= chromium:825644 
TEST=Build and test on various affected systems

Change-Id: Id8fcd04645d38ffdb0cc143070332a14ffd69151
Signed-off-by: Guenter Roeck <groeck@chromium.org>


Comment 4 by groeck@chromium.org, Mar 30 2018

Status: Fixed (was: Started)

Sign in to add a comment