New issue
Advanced search Search tips

Issue 825637 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Can't drag window from overview to splitscreen via the title bar

Project Member Reported by omrilio@chromium.org, Mar 25 2018

Issue description

Chrome Version: 67.0.3367.0

What steps will reproduce the problem?
(1) Open at least one app
(2) Go to overview 
(3) Drag app from the new icon area in overview

What is the expected result?
App is draggable just as if you clicked on the thumbnail

What happens instead?
Not draggable
 
We probably specced the current behavior, but I agree people may try to drag from title  bar so we should support it.
i removed dragging on title bar https://chromium-review.googlesource.com/c/chromium/src/+/911849

i thought this was intended from  bug 775655  comment #11. Did i misunderstand something?
Apologies for the churn, Sammie, no misunderstanding on your part. Omri, how hi-pri is this? I agree we made a mistake here in what was specced, but I see this as lower priority than most of the other outstanding overview / splitscreen items.
Labels: -Pri-3 M-67 Pri-2
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a18383a5726138114e1d1be8e2d0aa3c9a2d39b

commit 2a18383a5726138114e1d1be8e2d0aa3c9a2d39b
Author: Sammie Quon <sammiequon@google.com>
Date: Thu Mar 29 22:11:39 2018

overview: Renable dragging windows on overview title bars.

Change of mind. Mostly a revert of
https://chromium-review.googlesource.com/c/chromium/src/+/911849.

Test: ash_unittests WindowSelectorTest.*
Bug:  825637 
Change-Id: I37bead0a8b1d80cd0c89c646feb5af2a1f0ffa1a
Reviewed-on: https://chromium-review.googlesource.com/986942
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546978}
[modify] https://crrev.com/2a18383a5726138114e1d1be8e2d0aa3c9a2d39b/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/2a18383a5726138114e1d1be8e2d0aa3c9a2d39b/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/2a18383a5726138114e1d1be8e2d0aa3c9a2d39b/ash/wm/overview/window_selector_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment