Issue metadata
Sign in to add a comment
|
6.3%-47.9% regression in blink_perf.owp_storage at 545358:545550 |
||||||||||||||||||
Issue descriptionNote there is also an improvement in BlobReader::ReadBytesItem at this range: https://chromeperf.appspot.com/group_report?sid=44357ffbc30ec457a53f9aa369c09c71f837fd9b6a5b35f3aee82a2d63c30d49
,
Mar 25 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1197413d440000
,
Mar 26 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1197413d440000 Disabling blink_perf.owp_storage on Android one by eyaich@google.com https://chromium.googlesource.com/chromium/src/+/6ccc199f6f18cfecb64e7fd8ff211865940591a9 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 2 2018
Ned, can you help triage this? It looks like blink_perf.owp_storage was disabled in the middle of the "regression" range--why is it still producing data?
,
Apr 2 2018
Looks like the disabling logic doesn't do anything. The test is still running on Android One (https://ci.chromium.org/buildbot/chromium.perf/Android%20One%20Perf/1354)
,
Apr 2 2018
I think what happened here is that Emily disabled one particular story (blink_perf.owp_storage/blob-perf-shm.html) in her CL. That story being disabled changed the monitored summary metric (Registry::RegisterBlob) and the bisect correctly identified that CL as being responsible. As far as I can tell, this is working as intended with the bug being that we really shouldn't monitor summary metrics for this reason.
,
Apr 2 2018
Simon, can you work with the benchmark owner to help them figure out how we can stop monitoring these summary metrics?
,
Apr 2 2018
I don't quite understand why we need to disable that metric?
,
Apr 5 2018
Re #8: The failure in bug 823357 was the reason for the disable.
,
Apr 9 2018
re: #c7 Sure, although the line in the sheriffs config just blanket sets alerting on all blink_perf summary metrics. Maybe we should be getting all of those switched to per-page?
,
Apr 9 2018
Per-page alerting works great for us. We don't need alerting on the sum of everything blink_perf.owp_storage
,
Apr 13 2018
Checking in, so it's a bit cumbersome to switch JUST blink_perf.owp_storage to per-page alerting, since that means I'd have to enumerate all the other blink_perf tests. I can't specify blink_perf.owp_storage/*/* blink_perf.*(except owp_storage)/* Ideally we'd just switch them all at once.
,
Oct 4
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 25 2018