Issue metadata
Sign in to add a comment
|
0.4%-0.5% regression in sizes at 545258:545259 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 25 2018
Assigning to ellyjones@chromium.org because this is the only CL in range: polychrome: flip the flag This change causes all Mac targets to build with mac_views_browser set to true. See comment 4 on the linked bug for details about why. Bug: 802257 Change-Id: Ic4fb9b4282d03d02c16b0f2e29bff78ba2f38e04 Reviewed-on: https://chromium-review.googlesource.com/969078 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#545258}
,
Mar 26 2018
This order of performance regression was expected as part of the polychrome launch on Mac; it should disappear again over the next few weeks (and then settle at a level lower than the old level) as we begin removing now-obsolete Cocoa code. We'll aim to have M67 be at worst the same size it was before by branch point.
,
Mar 26 2018
Thanks! Removing Performance-Sheriff label so that we don't ping on this, since it's got a target milestone.
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/998183644512af6ef1134909b02e97213aee4d7d commit 998183644512af6ef1134909b02e97213aee4d7d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 29 21:39:13 2018 macviews: remove content setting and cookie nibs These nibs aren't used in polychrome builds, since they always use secondary Views UI instead of Cocoa. Bug: 825610 Change-Id: I745b64938254d1cef9a41045888cc1933e7c11d8 Reviewed-on: https://chromium-review.googlesource.com/986477 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546963} [modify] https://crrev.com/998183644512af6ef1134909b02e97213aee4d7d/chrome/app/nibs/BUILD.gn [modify] https://crrev.com/998183644512af6ef1134909b02e97213aee4d7d/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/998183644512af6ef1134909b02e97213aee4d7d/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm [modify] https://crrev.com/998183644512af6ef1134909b02e97213aee4d7d/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm [modify] https://crrev.com/998183644512af6ef1134909b02e97213aee4d7d/chrome/test/BUILD.gn
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a38e76a9fb1191d1958bddf7864a41f1b9de00c2 commit a38e76a9fb1191d1958bddf7864a41f1b9de00c2 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Apr 03 16:31:26 2018 macviews: compile out bookmark bubble and editor Bug: 825610 Change-Id: I23daefcdbc318009d083a65f611a2b821c77b2c4 Reviewed-on: https://chromium-review.googlesource.com/992653 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547730} [modify] https://crrev.com/a38e76a9fb1191d1958bddf7864a41f1b9de00c2/chrome/app/nibs/BUILD.gn [modify] https://crrev.com/a38e76a9fb1191d1958bddf7864a41f1b9de00c2/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/a38e76a9fb1191d1958bddf7864a41f1b9de00c2/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/a38e76a9fb1191d1958bddf7864a41f1b9de00c2/chrome/test/BUILD.gn
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cda28cb569ee6d09c605e38cb3b58ced0622644 commit 5cda28cb569ee6d09c605e38cb3b58ced0622644 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Apr 06 16:00:00 2018 macviews: exile some nibs, remove some plumbing This change removes the HTTP auth nib (already unused in these builds) and all the extension bubble nibs, as well as all the plumbing leading to them. After this change, mac_views_browser builds always use Views versions of these dialogs and !mac_views_browser builds always use Cocoa versions. TBR=rdevlin.cronin@chromium.org Bug: 825610 Change-Id: I93fd0098826a65b6de453864bfa1243bbfab5ee0 Reviewed-on: https://chromium-review.googlesource.com/997992 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#548791} [modify] https://crrev.com/5cda28cb569ee6d09c605e38cb3b58ced0622644/chrome/app/nibs/BUILD.gn [modify] https://crrev.com/5cda28cb569ee6d09c605e38cb3b58ced0622644/chrome/browser/extensions/extension_install_prompt.h [modify] https://crrev.com/5cda28cb569ee6d09c605e38cb3b58ced0622644/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/5cda28cb569ee6d09c605e38cb3b58ced0622644/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm [modify] https://crrev.com/5cda28cb569ee6d09c605e38cb3b58ced0622644/chrome/browser/ui/views/browser_dialogs_views.cc [modify] https://crrev.com/5cda28cb569ee6d09c605e38cb3b58ced0622644/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc [modify] https://crrev.com/5cda28cb569ee6d09c605e38cb3b58ced0622644/chrome/test/BUILD.gn
,
Sep 17
I'm marking this WontFix - we are still reducing the binary size, but this kind of regression is already well within our acceptable range for shipping MacViews. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 25 2018