Issue metadata
Sign in to add a comment
|
2.9% regression in thread_times.simple_mobile_sites at 544866:544972 |
||||||||||||||||||||
Issue descriptionNote there seem to be significant improvements in this range. If a culprit is identified, the improvements may well outweigh the regressions. See https://chromeperf.appspot.com/group_report?sid=212dd4969ce83ed26b60565d98c75fe4232123578a1bb1e67d10dd8d7c3c05d4
,
Mar 25 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12eac443440000
,
Mar 25 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12eac443440000 Android: Consolidate scroll status update in GestureListenerManager by jinsukkim@chromium.org https://chromium.googlesource.com/chromium/src/+/3b0346f62fabc05705488b163540cd09784b7e01 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 25 2018
Test: ChromiumPerf/android-nexus7v2/thread_times.simple_mobile_sites/thread_renderer_main_cpu_time_per_frame/http___www.nyc.gov Value: 0.0 The improvement says the cpu time per frame is zero, which may not be a real improvement but just a glitch. With that glitch period aside there's no actual difference in the measurement before and after the pinpointed CL. I'd say this alert is false-negative.
,
Mar 26 2018
jinsukkim: I'm not 100% positive I understand comment 4, so I'll add some annotated screenshots: I think you're saying there is a glitch in the graph (dashboard.png), but this bug is about the jump after the glitch (dashboard-zoomed.png), which was reproduced on a second bisect (pinpoint.png). So I think there is a real regression to look into here. Can you please take a look?
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0df7bcac1a864f3e62c6267807ac60ad37b35e25 commit 0df7bcac1a864f3e62c6267807ac60ad37b35e25 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Wed Mar 28 22:48:50 2018 Android: Fix error in action mode on scroll Fixes a mistake in the refactoring https://crrrev.com/c/965863. This caused the reported UI error, and likely to have caused other regressions as it affected scroll. Bug: 825593 , 825597 , 825604 , 825796 ,826247 Change-Id: I606c2e94b43f3b5b40fe5a02c5b6aaf3db21dd70 Reviewed-on: https://chromium-review.googlesource.com/981472 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#546637} [modify] https://crrev.com/0df7bcac1a864f3e62c6267807ac60ad37b35e25/content/public/android/java/src/org/chromium/content/browser/GestureListenerManagerImpl.java
,
Mar 29 2018
A fix landed at 546637. Will monitor the performance graph and close the bug if that addresses the performance regression.
,
Apr 1 2018
Issue 825602 has been merged into this issue.
,
Apr 1 2018
,
Apr 1 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12bdd2ef440000
,
Apr 2 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/12bdd2ef440000
,
Apr 10 2018
The CL landed at 546637 http://test-results.appspot.com/revision_range?start=546604&end=546722&n=1000 The graph went down to the previous level after CL landed. I cannot say 100% for sure if the CL really did make the difference since the pinpoint job doesn't reproduce the difference. But it addressed the other regressions so it is likely to be the cause for this as well. Pinpoint job may have failed to detect the difference because regression is small, and there's some fluctuations to make it hard to see the difference it made. Marking as fixed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 25 2018