Issue metadata
Sign in to add a comment
|
1.5%-6.5% regression in thread_times.tough_compositor_cases at 544728:544908 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 25 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1697413d440000
,
Mar 25 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1697413d440000 Add Windows 10 Custom Titlebar feature flag and enable it by default. by bsep@chromium.org https://chromium.googlesource.com/chromium/src/+/979c3c4d8355e456339c648db65c8201991b43af Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 26 2018
Split the android regressions into bug 825796 since the culprit CL here looks to be Windows-only.
,
Mar 27 2018
CC vmiura@ as the test owner. I don't know how to investigate the "tasks_per_frame_total_all" metric, which is what regressed, so I need help. The patch in question is enabling a feature that moves some of the top chrome renderering into Views code, instead of letting Windows handle it. It does not affect page renderering directly. It might slightly increase global renderering load, but I don't have enough context to understand the magnitude of the impact.
,
Apr 4 2018
,
Apr 19 2018
I ran this perf test locally and the accused CL doesn't seem to be involved. I added instrumentation for the OnPaint method for the titlebar and it's called the same number of times with and without this CL (4 or 5, so a minimal number). Also, running the test locally with and without the CL, there doesn't seem to be a correlation between increased numbers and running with the CL. Finally, this history makes it look like the delta is well within the noise, and the regression whereby this number was at 0 may have confused things. https://chromeperf.appspot.com/group_report?bug_id=825596
,
Apr 19 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/148e67fec40000
,
Apr 20 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/148e67fec40000 Add Windows 10 Custom Titlebar feature flag and enable it by default. by bsep@chromium.org https://chromium.googlesource.com/chromium/src/+/979c3c4d8355e456339c648db65c8201991b43af Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 20 2018
Assigning to test owner vmiura to help clarify: 1) What the metric is measuring and how it can be debugged 2) Whether this regression is significant enough to dig into more deeply. Looking at the graph: https://chromeperf.appspot.com/group_report?bug_id=825596 We do see a clear regression from just under 2000 tasks per second to 2100 which is clearly reproduced at the CL in question in both bisects (#3 and #9). But it looks like more information on the metric and severity would be needed for the CL author to address this.
,
Apr 20 2018
,
Apr 20 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14d117eec40000
,
Apr 21 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14d117eec40000 Revert "Add Windows 10 Custom Titlebar feature flag and enable it by default." by davidbienvenu@chromium.org https://chromium-review.googlesource.com/c/chromium/src/+/1022978/1 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Apr 23 2018
I did a try job with the original CL reverted and the averages for tasks_per_frame_total_all were very close (1732 vs 1731). The main difference was the max (2060 w/ the original change, 1950 w/o it).
,
May 2 2018
,
Dec 10
Closing, obsolete. thread_times benchmarks and metrics have migrated to rendering.mobile and TBMv2 versions. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 25 2018