New issue
Advanced search Search tips

Issue 825594 link

Starred by 2 users
Status: Fixed
Owner:
bsalo...@google.com
Closed: Apr 2018
Cc:
robertph...@google.com
sullivan@chromium.org
bsalo...@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.8%-19.7% regression in rasterize_and_record_micro.top_25 at 544705:544802

Project Member Reported by sullivan@chromium.org, Mar 25 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 25 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=825594

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f5db295c84ee3cbe4a4d2999b2996d2c6b11b1973d5710228c209800b4cbf060


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 26 2018

Cc: bsalo...@google.com robertph...@google.com
Owner: bsalo...@google.com
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14981f3d440000

Use new Skia GPU read/write pixel code paths by bsalomon@google.com
https://chromium.googlesource.com/chromium/src/+/f17c70fe460c6841913bb61f68bb8e89f16e663f

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56044665258df106f9c5dd353ed9662cab28aefd

commit 56044665258df106f9c5dd353ed9662cab28aefd
Author: Robert Phillips <robertphillips@google.com>
Date: Mon Mar 26 14:49:24 2018

Revert "Use new Skia GPU read/write pixel code paths"

This reverts commit f17c70fe460c6841913bb61f68bb8e89f16e663f.

Reason for revert: 

It looks like this change:

slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne ( crbug.com/825594 )

slowed down getImageData and putImageData for the HTML5 Canvas across the board ( crbug.com/825585 )

Bug:  825594 
Bug:  825585 

Original change's description:
> Use new Skia GPU read/write pixel code paths
> 
> Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992
> Reviewed-on: https://chromium-review.googlesource.com/973267
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544777}

TBR=bsalomon@chromium.org,robertphillips@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565
Reviewed-on: https://chromium-review.googlesource.com/980292
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#545787}
[modify] https://crrev.com/56044665258df106f9c5dd353ed9662cab28aefd/skia/config/SkUserConfig.h

Comment 5 by bsalo...@google.com, Apr 2 2018

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/613f554306490882f0f3050f5d068f23dc050b08

commit 613f554306490882f0f3050f5d068f23dc050b08
Author: Brian Salomon <bsalomon@chromium.org>
Date: Mon Apr 16 17:34:20 2018

Reland "Use new Skia GPU read/write pixel code paths"

This reverts commit 56044665258df106f9c5dd353ed9662cab28aefd.

Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData.

Original change's description:
> Revert "Use new Skia GPU read/write pixel code paths"
> 
> This reverts commit f17c70fe460c6841913bb61f68bb8e89f16e663f.
> 
> Reason for revert: 
> 
> It looks like this change:
> 
> slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne ( crbug.com/825594 )
> 
> slowed down getImageData and putImageData for the HTML5 Canvas across the board ( crbug.com/825585 )
> 
> Bug:  825594 
> Bug:  825585 
> 
> Original change's description:
> > Use new Skia GPU read/write pixel code paths
> > 
> > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992
> > Reviewed-on: https://chromium-review.googlesource.com/973267
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#544777}
> 
> TBR=bsalomon@chromium.org,robertphillips@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565
> Reviewed-on: https://chromium-review.googlesource.com/980292
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Cr-Commit-Position: refs/heads/master@{#545787}

TBR=bsalomon@chromium.org,robertphillips@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  825594 ,  825585 
Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093
Reviewed-on: https://chromium-review.googlesource.com/1014140
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551022}
[modify] https://crrev.com/613f554306490882f0f3050f5d068f23dc050b08/skia/config/SkUserConfig.h
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a7e0fba9c29ed76d1cab3737179b3930c684bf

commit 75a7e0fba9c29ed76d1cab3737179b3930c684bf
Author: Justin Novosad <junov@chromium.org>
Date: Mon Apr 16 20:16:50 2018

Revert "Reland "Use new Skia GPU read/write pixel code paths""

This reverts commit 613f554306490882f0f3050f5d068f23dc050b08.

Reason for revert: 
Breaks fast/webgl/canvas-toDataURL-premul-overflow.html on
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/43191
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17758
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/11632
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/45887
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/31889
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20(retina)/328

Original change's description:
> Reland "Use new Skia GPU read/write pixel code paths"
> 
> This reverts commit 56044665258df106f9c5dd353ed9662cab28aefd.
> 
> Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData.
> 
> Original change's description:
> > Revert "Use new Skia GPU read/write pixel code paths"
> > 
> > This reverts commit f17c70fe460c6841913bb61f68bb8e89f16e663f.
> > 
> > Reason for revert: 
> > 
> > It looks like this change:
> > 
> > slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne ( crbug.com/825594 )
> > 
> > slowed down getImageData and putImageData for the HTML5 Canvas across the board ( crbug.com/825585 )
> > 
> > Bug:  825594 
> > Bug:  825585 
> > 
> > Original change's description:
> > > Use new Skia GPU read/write pixel code paths
> > > 
> > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992
> > > Reviewed-on: https://chromium-review.googlesource.com/973267
> > > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > > Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#544777}
> > 
> > TBR=bsalomon@chromium.org,robertphillips@google.com
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565
> > Reviewed-on: https://chromium-review.googlesource.com/980292
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Commit-Queue: Robert Phillips <robertphillips@google.com>
> > Cr-Commit-Position: refs/heads/master@{#545787}
> 
> TBR=bsalomon@chromium.org,robertphillips@google.com
> 










> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  825594 ,  825585 
> Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093
> Reviewed-on: https://chromium-review.googlesource.com/1014140
> Reviewed-by: Brian Salomon <bsalomon@chromium.org>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551022}

TBR=bsalomon@chromium.org,robertphillips@google.com

Change-Id: I0dd6db48f1c55d869de88e2fbca963c2c0cde0ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  825594 ,  825585 
Reviewed-on: https://chromium-review.googlesource.com/1012796
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551093}
[modify] https://crrev.com/75a7e0fba9c29ed76d1cab3737179b3930c684bf/skia/config/SkUserConfig.h
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/613f554306490882f0f3050f5d068f23dc050b08

commit 613f554306490882f0f3050f5d068f23dc050b08
Author: Brian Salomon <bsalomon@chromium.org>
Date: Mon Apr 16 17:34:20 2018

Reland "Use new Skia GPU read/write pixel code paths"

This reverts commit 56044665258df106f9c5dd353ed9662cab28aefd.

Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData.

Original change's description:
> Revert "Use new Skia GPU read/write pixel code paths"
> 
> This reverts commit f17c70fe460c6841913bb61f68bb8e89f16e663f.
> 
> Reason for revert: 
> 
> It looks like this change:
> 
> slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne ( crbug.com/825594 )
> 
> slowed down getImageData and putImageData for the HTML5 Canvas across the board ( crbug.com/825585 )
> 
> Bug:  825594 
> Bug:  825585 
> 
> Original change's description:
> > Use new Skia GPU read/write pixel code paths
> > 
> > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992
> > Reviewed-on: https://chromium-review.googlesource.com/973267
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#544777}
> 
> TBR=bsalomon@chromium.org,robertphillips@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565
> Reviewed-on: https://chromium-review.googlesource.com/980292
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Robert Phillips <robertphillips@google.com>
> Cr-Commit-Position: refs/heads/master@{#545787}

TBR=bsalomon@chromium.org,robertphillips@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  825594 ,  825585 
Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093
Reviewed-on: https://chromium-review.googlesource.com/1014140
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551022}
[modify] https://crrev.com/613f554306490882f0f3050f5d068f23dc050b08/skia/config/SkUserConfig.h
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a7e0fba9c29ed76d1cab3737179b3930c684bf

commit 75a7e0fba9c29ed76d1cab3737179b3930c684bf
Author: Justin Novosad <junov@chromium.org>
Date: Mon Apr 16 20:16:50 2018

Revert "Reland "Use new Skia GPU read/write pixel code paths""

This reverts commit 613f554306490882f0f3050f5d068f23dc050b08.

Reason for revert: 
Breaks fast/webgl/canvas-toDataURL-premul-overflow.html on
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/43191
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17758
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/11632
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/45887
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/31889
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20(retina)/328

Original change's description:
> Reland "Use new Skia GPU read/write pixel code paths"
> 
> This reverts commit 56044665258df106f9c5dd353ed9662cab28aefd.
> 
> Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData.
> 
> Original change's description:
> > Revert "Use new Skia GPU read/write pixel code paths"
> > 
> > This reverts commit f17c70fe460c6841913bb61f68bb8e89f16e663f.
> > 
> > Reason for revert: 
> > 
> > It looks like this change:
> > 
> > slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne ( crbug.com/825594 )
> > 
> > slowed down getImageData and putImageData for the HTML5 Canvas across the board ( crbug.com/825585 )
> > 
> > Bug:  825594 
> > Bug:  825585 
> > 
> > Original change's description:
> > > Use new Skia GPU read/write pixel code paths
> > > 
> > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992
> > > Reviewed-on: https://chromium-review.googlesource.com/973267
> > > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > > Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#544777}
> > 
> > TBR=bsalomon@chromium.org,robertphillips@google.com
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565
> > Reviewed-on: https://chromium-review.googlesource.com/980292
> > Reviewed-by: Robert Phillips <robertphillips@google.com>
> > Commit-Queue: Robert Phillips <robertphillips@google.com>
> > Cr-Commit-Position: refs/heads/master@{#545787}
> 
> TBR=bsalomon@chromium.org,robertphillips@google.com
> 










> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  825594 ,  825585 
> Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093
> Reviewed-on: https://chromium-review.googlesource.com/1014140
> Reviewed-by: Brian Salomon <bsalomon@chromium.org>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
> Commit-Queue: Brian Salomon <bsalomon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551022}

TBR=bsalomon@chromium.org,robertphillips@google.com

Change-Id: I0dd6db48f1c55d869de88e2fbca963c2c0cde0ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  825594 ,  825585 
Reviewed-on: https://chromium-review.googlesource.com/1012796
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551093}
[modify] https://crrev.com/75a7e0fba9c29ed76d1cab3737179b3930c684bf/skia/config/SkUserConfig.h
►

Sign in to add a comment