New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825593 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.7%-4.8% regression in smoothness.sync_scroll.key_mobile_sites_smooth at 544735:544878

Project Member Reported by sullivan@chromium.org, Mar 25 2018

Issue description

This may be within the noise.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 25 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=825593

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=cbd54b18a4871c9e7048e17a5e5fa33982a50826591e3785261814c93d55125d


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 25 2018

Cc: nyquist@chromium.org jinsuk...@chromium.org boliu@chromium.org
Owner: jinsuk...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16bf7b5d440000

Android: Consolidate scroll status update in GestureListenerManager by jinsukkim@chromium.org
https://chromium.googlesource.com/chromium/src/+/3b0346f62fabc05705488b163540cd09784b7e01

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
I'd agree that this may well be within noise. Overall average latency fluctuates between 16.8~17.8ms.

One thing that catches attention is that lately there was an improvement that lowered it down below 17ms for some time https://bugs.chromium.org/p/chromium/issues/detail?id=825672, and my CL effectively reverted it back to the state before the improvement. I started bisect for the improvement to see if there's any correlation between the two.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Mar 26 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1483870b440000

Android: Fix scroll regression by jinsukkim@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/981472/1

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1031f5a3440000
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/158f49e3440000
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/10680eed440000

Android: Fix scroll regression by jinsukkim@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/981472/2

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12fd87eb440000
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1030ee23440000
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1057413d440000

Android: Fix scroll regression by jinsukkim@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/981472/4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 20 by 42576172...@developer.gserviceaccount.com, Mar 27 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/138f49e3440000

Android: Fix scroll regression by jinsukkim@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/981472/4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df7bcac1a864f3e62c6267807ac60ad37b35e25

commit 0df7bcac1a864f3e62c6267807ac60ad37b35e25
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed Mar 28 22:48:50 2018

Android: Fix error in action mode on scroll

Fixes a mistake in the refactoring https://crrrev.com/c/965863.
This caused the reported UI error, and likely to have caused
other regressions as it affected scroll.

Bug:  825593 , 825597 , 825604 , 825796 ,826247

Change-Id: I606c2e94b43f3b5b40fe5a02c5b6aaf3db21dd70
Reviewed-on: https://chromium-review.googlesource.com/981472
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546637}
[modify] https://crrev.com/0df7bcac1a864f3e62c6267807ac60ad37b35e25/content/public/android/java/src/org/chromium/content/browser/GestureListenerManagerImpl.java

Status: Fixed (was: Assigned)

Sign in to add a comment