New issue
Advanced search Search tips

Issue 825571 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: type == EventTypeNames::tonechange in RTCDTMFToneChangeEvent.cpp

Project Member Reported by ClusterFuzz, Mar 25 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5152867695198208

Fuzzer: v8_builtins_generator
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  type == EventTypeNames::tonechange in RTCDTMFToneChangeEvent.cpp
  blink::RTCDTMFToneChangeEvent::Create
  blink::RTCDTMFToneChangeEventV8Internal::constructor
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=538781:538782

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5152867695198208

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 25 2018

Components: Blink>WebRTC
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 25 2018

Labels: Test-Predator-Auto-Owner
Owner: hta@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/f1bbe6226e8009c584a019ed943e1c8535197068 (Add the "dtmf" attribute on RTCRTPSender).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by hta@chromium.org, Apr 3 2018

Fixed in this CL (which was marked with wrong bug number):

Don't enforce name rule for RTCDTMFToneChangeEvent

Since the constructor of RTCDTMFToneChangeEvent is exposed,
creating such events with other names than "tonechange" is possible.
No reason to discriminate against such.

Also adds tests for constructor.

Bug:  chromium:822799 
Change-Id: I4b36f3094acee200dd4200c4d24f6b46e10a06e6
Reviewed-on: https://chromium-review.googlesource.com/992038
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547742}

Comment 4 by hta@chromium.org, Apr 3 2018

Status: Fixed (was: Assigned)

Sign in to add a comment