Steps to reproduce: https://jsfiddle.net/ericwilligers/L8jve8bp/ Set border-image inline style, read border-image inline style. Spec: https://drafts.csswg.org/css-backgrounds/#border-image Actual results: Reading border-image inline style gives empty string. border-image computed style has the supplied value. Reading longhands inline and computed styles gives the values from border-image. Expected results: Reading border-image inline style should give the supplied value. WebKit has same bug https://bugs.webkit.org/show_bug.cgi?id=183993 . Edge has correct behavior.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7076b259f5df19b8979d234da9ac2939f17cdd42 commit 7076b259f5df19b8979d234da9ac2939f17cdd42 Author: Rob Buis <rob.buis@samsung.com> Date: Tue Apr 17 13:34:44 2018 Serialize border-image inline style Serialize border-image inline style by implementing the serializing logic for it in StylePropertySerializer::GetPropertyValue. Bug: 825568 Change-Id: Ibaa18dadc41bb7aa735ab5e1384615b5d2270a2c Reviewed-on: https://chromium-review.googlesource.com/990721 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#551310} [modify] https://crrev.com/7076b259f5df19b8979d234da9ac2939f17cdd42/third_party/WebKit/LayoutTests/external/wpt/css/css-backgrounds/parsing/border-image-valid-expected.txt [add] https://crrev.com/7076b259f5df19b8979d234da9ac2939f17cdd42/third_party/WebKit/LayoutTests/fast/css/border-image-shorthand-initialize-longhands.html [modify] https://crrev.com/7076b259f5df19b8979d234da9ac2939f17cdd42/third_party/WebKit/LayoutTests/fast/css/parse-border-image-repeat-null-crash-expected.txt [modify] https://crrev.com/7076b259f5df19b8979d234da9ac2939f17cdd42/third_party/blink/renderer/core/css/style_property_serializer.cc [modify] https://crrev.com/7076b259f5df19b8979d234da9ac2939f17cdd42/third_party/blink/renderer/core/css/style_property_serializer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63f167132cdce2f50340e377d1f556e537aab52d commit 63f167132cdce2f50340e377d1f556e537aab52d Author: Bruce Dawson <brucedawson@chromium.org> Date: Wed Apr 18 01:32:38 2018 Use || instead of | for logical expressions In its last action before being turned off the VC++ compiler said: warning.cpp(2): warning C4554: '|': check operator precedence for possible error; use parentheses to clarify precedence The code is not wrong, but it is confusing. By default we should use logical operators for logical expressions, and bitwise operators for bitwise expressions. See also this request for a similar warning in clang: https://bugs.llvm.org/show_bug.cgi?id=37155 Bug: 825568 Change-Id: I339744f004258137d72b23bfe047901dd40be4ad Reviewed-on: https://chromium-review.googlesource.com/1015780 Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551550} [modify] https://crrev.com/63f167132cdce2f50340e377d1f556e537aab52d/third_party/blink/renderer/core/css/style_property_serializer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa1a40ae240b768f36d3a98ae028f4a35acc01e1 commit fa1a40ae240b768f36d3a98ae028f4a35acc01e1 Author: Rob Buis <rob.buis@samsung.com> Date: Fri Apr 20 12:14:00 2018 Make border-image use real initial values for its longhands Make border-image use real initial values for its longhands, instead of just "initial". Note that this fixes the problems left by r551310. Behavior matches Firefox. Bug: 825568 , 772772 Change-Id: Ic4eda9db5ec370059578ca87e1512fae5b373cbd Reviewed-on: https://chromium-review.googlesource.com/1013806 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#552306} [delete] https://crrev.com/0d41b261e10706d8eed652f198778864401b5ae0/third_party/WebKit/LayoutTests/external/wpt/css/css-backgrounds/parsing/border-image-valid-expected.txt [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/WebKit/LayoutTests/external/wpt/css/css-backgrounds/parsing/border-image-valid.html [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/WebKit/LayoutTests/fast/css/border-image-shorthand-initialize-longhands.html [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/WebKit/LayoutTests/fast/css/border-image-value-grammar-expected.txt [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/WebKit/LayoutTests/fast/css/border-image-value-grammar.html [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-border-image-expected.txt [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/WebKit/LayoutTests/fast/css/parse-border-image-repeat-null-crash-expected.txt [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/CSSProperties.json5 [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/properties/longhands/border_image_outset_custom.cc [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/properties/longhands/border_image_repeat_custom.cc [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/properties/longhands/border_image_slice_custom.cc [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/properties/longhands/border_image_source_custom.cc [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/properties/longhands/border_image_width_custom.cc [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/properties/shorthands/border_image_custom.cc [modify] https://crrev.com/fa1a40ae240b768f36d3a98ae028f4a35acc01e1/third_party/blink/renderer/core/css/style_property_serializer.cc
Comment 1 by e...@chromium.org
, Mar 30 2018Status: Available (was: Untriaged)