New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825554 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Removing an extension from PWA causes a crash

Project Member Reported by hwi@chromium.org, Mar 25 2018

Issue description

Chrome Version: 67.0.3376.0 Canary
OS: Chrome

What steps will reproduce the problem?
(1) Open an PWA
(2) Open 3-dot menu
(3) Right click on an extention
(4) Select 'Remove from Chrome'

What is the expected result?
Remove dialog

What happens instead?
Chrome crashes


 

Comment 1 by mgiuca@chromium.org, Mar 26 2018

Cc: mgiuca@chromium.org
Labels: -Pri-3 Pri-1
Owner: calamity@chromium.org
Status: Assigned (was: Untriaged)
Confirmed. Chris, can you take a look?
Cc: calamity@chromium.org
Owner: alancutter@chromium.org
Known issue, already being investigated by Alan.

Comment 3 by mgiuca@chromium.org, Mar 26 2018

Ah, that must be why Alan told me about it :)

Comment 4 by mgiuca@chromium.org, Mar 26 2018

Labels: M-67

Comment 5 by mgiuca@chromium.org, Mar 27 2018

Labels: ReleaseBlock-Beta
WIP fix, needs test: https://chromium-review.googlesource.com/c/chromium/src/+/981839

I think we need to plumb our BrowserViewButtonProvider through the code base more to avoid crashes like these. The existing code has been written with the main UI toolbar in mind and assumes its existence e.g. browser_view->toolbar().
Created issue 826596 for investigating other potential crashes of this nature.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffa2f3373e77437f51b3923a3d9de9e2ca35135b

commit ffa2f3373e77437f51b3923a3d9de9e2ca35135b
Author: Alan Cutter <alancutter@chromium.org>
Date: Thu Mar 29 06:06:08 2018

Fix crash when uninstalling extension from PWA window

This CL fixes a null pointer crash when uninstalling an extension from
the app menu of a PWA window. The existing code expected the main UI
toolbar to be present.

Bug:  825554 
Change-Id: I89353dd246168393747cca02f02444859b4457c6
Reviewed-on: https://chromium-review.googlesource.com/981839
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546743}
[modify] https://crrev.com/ffa2f3373e77437f51b3923a3d9de9e2ca35135b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc
[modify] https://crrev.com/ffa2f3373e77437f51b3923a3d9de9e2ca35135b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc
[modify] https://crrev.com/ffa2f3373e77437f51b3923a3d9de9e2ca35135b/testing/buildbot/filters/mash.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment