New issue
Advanced search Search tips

Issue 825540 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug
Flaky-Test: ContentVerifierTest.DotSlashPaths

Blocking:
issue 796395



Sign in to add a comment

ContentVerifierTest.DotSlashPaths is Flaky

Project Member Reported by Findit, Mar 25 2018

Issue description

Comment 1 by battre@chromium.org, Mar 26 2018

Owner: lazyboy@chromium.org
Status: Assigned (was: Available)

Comment 2 by battre@chromium.org, Mar 26 2018

Received fatal exception EXCEPTION_BREAKPOINT
Backtrace:
	base::BindRepeating<void (__thiscall content::GpuBrowserCompositorOutputSurface::*)(gpu::SwapBuffersCompleteParams const &),base::internal::UnretainedWrapper<content::GpuBrowserCompositorOutputSurface> > [0x5EF4658D+173]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall extensions::TestContentVerifyJobObserver::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::FilePath const &,enum extensions::ContentVerifyJob::FailureReas [0x0BAD83F3+163]
	base::internal::Invoker<base::internal::BindState<void (__thiscall extensions::TestContentVerifyJobObserver::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::FilePath const &,enum extensions::ContentVerifyJob::FailureR [0x0BAD82C4+196]
	base::internal::Invoker<base::internal::BindState<void (__thiscall extensions::TestContentVerifyJobObserver::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::FilePath const &,enum extensions::ContentVerifyJob::FailureR [0x0BAD8074+84]
	base::OnceCallback<void __cdecl(void)>::Run [0x6F383CD0+80]
	base::debug::TaskAnnotator::RunTask [0x6F3F8DB3+979]
	base::internal::IncomingTaskQueue::RunTask [0x6F49EEA8+232]
	base::MessageLoop::RunTask [0x6F4AA004+884]
	base::MessageLoop::DeferOrRunPendingTask [0x6F4AAA79+73]
	base::MessageLoop::DoWork [0x6F4AAD3A+442]
	base::MessagePumpForUI::DoRunLoop [0x6F4B72DE+62]
	base::MessagePumpWin::Run [0x6F4B6589+185]
	base::MessageLoop::Run [0x6F4A9788+504]
	base::RunLoop::Run [0x6F59B3D8+488]
	content::RunThisRunLoop [0x05C59AA7+55]
	content::RunAllPendingInMessageLoop [0x05C59D6A+506]
	InProcessBrowserTest::PostRunTestOnMainThread [0x05896BFB+43]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x05CAE864+1492]
	??$Invoke@PAVBrowserTestBase@content@@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x05CB0D2C+28]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x05CB0C4F+79]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x05CB0BD5+85]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x05CB0A8F+63]
	base::RepeatingCallback<void __cdecl(void)>::Run [0x008E9362+50]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x064375D1+7041]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x0643594E+398]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x5D5AD376+342]
	??$Invoke@PAVBrowserMainLoop@content@@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x5D5BABFC+28]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x5D5BAB1F+79]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x5D5BAA95+85]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x5D5BA8FF+63]
	base::RepeatingCallback<int __cdecl(void)>::Run [0x5EB49762+50]
	content::StartupTaskRunner::RunAllTasksNow [0x5EB494A9+137]
	content::BrowserMainLoop::CreateStartupTasks [0x5D5AA915+1493]
	content::BrowserMainRunnerImpl::Initialize [0x5D5C0DAD+1901]
	content::BrowserMain [0x5D5A317D+173]
	content::RunNamedProcessTypeMain [0x605B79B0+208]
	content::ContentMainRunnerImpl::Run [0x605B86B9+569]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x605B4061+33]
	service_manager::Main [0x59906063+1363]
	content::ContentMain [0x605B781C+92]
	content::BrowserTestBase::SetUp [0x05CADBFB+2875]
	InProcessBrowserTest::SetUp [0x05894927+1367]
	ExtensionBrowserTest::SetUp [0x0234272F+111]
	extensions::ContentVerifierTest::SetUp [0x0229C842+98]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x02E7DE2B+107]
	testing::Test::Run [0x02E7DCDF+111]
	testing::TestInfo::Run [0x02E7E98B+251]
	testing::TestCase::Run [0x02E7F65D+269]
	testing::internal::UnitTestImpl::RunAllTests [0x02E89F3B+715]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x02E89C20+112]
	testing::UnitTest::Run [0x02E899E9+297]
	RUN_ALL_TESTS [0x05916F0F+15]
	base::TestSuite::Run [0x059162DE+142]
	ChromeTestSuiteRunner::RunTestSuite [0x0BBE3060+80]
	ChromeTestLauncherDelegate::RunTestSuite [0x0BBE3160+48]
	content::LaunchTests [0x05C60551+785]
	LaunchChromeTests [0x0BBE3952+386]
	main [0x0BBE2F7E+222]
	invoke_main [0x0CB5656E+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:78)
	__scrt_common_main_seh [0x0CB56410+336] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	__scrt_common_main [0x0CB562AD+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326)
	mainCRTStartup [0x0CB565E8+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)

doing a speculative revert of https://chromium-review.googlesource.com/q/I7eb6bf93daba908258ae604a8cd45ea643b4e00d

Comment 3 by battre@chromium.org, Mar 26 2018

Blocking: 796395
Labels: -Pri-3 Pri-0
Unfortunately the revert at https://chromium-review.googlesource.com/c/chromium/src/+/979797 failed, so I had to disable the test.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1091b415d1a4965ce112aa900e04d38252f9bf8

commit b1091b415d1a4965ce112aa900e04d38252f9bf8
Author: Dominic Battre <battre@chromium.org>
Date: Mon Mar 26 13:53:07 2018

Disable flaky ContentVerifierTest.DotSlashPaths

See  crbug.com/825540  for details.

TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org
notry=true

Bug:  825540 ,796395
Change-Id: I70e628fd0b5f7fc98358be225ef0fd856a155359
Reviewed-on: https://chromium-review.googlesource.com/980256
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545778}
[modify] https://crrev.com/b1091b415d1a4965ce112aa900e04d38252f9bf8/chrome/browser/extensions/content_verifier_browsertest.cc

Comment 5 by rogerm@chromium.org, Mar 26 2018

Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Mar 27 2018

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "ContentVerifierTest.DotSlashPaths". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLAsSBUZsYWtlIiFDb250ZW50VmVyaWZpZXJUZXN0LkRvdFNsYXNoUGF0aHMM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Last of the recent flakes happened before test was disabled.

Comment 9 by battre@chromium.org, Mar 27 2018

This is spreading to other tests as well:

[ RUN      ] WebstoreInlineInstallerTest.ReinstallDisabledExtension
[6760:4284:0327/003741.538:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[6760:1560:0327/003741.538:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=WebstoreInlineInstallerTest.ReinstallDisabledExtension --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6964_30161\results6964_4354\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\iogastg6\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6964_30161\d6964_9647" --disable-offline-auto-reload --apps-gallery-url=http://cws.com:59585/extensions/api_test/webstore_inline_install --apps-gallery-update-url=http://cws.com:59585/extensions/api_test/webstore_inline_install/extension.crx --js-flags=--expose-gc --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[6760:1560:0327/003741.686:INFO:CONSOLE(8)] "Page loaded", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (8)
[6760:1560:0327/003741.691:INFO:CONSOLE(11)] "In runTest", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (11)
[6760:6176:0327/003741.700:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
[6760:1560:0327/003742.380:INFO:CONSOLE(22)] "Ran test, sending response", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (22)
[6760:1560:0327/003742.380:INFO:CONSOLE(24)] "Test complete", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (24)
[6760:1560:0327/003742.395:INFO:CONSOLE(8)] "Page loaded", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (8)
[6760:1560:0327/003742.395:INFO:CONSOLE(11)] "In runTest", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (11)
[6760:1560:0327/003742.560:INFO:CONSOLE(22)] "Ran test, sending response", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (22)
[6760:1560:0327/003742.563:INFO:CONSOLE(24)] "Test complete", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (24)
[6760:1560:0327/003742.573:INFO:CONSOLE(8)] "Page loaded", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (8)
[6760:1560:0327/003742.575:INFO:CONSOLE(11)] "In runTest", source: http://app.com:59585/extensions/api_test/webstore_inline_install/install.html (11)
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	std::basic_string<char,std::char_traits<char>,pool_allocator<char> >::compare [0x00B3745B+25]
	std::operator<<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::Version> [0x0214A808+19]
	std::_Tree<std::_Tmap_traits<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,base::Version>,extensions::ContentVerifier::HashHelper::CallbackInfo,std::less<std::pair<std::basic_string<char,std::char_traits<char>,std::allocat [0x0214A8D0+156]
	extensions::ContentVerifier::HashHelper::GetContentHash [0x02149691+251]
	extensions::ContentVerifier::GetContentHash [0x021494BB+331]
	extensions::ContentVerifier::OnExtensionLoadedOnIO [0x02149B49+137]
	base::internal::FunctorTraits<void (__thiscall extensions::ContentVerifier::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::FilePath const &,base::Version const &,std::unique_ptr<extensions::ContentVerifierIOData::Ext [0x0214B39A+68]
	base::internal::Invoker<base::internal::BindState<void (__thiscall extensions::ContentVerifier::*)(std::basic_string<char,std::char_traits<char>,std::allocator<char> > const &,base::FilePath const &,base::Version const &,std::unique_ptr<extensions::Conten [0x0214B344+84]
	base::debug::TaskAnnotator::RunTask [0x02B4709F+159]
	base::internal::IncomingTaskQueue::RunTask [0x02B68523+19]
	base::MessageLoop::RunTask [0x02B03A46+438]
	base::MessageLoop::DeferOrRunPendingTask [0x02B03D83+83]
	base::MessageLoop::DoWork [0x02B03E93+211]
	base::MessagePumpForIO::DoRunLoop [0x02B324ED+285]
	base::MessagePumpWin::Run [0x02B31AEE+110]
	base::MessageLoop::Run [0x02B0379F+31]
	base::RunLoop::Run [0x02AE159E+46]
	base::Thread::Run [0x02B18CEB+11]
	content::BrowserThreadImpl::IOThreadRun [0x01D9B844+44]
	content::BrowserThreadImpl::Run [0x01D9B9AC+252]
	base::Thread::ThreadMain [0x02B18E55+341]
	base::PlatformThread::GetCurrentThreadPriority [0x02AFB6FB+299]
	BaseThreadInitThunk [0x7558337A+18]
	RtlInitializeExceptionChain [0x77A292B2+99]
	RtlInitializeExceptionChain [0x77A29285+54]
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/231c6bd4faa6943e32b4d8303bc6b15061878907

commit 231c6bd4faa6943e32b4d8303bc6b15061878907
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Thu Mar 29 05:31:58 2018

ContentVerifier: Fix a bug around user script's job creation.

Following interesting stuff happens during OnExtensionLoad:
  - ContentVerifier adds ContentVerifierIOData on IO thread through
    PostTask.
  - SharedUserScriptMaster loads user scripts that might end up
    creating ContentVerifyJobs (VerifyContent function) from
    UserScriptLoader::StartLoad.

There's no guarantee that VerifyContent will see the IO data added
by ContentVerifier. This CL ensures that user scripts will always
see IO data (if it was loaded) regardless of the timing: by hopping
to UI thread (essentially by yielding to
ContentVerifier::OnExtensionLoaded to PostTask IO data) and then
going to IO thread to call VerifyContent.

This CL also fixes and enables ContentVerifierTest.DotSlashPaths.
The test used to fail because it loaded content scripts that was
vulnerable to the bug. This CL also adds stricter expectations
to the test through TestContentVerifyJobObserver.

Bug: 826584,  825540 
Change-Id: I95f3bfb934af6e82703113df973363543bfdbaea
Reviewed-on: https://chromium-review.googlesource.com/982938
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546738}
[modify] https://crrev.com/231c6bd4faa6943e32b4d8303bc6b15061878907/chrome/browser/extensions/content_verifier_browsertest.cc
[modify] https://crrev.com/231c6bd4faa6943e32b4d8303bc6b15061878907/extensions/browser/content_verifier.cc
[modify] https://crrev.com/231c6bd4faa6943e32b4d8303bc6b15061878907/extensions/browser/extension_user_script_loader.cc

Status: Fixed (was: Started)

Sign in to add a comment