New issue
Advanced search Search tips

Issue 825535 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Arrow icons in dropdown menus wrong colour when selected

Reported by stevenan...@gmail.com, Mar 24 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

Steps to reproduce the problem:
1. Click on the three vertical dots button ("Customize and control DevTools").
2. Hover over "More tools" in the resulting dropdown menu.

What is the expected behavior?
I expect the arrow icon to change to white to match the text changing to white, and look aesthetically pleasing on the blue background.

What went wrong?
The arrow icon remains grey instead of changing to white.

Did this work before? N/A 

Chrome version: 67.0.3379.0  Channel: n/a
OS Version: OS X 10.12.3
Flash Version: 

I'd like to work on this—I will submit a patch for this.
 
Screen Shot 2018-03-25 at 10.32.18 am.png
81.0 KB View Download

Comment 1 by ajha@chromium.org, Mar 26 2018

Labels: Needs-Triage-M67
Labels: Triaged-ET M-67 Target-67 FoundIn-67 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on 67.0.3379.0 and on latest canary 67.0.3381.0 using Windows 10, Mac 10.12.6 and Ubuntu 14.04. As the issue is seen from M-60(60.0.3112.0). Hence considering this issue as Non-Regression and marking as Untriaged.

Thanks!

Comment 3 by kozy@chromium.org, Mar 30 2018

Owner: l...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by l...@chromium.org, Mar 30 2018

Thanks for the report!  I agree with having white arrows for better contrast, we use white on blue in checkboxes/icons on selected menu-items as well, so this will be consistent.

We'd totally welcome contributed patches!  If you haven't already seen it, there's a contribution guide (bit.ly/devtools-contribution-guide) on how to get started.  It's a bit long, but feel free to ask questions along the way.

Comment 5 by l...@chromium.org, Jun 25 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bff7b347b28cf5205d84abbc1a6d2a69af5e78b

commit 7bff7b347b28cf5205d84abbc1a6d2a69af5e78b
Author: Erik Luo <luoe@chromium.org>
Date: Mon Jun 25 23:05:29 2018

DevTools: force arrows in SoftContextMenu to be white

Screenshot: https://imgur.com/a/cN62iYX

Bug:  825535 
Change-Id: If5ddf68061430539e9a2e69194bb58071bff3bdc
Reviewed-on: https://chromium-review.googlesource.com/1112844
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570218}
[modify] https://crrev.com/7bff7b347b28cf5205d84abbc1a6d2a69af5e78b/third_party/blink/renderer/devtools/front_end/ui/softContextMenu.css

Labels: TE-Verified-69.0.3473.0 TE-Verified-M69
Able to reproduce the issue on chrome reported version 67.0.3379.0
Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #69.0.3473.0 as per the comment#0
Attaching screenshot for reference.
Observed "Arrow icon changed to white to match the text changing to white"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
825535.png
185 KB View Download

Comment 9 by l...@chromium.org, Jun 26 2018

Status: Fixed (was: Started)
While this bug is fixed, there are still many good first bugs.  "Hotlist-Goodfirstbug" is one label to look for.

Sign in to add a comment