New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825484 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Null-dereference READ in blink::MediaControlAnimationEventListener::Detach

Project Member Reported by ClusterFuzz, Mar 24 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6209874179129344

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::MediaControlAnimationEventListener::Detach
  blink::MediaControlLoadingPanelElement::CleanupShadowDOM
  blink::MediaControlsImpl::Hide
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=542547:542551

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6209874179129344

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 24 2018

Components: Blink>Media>Controls
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: brajkumar@chromium.org
Labels: -Type-Bug M-67 Test-Predator-Wrong Type-Bug-Regression
Owner: steimel@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.

From the below CL observing some changes related to 'media controls' , hence suspecting the same
https://chromium.googlesource.com/chromium/src/+log/c06159611876d8b4bb1ea997e5647f8ba888ea60..9738bb07bdea8848f292498e6d139b3fd2c8eebd?pretty=fuller&n=10000

Suspect CL: https://chromium.googlesource.com/chromium/src/+/fdfc5ae4154a67e0539b9d0a77b3c5e2da38f40b

steimel@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f2fdeb75f92cccf1fd6877ff412f9458676ddf

commit d9f2fdeb75f92cccf1fd6877ff412f9458676ddf
Author: Tommy Steimel <steimel@chromium.org>
Date: Wed Mar 28 00:32:46 2018

Add null check before detaching MediaControlAnimationEventListener

This CL adds a null check before calling Detach on the animation event
listener when cleaning up the shadow DOM. This prevents a potential
crash when RemovedFrom is called before CleanupShadowDOM.

Bug:  825484 
Change-Id: Ie398c05750178d17f21396949566362a5b67a620
Reviewed-on: https://chromium-review.googlesource.com/982258
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546334}
[modify] https://crrev.com/d9f2fdeb75f92cccf1fd6877ff412f9458676ddf/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Mar 28 2018

Labels: OS-Windows
Project Member

Comment 7 by ClusterFuzz, Mar 28 2018

ClusterFuzz has detected this issue as fixed in range 546332:546334.

Detailed report: https://clusterfuzz.com/testcase?key=6209874179129344

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::MediaControlAnimationEventListener::Detach
  blink::MediaControlLoadingPanelElement::CleanupShadowDOM
  blink::MediaControlsImpl::Hide
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=542547:542551
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=546332:546334

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6209874179129344

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Mar 28 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6209874179129344 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment