Issue metadata
Sign in to add a comment
|
WebstoreInlineInstallerTest.ReinstallDisabledExtension is Flaky |
||||||||||||||||||||||
Issue descriptionFindit has detected a flake at test WebstoreInlineInstallerTest.ReinstallDisabledExtension. Culprit (88.6% confidence): https://chromium-review.googlesource.com/q/I7eb6bf93daba908258ae604a8cd45ea643b4e00d Regression range: https://crrev.com/d03adf5a2c53f00c4663a93917a9fb0a53f082ad..d65f1e79a2d0f48d998bf732d341f9112f9aff83?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ4Y2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKDEpLzc4NDIxL2Jyb3dzZXJfdGVzdHMvVjJWaWMzUnZjbVZKYm14cGJtVkpibk4wWVd4c1pYSlVaWE4wTGxKbGFXNXpkR0ZzYkVScGMyRmliR1ZrUlhoMFpXNXphVzl1DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
,
Mar 26 2018
Any progress on this? Looking at the failure it is a crash, and still happening, so I'm reluctant to just disable the test.
,
Mar 27 2018
Yes, I'm about to send CL to fix this.
,
Mar 27 2018
I've sent out https://chromium-review.googlesource.com/c/chromium/src/+/981610 for fixing this, though the failure stack trace locally on linux I got looks a bit different than that of the bots.
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ad6ced2d17b993177f60b5451f196b4856a1ad8 commit 9ad6ced2d17b993177f60b5451f196b4856a1ad8 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Mar 27 19:39:40 2018 Fix "is cancelled" checking in ContentVerifier hash retrieval code. We call HashHelper::Cancel on IO during extension unload. If the extension's hash retrieval through ContentHash was ongoing at that point, ContentHash might not see the cancellation if it already progressed enough on non-IO thread. This CL makes sure we check for cancellation before passing the read hash value on IO thread. This fixes WebstoreInstallerTest.ReinstallDisabledExtension test's flakiness locally. Bug: 825470 Change-Id: Ib5b166cb14d3aee16b0cac9ae198a4141dc3563c Reviewed-on: https://chromium-review.googlesource.com/981610 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546207} [modify] https://crrev.com/9ad6ced2d17b993177f60b5451f196b4856a1ad8/extensions/browser/content_verifier.cc
,
Mar 31 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by lazyboy@chromium.org
, Mar 25 2018Owner: lazyboy@chromium.org
Status: Started (was: Available)