MD-Extensions optionUI dialog sizing is broken
Reported by
woxxom@gmail.com,
Mar 24 2018
|
|||||||||||||||||||||
Issue descriptionChrome 67.0.3377.0 and newer 1. install the attached extension exhibit1.zip or exhibit2.zip 2. click the extension icon, click Options Expected: the dialog is sized correctly, the contents is visible and the text is readable Observed: the dialog is sized incorrectly, the contents is clipped/unreadable P.S. MD-extensions should be enabled, which is default in Chrome 67, otherwise you can enable it via chrome://flags/#enable-md-extensions ================================================================= Bisected to r544560 = d289dbadf718e02a2b13d38e5bb1bfa26a090f9d = https://crrev.com/c/967456 ================================================================= The bug is also observed in existing extensions, for example: https://chrome.google.com/webstore/detail/tabs-to-the-front/hiembaoomcehoiehhdldabfgnmphappc https://chrome.google.com/webstore/detail/stylus/clngdbkpkpeebahjckkjfobafhncgmne Based on the incorrect sizing even in the most basic cases of the attached extensions, I guess the bug affects many existing extensions.
,
Mar 26 2018
Able to reproduce the issue on chrome reported version 67.0.3377.0 using Windows-10, Mac 10.12.6 & Ubuntu 14.04, as per comment#0 from the reporter providing the CL and assigning it to the respective author Note: Issue is not seen on Chrome latest stable# 65.0.3325.181 & Beta: 66.0.3359.45 Bisect info: ================= Good Build: 67.0.3376.1 Bad Build: 67.0.3377.0 Suspecting: https://chromium.googlesource.com/chromium/src/+/d289dbadf718e02a2b13d38e5bb1bfa26a090f9d Reviewed-on: https://chromium-review.googlesource.com/967456 @dpapad: Please confirm the issue and help in re-assigning if it is not related to your change. Adding ReleaseBlock-Stable as it is seems a receent break, feel free to remove it if not applicable. Thanks!
,
Mar 26 2018
,
Apr 2 2018
FYI, candidate fix is at https://chromium-review.googlesource.com/#/c/chromium/src/+/990893. Attaching a few screenshots.
,
Apr 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74060830fe7822d08175d0c115b8c9161e9968b1 commit 74060830fe7822d08175d0c115b8c9161e9968b1 Author: dpapad <dpapad@chromium.org> Date: Sat Apr 07 02:11:27 2018 MD Extensions: Add min width, max height for options dialog. Bug: 825446 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I40949f81d7c388049250c012cabf030d7649d572 Reviewed-on: https://chromium-review.googlesource.com/990893 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549015} [modify] https://crrev.com/74060830fe7822d08175d0c115b8c9161e9968b1/chrome/browser/resources/md_extensions/options_dialog.js [modify] https://crrev.com/74060830fe7822d08175d0c115b8c9161e9968b1/chrome/test/data/webui/extensions/extension_options_dialog_test.js
,
Apr 9 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Mar 26 2018