New issue
Advanced search Search tips

Issue 825431 link

Starred by 3 users
Status: Fixed
Owner:
rohitrao@chromium.org
Closed: Jul 24
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-07-04
OS: iOS
Pri: 1
Type: Bug
Q2

Blocked on:
issue 831290
issue 834723
issue 835860
issue 835871
Blocking:
issue 818742



Sign in to add a comment

ios_chrome_ui_tests fail with --enable-features=UIRefreshPhase1 ON

Project Member Reported by rohitrao@chromium.org, Mar 24 2018 
Test Case '-[ContentSuggestionsTestCase testAdditionalItemsKept]' failed (11.802 seconds).
Test Case '-[ContentSuggestionsTestCase testMoreReadingListSection]' failed (7.476 seconds).
Test Case '-[ContentSuggestionsTestCase testPrivacySwitch]' failed (3.087 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListItem]' failed (4.141 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListLongPress]' failed (7.440 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListOpenNewIncognitoTab]' failed (7.399 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListOpenNewTab]' failed (7.482 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListRemove]' failed (7.441 seconds).
Test Case '-[ContentSuggestionsTestCase testSectionTitle]' failed (2.416 seconds).
Test Case '-[ContentSuggestionsTestCase testSwipeToDismissReadingListItem]' failed (4.139 seconds).
Test Case '-[FindInPageTestCase testAccessibilityOnFindInPage]' failed (4.291 seconds).
Test Case '-[FindInPageTestCase testFindInPage]' failed (4.610 seconds).
Test Case '-[FindInPageTestCase testFindInPageRetainsSearchTerm]' failed (4.780 seconds).
Test Case '-[FullscreenTestCase testLongPDFInitialState]' failed (3.073 seconds).
Test Case '-[HistoryUITestCase testAccessibilityOnHistory]' failed (3.566 seconds).
Test Case '-[HistoryUITestCase testClearBrowsingHistory]' failed (7.396 seconds).
Test Case '-[HistoryUITestCase testContextMenuCopy]' failed (7.512 seconds).
Test Case '-[HistoryUITestCase testContextMenuOpenInNewIncognitoTab]' failed (7.052 seconds).
Test Case '-[HistoryUITestCase testContextMenuOpenInNewTab]' failed (7.364 seconds).
Test Case '-[HistoryUITestCase testDeleteHistory]' failed (7.578 seconds).
Test Case '-[HistoryUITestCase testDisplayHistory]' failed (7.239 seconds).
Test Case '-[HistoryUITestCase testDisplayNoHistory]' failed (3.648 seconds).
Test Case '-[HistoryUITestCase testHistoryUpdateAfterBackNavigation]' failed (7.579 seconds).
Test Case '-[JavaScriptDialogTestCase testShowJavaScriptBehindSettings]' failed (4.566 seconds).
Test Case '-[KeyboardCommandsTestCase testKeyboardCommands_RecentTabsPresented]' failed (3.138 seconds).
Test Case '-[KeyboardCommandsTestCase testKeyboardCommandsNotRegistered_BookmarksPresented]' failed (3.173 seconds).
Test Case '-[KeyboardCommandsTestCase testKeyboardCommandsNotRegistered_SettingsPresented]' failed (3.164 seconds).
Test Case '-[NTPHomeTestCase testPromoTap]' failed (3.090 seconds).
Test Case '-[NTPHomeTestCase testTapFakeOmniboxLogsCorrectly]' failed (4.209 seconds).
Test Case '-[PrintControllerTestCase testPrintNormalPage]' failed (29.485 seconds).
Test Case '-[PrintControllerTestCase testPrintPDF]' failed (3.024 seconds).
Test Case '-[QRScannerViewControllerTestCase testCameraUnavailableDialog]' failed (7.357 seconds).
Test Case '-[QRScannerViewControllerTestCase testReceivingQRScannerSearchQueryResult]' failed (15.069 seconds).
Test Case '-[RecentTabsTableTestCase testClosedTabAppearsInRecentTabsPanel]' failed (5.250 seconds).
Test Case '-[RecentTabsTableTestCase testOpenHistory]' failed (3.227 seconds).
Test Case '-[RecentTabsTableTestCase testRecentTabSigninPromoReloaded]' failed (3.227 seconds).
Test Case '-[RecentTabsTableTestCase testRecentTabSigninPromoReloadedWhileHidden]' failed (3.285 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testAppVersionJSAPIWithDesktopUserAgent]' failed (6.012 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testAppVersionJSAPIWithMobileUserAgent]' failed (4.685 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testRequestDesktopSiteDoesNotPropagateToNewTab]' failed (5.394 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testRequestDesktopSiteGoBackToMobile]' failed (4.686 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testRequestDesktopSiteNotEnabledOnNewTabPage]' failed (3.162 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testRequestDesktopSiteNotEnabledOnWebUIPage]' failed (4.787 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testRequestDesktopSitePropagatesToNextNavigations]' failed (5.068 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testRequestMobileSiteGoBackToDesktop]' failed (5.055 seconds).
Test Case '-[RequestDesktopMobileSiteTestCase testRequestMobileSitePropagatesToNextNavigations]' failed (5.395 seconds).
Test Case '-[SadTabViewTestCase testSadTabView]' failed (11.626 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInCancelAddAccount]' failed (3.397 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInCancelAuthenticationFlow]' failed (3.239 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInCancelFromBookmarks]' failed (3.175 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInCancelIdentityPicker]' failed (3.242 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInDisconnectFromChrome]' failed (3.164 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInDisconnectFromChromeManaged]' failed (3.145 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInOneUser]' failed (3.169 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInOpenSettings]' failed (3.180 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInSwitchAccountsAndImportData]' failed (3.154 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInSwitchAccountsAndKeepDataSeparate]' failed (3.327 seconds).
Test Case '-[SigninInteractionControllerTestCase testSignInSwitchManagedAccount]' failed (3.194 seconds).
Test Case '-[SyncFakeServerTestCase testSyncCheckDifferentCacheGuid_SignOutAndSignIn]' failed (3.540 seconds).
Test Case '-[SyncFakeServerTestCase testSyncCheckSameCacheGuid_SyncRestarted]' failed (3.188 seconds).
Test Case '-[SyncFakeServerTestCase testSyncCheckSameCacheGuid_SyncRestartedAfterSignOutAndSignIn]' failed (3.165 seconds).
Test Case '-[TabStripTestCase testTabStripSwitchTabs]' failed (3.125 seconds).
Test Case '-[TabSwitcherControllerTestCase testColdSigninPromoView]' failed (2.334 seconds).
Test Case '-[TabSwitcherControllerTestCase testEnteringTabSwitcher]' failed (2.376 seconds).
Test Case '-[TabSwitcherControllerTestCase testIncognitoTabs]' failed (3.099 seconds).
Test Case '-[TabSwitcherControllerTestCase testLeavingSwitcherFromOtherDevices]' failed (2.384 seconds).
Test Case '-[TabSwitcherControllerTestCase testReloadOtherTabDevicesTab]' failed (2.349 seconds).
Test Case '-[TabSwitcherControllerTestCase testWarmSigninPromoView]' failed (2.332 seconds).
Test Case '-[TabSwitcherTransitionTestCase testEnterSwitcherByClosingLastIncognitoTab]' failed (3.177 seconds).
Test Case '-[TabSwitcherTransitionTestCase testEnterSwitcherWithMultipleIncognitoTabs]' failed (3.132 seconds).
Test Case '-[TabSwitcherTransitionTestCase testEnterSwitcherWithMultipleNormalTabs]' failed (3.230 seconds).
Test Case '-[TabSwitcherTransitionTestCase testEnterSwitcherWithNormalAndIncognitoTabs]' failed (3.152 seconds).
Test Case '-[TabSwitcherTransitionTestCase testEnterSwitcherWithOneIncognitoTab]' failed (3.174 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherByOpeningNewIncognitoTab]' failed (3.146 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherByOpeningTabInOtherMode]' failed (2.493 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherBySelectingIncognitoTab]' failed (3.178 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherBySelectingNormalTab]' failed (4.939 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherBySelectingTabInOtherMode]' failed (5.076 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherWithSwitcherButton]' failed (4.389 seconds).
Test Case '-[TabSwitcherTransitionTestCase testRotationsWhileSwitcherIsNotActive]' failed (4.416 seconds).
Test Case '-[TabSwitcherTransitionTestCase testSwappingBVCModesWithoutEnteringSwitcher]' failed (3.274 seconds).
Test Case '-[ToolbarTestCase testIPadKeyboardDismissOnButtonPress]' failed (6.759 seconds).
Test Case '-[ToolbarTestCase testNewIncognitoTabFromMenu]' failed (3.228 seconds).
Test Case '-[ToolbarTestCase testNewTabFromMenu]' failed (3.238 seconds).
Test Case '-[ToolbarTestCase testToolbarUI]' failed (1.155 seconds).
Test Case '-[ToolsPopupMenuTestCase testNoSearchForPDF]' failed (5.105 seconds).
Test Case '-[ToolsPopupMenuTestCase testOpenAndCloseToolsMenu]' failed (3.244 seconds).
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e0f8824b98d30675feb923896daa31a82813ef

commit e9e0f8824b98d30675feb923896daa31a82813ef
Author: Rohit Rao <rohitrao@chromium.org>
Date: Wed Mar 28 16:54:35 2018

[ios] Fixes a crash in Recent Tabs egtests.

The Recent Tabs mediator was living longer than expected and was improperly
being destroyed without being disconnected first.  This CL adds a temporary
workaround for this issue.

BUG= 825431 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3851442db2a7911498fe6e0081daf223ac5b4ad1
Reviewed-on: https://chromium-review.googlesource.com/983714
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546525}
[modify] https://crrev.com/e9e0f8824b98d30675feb923896daa31a82813ef/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b757fbffa0c825780b132fda21048b084d24ba13

commit b757fbffa0c825780b132fda21048b084d24ba13
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Mar 30 12:35:29 2018

[ios] Moves TabSwitcherMode to a separate file.

The GetTabSwitcherMode() function is more broadly useful outside of just
MainController, so it is extracted into a helper file that anyone can use.

BUG= 825431 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I23829872840d2cfcd20f95f5b05c7380a3e8d0f3
Reviewed-on: https://chromium-review.googlesource.com/986278
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547146}
[modify] https://crrev.com/b757fbffa0c825780b132fda21048b084d24ba13/ios/chrome/app/BUILD.gn
[modify] https://crrev.com/b757fbffa0c825780b132fda21048b084d24ba13/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/b757fbffa0c825780b132fda21048b084d24ba13/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[add] https://crrev.com/b757fbffa0c825780b132fda21048b084d24ba13/ios/chrome/browser/ui/tab_switcher/tab_switcher_mode.h
[add] https://crrev.com/b757fbffa0c825780b132fda21048b084d24ba13/ios/chrome/browser/ui/tab_switcher/tab_switcher_mode.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80b1d2e0d76b7928047163b8dae7a482f0e76e19

commit 80b1d2e0d76b7928047163b8dae7a482f0e76e19
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Mar 30 13:29:24 2018

[ios] Fixes History egtests when the UIRefresh flag is enabled.

These tests were failing because EG was unable to scroll the tools menu and tap
on the History item. This CL adds the proper accessibilityIdentifier to the
tools menu table view and moves a constant to a new file to make that easier.

This CL also deletes the PopupMediatorTests, because they are no longer
relevant, but leaves the test fixture in place.

BUG= 825431 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I08ea0ff8e5af34b1599c3352f970b4414fd72f75
Reviewed-on: https://chromium-review.googlesource.com/984515
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547150}
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.h
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/tools_menu/public/tools_menu_constants.mm
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/tools_menu/tools_popup_controller.h
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm
[modify] https://crrev.com/80b1d2e0d76b7928047163b8dae7a482f0e76e19/ios/chrome/test/earl_grey/chrome_matchers.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79b1cf04aed14c34912af7a9cd3167c0de6ee860

commit 79b1cf04aed14c34912af7a9cd3167c0de6ee860
Author: Rohit Rao <rohitrao@chromium.org>
Date: Fri Mar 30 13:39:21 2018

[ios] Skips TabSwitcher egtests when the UIRefresh flag is enabled.

The TabSwitcher tests cannot be run when the TabGrid is being used instead.

BUG= 825431 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id7080571bbaae0dcf11026d59a2118533c3faf12
Reviewed-on: https://chromium-review.googlesource.com/984437
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547152}
[modify] https://crrev.com/79b1cf04aed14c34912af7a9cd3167c0de6ee860/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/79b1cf04aed14c34912af7a9cd3167c0de6ee860/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller_egtest.mm

Comment 5 by rohitrao@chromium.org, Mar 30 2018

Status: Started (was: Assigned)
Executed 186 tests, with 29 failures (29 unexpected) in 1484.239 (1485.155) seconds

Test Case '-[ContentSuggestionsTestCase testMoreReadingListSection]' failed (7.636 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListItem]' failed (10.664 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListLongPress]' failed (7.679 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListOpenNewIncognitoTab]' failed (7.536 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListOpenNewTab]' failed (7.475 seconds).
Test Case '-[ContentSuggestionsTestCase testReadingListRemove]' failed (7.486 seconds).
Test Case '-[ContentSuggestionsTestCase testSectionTitle]' failed (2.404 seconds).
Test Case '-[ContentSuggestionsTestCase testSwipeToDismissReadingListItem]' failed (10.527 seconds).
Test Case '-[FullscreenTestCase testLongPDFInitialState]' failed (4.352 seconds).
Test Case '-[KeyboardCommandsTestCase testKeyboardCommands_RecentTabsPresented]' failed (10.400 seconds).
Test Case '-[NTPHomeTestCase testTapFakeOmniboxLogsCorrectly]' failed (4.414 seconds).
Test Case '-[PrintControllerTestCase testPrintNormalPage]' failed (40.478 seconds).
Test Case '-[PrintControllerTestCase testPrintPDF]' failed (3.186 seconds).
Test Case '-[QRScannerViewControllerTestCase testCameraUnavailableDialog]' failed (7.190 seconds).
Test Case '-[QRScannerViewControllerTestCase testReceivingQRScannerSearchQueryResult]' failed (16.141 seconds).
Test Case '-[RecentTabsTableTestCase testClosedTabAppearsInRecentTabsPanel]' failed (9.660 seconds).
Test Case '-[RecentTabsTableTestCase testOpenHistory]' failed (8.097 seconds).
Test Case '-[RecentTabsTableTestCase testRecentTabSigninPromoReloaded]' failed (10.348 seconds).
Test Case '-[RecentTabsTableTestCase testRecentTabSigninPromoReloadedWhileHidden]' failed (8.627 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherByOpeningTabInOtherMode]' failed (2.509 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherBySelectingIncognitoTab]' failed (17.402 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherBySelectingNormalTab]' failed (13.433 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherBySelectingTabInOtherMode]' failed (8.913 seconds).
Test Case '-[TabSwitcherTransitionTestCase testLeaveSwitcherWithSwitcherButton]' failed (4.318 seconds).
Test Case '-[TabSwitcherTransitionTestCase testRotationsWhileSwitcherIsNotActive]' failed (4.445 seconds).
Test Case '-[ToolbarTestCase testIPadKeyboardDismissOnButtonPress]' failed (6.634 seconds).
Test Case '-[ToolbarTestCase testToolbarUI]' failed (1.245 seconds).
Test Case '-[ToolsPopupMenuTestCase testNoSearchForPDF]' failed (5.431 seconds).
Test Case '-[ToolsPopupMenuTestCase testOpenAndCloseToolsMenu]' failed (3.669 seconds).
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dd1930a7c8c8de400d352955bedcb42321df607

commit 9dd1930a7c8c8de400d352955bedcb42321df607
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Apr 02 14:09:09 2018

[ios] Updates TabSwitcherTransitionTest to work with the tab grid.

Modifies the test to use the TabSwitcherMode enum instead of checking
IsIPadIdiom().  Adds some EG matchers for various elements of the tab grid.

BUG= 825431 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I29de41c895696627f37cc26b0c7853ab068f1834
Reviewed-on: https://chromium-review.googlesource.com/988273
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547435}
[modify] https://crrev.com/9dd1930a7c8c8de400d352955bedcb42321df607/ios/chrome/browser/ui/tab_grid/BUILD.gn
[add] https://crrev.com/9dd1930a7c8c8de400d352955bedcb42321df607/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.h
[add] https://crrev.com/9dd1930a7c8c8de400d352955bedcb42321df607/ios/chrome/browser/ui/tab_grid/tab_grid_egtest_util.mm
[modify] https://crrev.com/9dd1930a7c8c8de400d352955bedcb42321df607/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/9dd1930a7c8c8de400d352955bedcb42321df607/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1abf853120db949b0b72cc0c7f857b66fc73c5fa

commit 1abf853120db949b0b72cc0c7f857b66fc73c5fa
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Apr 02 16:27:55 2018

[ios] Fixes the QR scanner egtests when the UIRefresh flag is enabled.

Fixes minor issues with an underspecified "Cancel" button matcher and updated
swizzling to use the new LocationBarCoordinator instead of the old
LocationBarLegacyCoordinator.

BUG= 825431 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6ef8c3d585f8575939ed74c7ec6eb189d31d6f22
Reviewed-on: https://chromium-review.googlesource.com/989271
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547445}
[modify] https://crrev.com/1abf853120db949b0b72cc0c7f857b66fc73c5fa/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ab736edec259beeb74312d493ec3da2f4f79163

commit 6ab736edec259beeb74312d493ec3da2f4f79163
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Apr 02 19:49:46 2018

[ios] Fixes FullscreenTestCase.testLongPDFInitialState when UIRefresh is enabled.

This test checks for a specific contentOffset, which is different under the
UIRefresh experiment.

BUG= 825431 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibe5e4743eb6471025fde7b27785a4267f42e0e91
Reviewed-on: https://chromium-review.googlesource.com/989250
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547492}
[modify] https://crrev.com/6ab736edec259beeb74312d493ec3da2f4f79163/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d380229024918dce24878a8c14cd900fa020edca

commit d380229024918dce24878a8c14cd900fa020edca
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Apr 03 14:51:23 2018

[ios] Fixes Toolbar egtests when the UIRefresh flag is enabled.

BUG= 825431 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6752cbf38aa826c9197c524e16b5adaa04f0af57
Reviewed-on: https://chromium-review.googlesource.com/990535
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547705}
[modify] https://crrev.com/d380229024918dce24878a8c14cd900fa020edca/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f366a5a6c2aa27f2797a3f01eb6fe704d55e9aea

commit f366a5a6c2aa27f2797a3f01eb6fe704d55e9aea
Author: Rohit Rao <rohitrao@chromium.org>
Date: Wed Apr 04 15:16:29 2018

[ios] Fixes some egtests when the UIRefresh flag is enabled.

KeyboardCommandsTestCase:
- Updates the recent tabs test now that recent tabs is always presented
  and never contained.
- Updates the recent tabs test because the a11y ID of the "Done" button
  is different when the UIRefresh flag is enabled.

RecentTabsTableTestCase:
- Properly nils out the mediator after it is disconnected.  This
  prevents a crash when launching recent tabs a second time.

BUG= 825431 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib97c1536083fae82dcc523c8ea2787c74f92469b
Reviewed-on: https://chromium-review.googlesource.com/995617
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548061}
[modify] https://crrev.com/f366a5a6c2aa27f2797a3f01eb6fe704d55e9aea/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f366a5a6c2aa27f2797a3f01eb6fe704d55e9aea/ios/chrome/browser/ui/keyboard_commands_egtest.mm
[modify] https://crrev.com/f366a5a6c2aa27f2797a3f01eb6fe704d55e9aea/ios/chrome/browser/ui/recent_tabs/recent_tabs_coordinator.mm
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33419b69a8c4f5ebda0d6d77ecb2c4e65e72006f

commit 33419b69a8c4f5ebda0d6d77ecb2c4e65e72006f
Author: Rohit Rao <rohitrao@chromium.org>
Date: Wed Apr 04 17:38:31 2018

[ios] Disables the StackView egtests when the StackView is not enabled.

BUG= 825431 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I95f5f986900aa31f4a484a36c0fbd789cf2b3c5e
Reviewed-on: https://chromium-review.googlesource.com/995916
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548116}
[modify] https://crrev.com/33419b69a8c4f5ebda0d6d77ecb2c4e65e72006f/ios/chrome/browser/ui/stack_view/BUILD.gn
[modify] https://crrev.com/33419b69a8c4f5ebda0d6d77ecb2c4e65e72006f/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8527f90398bfd1ad04cfdecfe06b1e10625ce81

commit b8527f90398bfd1ad04cfdecfe06b1e10625ce81
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Apr 09 20:54:25 2018

[ios] Disables PrintControllerTests on iOS11 when UIRefresh is enabled.

These tests cannot invoke Print via the share menu on iOS11, so they
are redundant with the tests in JSPrintTestCase.

BUG= 825431 ,683280

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0e9965dfddf1e49d583a5304d7392cd59ac63bca
Reviewed-on: https://chromium-review.googlesource.com/990533
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549268}
[modify] https://crrev.com/b8527f90398bfd1ad04cfdecfe06b1e10625ce81/ios/chrome/browser/ui/print/print_controller_egtest.mm

Comment 13 by rohitrao@chromium.org, Apr 10 2018

Blockedon: 831290

Comment 14 by justincohen@chromium.org, Apr 10 2018 

FYI, missed crbug on this commit:

[ios] Fix qr scanner test for ui refresh.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I78e2b3d1a6335a73a074e0534980238d3a61568c
Reviewed-on: https://chromium-review.googlesource.com/1005439
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549579}
Relation chain
Don't handle iTunes Bundle with StoreKit.
[Modern] Refreshes Recent Tabs page

Comment 15 by marq@chromium.org, Apr 11 2018

Labels: MS-Infrastructure

Comment 16 by marq@chromium.org, Apr 11 2018

Labels: Q2

Comment 17 by marq@chromium.org, Apr 11 2018

Labels: S-Tests

Comment 18 by marq@chromium.org, Apr 11 2018

Labels: Pri-0
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f20fb4a0eb3ef9d36f8dac535f05bb3469d200f0

commit f20fb4a0eb3ef9d36f8dac535f05bb3469d200f0
Author: Rohit Rao <rohitrao@chromium.org>
Date: Wed Apr 11 22:37:27 2018

[ios] Fixes testRecentTabSigninPromoReloadedWhileHidden.

Recent Tabs tableview cells are no longer marked with the Button a11y trait, so
the matcher for the "Other Devices" button needed to be updated accordingly.

BUG= 825431 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2daa26fb0b2aa2fa45d4df0b62361f512fcb243e
Reviewed-on: https://chromium-review.googlesource.com/1008046
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549961}
[modify] https://crrev.com/f20fb4a0eb3ef9d36f8dac535f05bb3469d200f0/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_egtest.mm
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0142b7fd84852e6e281b60e31227914781983177

commit 0142b7fd84852e6e281b60e31227914781983177
Author: Rohit Rao <rohitrao@chromium.org>
Date: Thu Apr 12 02:39:21 2018

[ios] Fixes testOpenAndCloseToolsMenu when the UIRefresh flag is enabled

BUG= 825431 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I044a4fd10f669facccb7bc571b0e39548ac81a0b
Reviewed-on: https://chromium-review.googlesource.com/1008666
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549999}
[modify] https://crrev.com/0142b7fd84852e6e281b60e31227914781983177/ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm

Comment 21 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags

Comment 22 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags
Project Member

Comment 23 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/662e96bd0bf586e5f10e7809288fd194a739b8f7

commit 662e96bd0bf586e5f10e7809288fd194a739b8f7
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Apr 23 19:30:31 2018

[ios] Fixes UI egtests when the UIRefresh flag is enabled.

KeyboardCommandsTestCase.testKeyboardCommandsNotRegistered_AddBookmarkPresented
and ToolbarTestCase.testToolbarOmniboxTyping are updated with matches for the
correct elements.

ActivityServiceControllerTestCase.testActivityServiceControllerIsDisabled and
TabSwitcherTransitionTestCase.testRotationsWhileSwitcherIsNotActive are
disabled, because these tests are exposing UIRefresh bugs.

BUG= 825431 , 835860 , 835871 
TEST=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I805e4b29ce59b88eb63016d4d2687c9043c72f5b
Reviewed-on: https://chromium-review.googlesource.com/1023718
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552790}
[modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/keyboard_commands_egtest.mm
[modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/tab_switcher/tab_switcher_transition_egtest.mm
[modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/662e96bd0bf586e5f10e7809288fd194a739b8f7/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Comment 24 by rohitrao@chromium.org, Apr 24 2018

Blockedon: 835860 834723 835871
Status: Assigned (was: Started)
We uncovered a few real issues with the app that need to be fixed before their associated tests can be reenabled.  Those are being tracked in the blocking bugs.  Once those are resolved, we can mark this master bug fixed.

For now I have disabled the offending tests and will move ios_chrome_ui_egtests to the main internal waterfall.
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/78ea0466fb9e8dc2dee78c77ed51f010616bb42b

commit 78ea0466fb9e8dc2dee78c77ed51f010616bb42b
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Apr 24 16:17:30 2018

Comment 26 by rohitrao@chromium.org, Apr 25 2018

Status: Started (was: Assigned)

Comment 27 by rohitrao@chromium.org, Apr 25 2018

Labels: large

Comment 28 by rohitrao@chromium.org, Apr 25 2018

Labels: -Type-Bug Type-Task
Project Member

Comment 29 by bugdroid1@chromium.org, Apr 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a0e0ad1be4c2637cb786c4213f6f40738ee1cab

commit 9a0e0ad1be4c2637cb786c4213f6f40738ee1cab
Author: Justin Cohen <justincohen@google.com>
Date: Wed Apr 25 23:04:56 2018

[ios] Fix NTP scroll tests.

Start the scroll from the middle of the screen incase the default bottom of the
screen is obscured by the bottom toolbar and stop using kGREYContentEdgeBottom.

BUG:  825431 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I704954672bf46e9cb138ea0be6a325ba4aeb3d69
Reviewed-on: https://chromium-review.googlesource.com/1028462
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553805}
[modify] https://crrev.com/9a0e0ad1be4c2637cb786c4213f6f40738ee1cab/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm

Comment 30 by rohitrao@chromium.org, May 2 2018

NextAction: 2018-05-09

Comment 31 by monor...@bugs.chromium.org, May 9 2018 

The NextAction date has arrived: 2018-05-09
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b05097ad99da56b37da835bd3acc949a1a14a6

commit 20b05097ad99da56b37da835bd3acc949a1a14a6
Author: Rohit Rao <rohitrao@chromium.org>
Date: Sun Jun 03 22:20:20 2018

[ios] Fixes ui_egtests to scroll the share menu if needed.

When the UIRefresh flag is enabled, additional actions are added to the
share menu.  These actions end up pushing the Print action off of the
first screenful of items, so tests must be updated to scroll the
collection view if needed.

Also converts a History egtest to use a constant for an a11y identifier
and to avoid inadvertently dismissing the history ui.

BUG= 825431 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1efebb04d1de54dcef7c2c7d3374eff2c61c9838
Reviewed-on: https://chromium-review.googlesource.com/1083723
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563978}
[modify] https://crrev.com/20b05097ad99da56b37da835bd3acc949a1a14a6/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/20b05097ad99da56b37da835bd3acc949a1a14a6/ios/chrome/browser/ui/history/history_table_view_controller.mm
[modify] https://crrev.com/20b05097ad99da56b37da835bd3acc949a1a14a6/ios/chrome/browser/ui/history/history_ui_constants.h
[modify] https://crrev.com/20b05097ad99da56b37da835bd3acc949a1a14a6/ios/chrome/browser/ui/history/history_ui_constants.mm
[modify] https://crrev.com/20b05097ad99da56b37da835bd3acc949a1a14a6/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/20b05097ad99da56b37da835bd3acc949a1a14a6/ios/chrome/browser/ui/print/print_controller_egtest.mm

Comment 33 by marq@chromium.org, Jun 21 2018

Labels: Type-Bug

Comment 34 by marq@chromium.org, Jun 27 2018

NextAction: 2018-07-04
Moving open tasks to the current sprint.

Comment 35 by marq@chromium.org, Jun 27 2018

Labels: Pri-1

Comment 36 by monor...@bugs.chromium.org, Jul 4 

The NextAction date has arrived: 2018-07-04

Comment 37 by marq@chromium.org, Jul 10

Labels: M-69

Comment 38 by rohitrao@chromium.org, Jul 24

Status: Fixed (was: Started)
The failures that were caused by bugs in the UIRefresh UI have been addressed and those tests reenabled.

Comment 39 by marq@chromium.org, Jul 25

Labels: UIRefresh-NoMerge
►

Sign in to add a comment