New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825421 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-firmware-null build broken during compile phase: "cannot pack firmware"

Project Member Reported by pbe...@chromium.org, Mar 24 2018

Issue description

emerge-<board> chromeos-firmware-null fails when the FW is actually not being built (e.g. external source only coral builds not using bootimage USE flag)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/62dc5fda05b64b2026124f5c50e499f424387273

commit 62dc5fda05b64b2026124f5c50e499f424387273
Author: Patrick Berny <pberny@chromium.org>
Date: Tue Mar 27 00:03:29 2018

chromeos-firmware-null: Implement dummy src_xyz()

Implement dummy src_unpack, src_compile, src_install, src_test to
override the functions coming from cros-firmware.eclass that require
actual FW to be there.

BUG= chromium:825421 
TEST=setup workspace with public source only
     cros_workon-coral start chromeos-firmware-null
     emerge-coral chromeos-firmware-null

Change-Id: Ib9d6f6290e4cfba7ba96fce2076d89887e18bd25
Reviewed-on: https://chromium-review.googlesource.com/979162
Commit-Ready: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Reviewed-by: Patrick Berny <pberny@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/62dc5fda05b64b2026124f5c50e499f424387273/chromeos-base/chromeos-firmware-null/chromeos-firmware-null-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2018

Labels: merge-merged-factory-coral-10122.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9a393362bfa39ddd5b5f6c92fdb83824c099c313

commit 9a393362bfa39ddd5b5f6c92fdb83824c099c313
Author: Patrick Berny <pberny@chromium.org>
Date: Thu Apr 12 13:18:01 2018

chromeos-firmware-null: Implement dummy src_xyz()

Implement dummy src_unpack, src_compile, src_install, src_test to
override the functions coming from cros-firmware.eclass that require
actual FW to be there.

BUG= chromium:825421 
TEST=setup workspace with public source only
     cros_workon-coral start chromeos-firmware-null
     emerge-coral chromeos-firmware-null

Change-Id: Ib9d6f6290e4cfba7ba96fce2076d89887e18bd25
Reviewed-on: https://chromium-review.googlesource.com/979162
Commit-Ready: Patrick Berny <pberny@chromium.org>
Tested-by: Patrick Berny <pberny@chromium.org>
Reviewed-by: Patrick Berny <pberny@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org>
(cherry picked from commit 62dc5fda05b64b2026124f5c50e499f424387273)
Reviewed-on: https://chromium-review.googlesource.com/1009682
Reviewed-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Commit-Queue: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>
Tested-by: Ren Kuo <ren.kuo@quanta.corp-partner.google.com>

[modify] https://crrev.com/9a393362bfa39ddd5b5f6c92fdb83824c099c313/chromeos-base/chromeos-firmware-null/chromeos-firmware-null-9999.ebuild

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Status: Fixed (was: Assigned)

Sign in to add a comment