New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825419 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

assertion filed for "No files key in content from isolate"

Project Member Reported by st...@chromium.org, Mar 24 2018

Issue description

Page URL: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.10/44840

 Description:

at GetIsolatedOuptputFileToHashMap (services/isolate.py:30)
at DownloadFileFromIsolatedServer (services/isolate.py:51)
 

Comment 1 by chanli@chromium.org, Mar 24 2018

Cc: mar...@chromium.org
It seems assertion fired because of this isolated out: https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=51b8142c823ecc5b2a2178d35e620cd2c1962358. It's empty.

I've never seen any isolate page like that before.

cc maruel@ for more information.

Comment 2 by maruel@google.com, Mar 24 2018

That's a valid file. Rare but it's valid to skip files.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/67b334eb51f357d92c7455d69363787cc571f600

commit 67b334eb51f357d92c7455d69363787cc571f600
Author: Chan <chanli@chromium.org>
Date: Tue Mar 27 00:59:32 2018

[Findit] remove assertion for files in isolated response.

Record an error instead.

Bug:  825419 
Change-Id: Ib42bbb56877f180b6b8ccddea5d695f0fb623bfd
Reviewed-on: https://chromium-review.googlesource.com/979706
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/services/flake_failure/test/run_swarming_util_test.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/services/isolate.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/services/flake_failure/run_swarming_util.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/services/test/isolate_test.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/services/constants.py
[add] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/dto/test/swarming_task_error_test.py
[modify] https://crrev.com/67b334eb51f357d92c7455d69363787cc571f600/appengine/findit/dto/swarming_task_error.py

Status: Fixed (was: Assigned)

Sign in to add a comment