[iOS] Voice Search: Add voice search button to omnibox. |
|||||||||||||||
Issue descriptionThis is part of the new mocks for the UI refresh: https://docs.google.com/document/d/1f8J7PnWQey70uLadJ8VgYr1tXUnx7IZXPTDqdBjH2cg/edit?usp=sharing
,
Mar 25 2018
,
Mar 25 2018
,
Mar 25 2018
,
Apr 11 2018
This design is no longer being used, as the share button will now be in the location bar.
,
Apr 20 2018
Assigning to Stepan, since he's implemented this in crrev.com/c/1021698.
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97b9f55d9cd0c36d6a159d76e8679245107823a8 commit 97b9f55d9cd0c36d6a159d76e8679245107823a8 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Mon Apr 23 17:22:59 2018 [iOS Refresh] Add voice search button to steady location bar. Adds a voice search button to the steady location bar. Bug: 825396 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f2a570ab09fb513586a3eb88f5fdcf9373d5c9b Reviewed-on: https://chromium-review.googlesource.com/1021698 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552740} [modify] https://crrev.com/97b9f55d9cd0c36d6a159d76e8679245107823a8/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/97b9f55d9cd0c36d6a159d76e8679245107823a8/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/97b9f55d9cd0c36d6a159d76e8679245107823a8/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [modify] https://crrev.com/97b9f55d9cd0c36d6a159d76e8679245107823a8/ios/chrome/browser/ui/location_bar/location_bar_view_controller.h [modify] https://crrev.com/97b9f55d9cd0c36d6a159d76e8679245107823a8/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cefdea7f011f068dd3313b83e31dbde7765087f commit 2cefdea7f011f068dd3313b83e31dbde7765087f Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Tue Apr 24 15:08:23 2018 [iOS] Update the voice search button guide to the omnibox trailing view. This CL updates the voice search button guide when being triggered from the omnibox voice search button. Bug: 825396 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia0aeb04340966bbdf96715af56dbc334152598d0 Reviewed-on: https://chromium-review.googlesource.com/1025570 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553113} [modify] https://crrev.com/2cefdea7f011f068dd3313b83e31dbde7765087f/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/2cefdea7f011f068dd3313b83e31dbde7765087f/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
,
Apr 26 2018
,
Jun 27 2018
,
Jun 27 2018
,
Jul 10
,
Jul 19
stk: Is this all done? If so, please update status.
,
Jul 19
This is done. Sorry for no updates, I lost track of this as it's marked MS-Voice-Search
,
Jul 25
,
Aug 23
Reopening Version: Chrome Canary 70.0.3531.0 Device: iPhone 8 iOS: 12.0 According to the bug, the mic icon should be seen in omnibox all the times but I am unable to see it. Could you please clarify how to reproduce this to see the mic icon in omnibox?
,
Aug 24
It can be seen in landscape and on iPad.
,
Aug 28
Issue verified Version: Chrome Canary 70.0.3535.0 Device: iPhone 8, iPad iOS: 11.4, 12.0 Mic shown on unfocus search box https://drive.google.com/open?id=1XG1btRenc5nDQi8MvwPokVV9VEhtQVH0 https://drive.google.com/open?id=1KzFzem46SX70HP4EYazZljBJRydvAJg7 https://drive.google.com/open?id=1XU8BqtHCs-KkUgRqM8vWbTMvSwWT1sZG |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, Mar 25 2018Labels: S-Voice-Search-From-Omnibox
Summary: [iOS] Voice Search: Add voice search button to omnibox. (was: [iOS} Voice Search: Add voice search button to omnibox.)