Tab switch button is dark during subsequent displays |
|||
Issue descriptionChrome Version: ToT OS: Linux What steps will reproduce the problem? (1) Enable tab switch button feature (feature=Button) (2) Open example.com (3) Open another tab, type example.com in Omnibox and click on tab switch button. (Should close this tab.) (4) Open another tab again, type example.com What is the expected result? Tab switch button should have a white background. What happens instead? Tab switch button has a dark "pressed" background and icon is missing (unless hovered). Just recording this behavior while I disappear for a week, so I don't forget, but more in case someone has a theory in the meantime. I've added print-outs all the way down the Background and everything looks good. I've tried resetting the background at mouse release. I've also tried tapted@s background()->SetNativeControlColor(). It seems like something further down the stack is hanging onto the color and our changes are getting masked out. Feel free to reply in case I can try something while away.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f7342bf40c9ad522e905d446218d5baf37c73ab commit 9f7342bf40c9ad522e905d446218d5baf37c73ab Author: Kevin Bailey <krb@chromium.org> Date: Tue Apr 03 21:20:30 2018 [omnibox] Recreating tab switch button on appropriate set match The tab switch button won't show background changes after being hidden and re-shown. This is to work-around that, by recreating it on each set match that needs it. (Creating it is needed if the match type is a tab switch and the tab switch button behavior was enabled.) This change also restores the strategy of not creating a tab switch button unless and until needed. Bug: 825372 Change-Id: I0b808969ee5e9b91e3ca292fa929447da148d75c Reviewed-on: https://chromium-review.googlesource.com/992356 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#547834} [modify] https://crrev.com/9f7342bf40c9ad522e905d446218d5baf37c73ab/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/9f7342bf40c9ad522e905d446218d5baf37c73ab/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc
,
Apr 4 2018
Tried checking the issue on chrome version 67.0.3387.0 and 67.0.3388.0 using Ubuntu 14.04 by following the below mentioned steps. 1. Enabled tab switch button feature in chrome://flags 2. Opened example.com 3. Opened another tab, typed example.com in Omnibox and clicked on tab switch button. 4. opened another tab and typed example.com. We observed similar behaviour on both the versions with respect to background color. attaching the screen shots of the same. @Kevin Bailey: Could you please have a look at those screen shots and let us know if anything missed. Please help us in verifying the fix. Thanks!
,
Apr 4 2018
Hi Vamshi, I don't see the tab switch button at all in your screenshots. But don't worry about it: I don't if you noticed that I'm both the reporter and owner. As I mentioned in the first comment, I wrote the bug so I wouldn't forget it over a break, and to ask for help. I've worked around the bug with the CL above. I'm going to close this, verified, but others are welcome to look into the strange behavior with this button type, or provide suggestions. |
|||
►
Sign in to add a comment |
|||
Comment 1 by k...@chromium.org
, Apr 2 2018