New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825362 link

Starred by 3 users

Issue metadata

Status: Closed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 821840
issue 838628
issue 845964
issue 847897

Blocking:
issue 759794



Sign in to add a comment

Implement recipe for building and running targets from "code coverage suite" on Chrome Infra

Project Member Reported by mmoroz@chromium.org, Mar 23 2018

Issue description

This can be split into two parts: tests and fuzz targets.

I think we should account for swarming from the beginning. Swarming bots should not only run individual targets, but also merge *.profraw dumps locally, so we will grab only *.profdata dump generated for a single target.
 

Comment 1 by mmoroz@chromium.org, Mar 23 2018

Cc: dpranke@chromium.org jbudorick@chromium.org
Components: Infra>Client>Chrome
Owner: liaoyuke@chromium.org
Status: Assigned (was: Untriaged)
Blockedon: 845964
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/b0cff7b9c2524f1d96fd4e72c651542898ebde16

commit b0cff7b9c2524f1d96fd4e72c651542898ebde16
Author: Yuke Liao <liaoyuke@google.com>
Date: Thu May 24 21:37:38 2018

Project Member

Comment 7 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6235c359c3fa20663ef9792ce7ca5174d9bec7e7

commit 6235c359c3fa20663ef9792ce7ca5174d9bec7e7
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue May 29 19:03:56 2018

Coverage: Add recipe for code coverage reports generation.

This CL implements the first parts of the code coverage reports
generation recipes: checks out Chromium code.

Bug:  825362 
Change-Id: Ie47f4192762ac8afa7b791085d41e14b54e103d3
Reviewed-on: https://chromium-review.googlesource.com/1073067
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/6235c359c3fa20663ef9792ce7ca5174d9bec7e7/scripts/slave/README.recipes.md
[add] https://crrev.com/6235c359c3fa20663ef9792ce7ca5174d9bec7e7/scripts/slave/recipes/chromium_clang_coverage_reports.expected/full_luci_chromium_ci_linux_code_coverage_generation.json
[add] https://crrev.com/6235c359c3fa20663ef9792ce7ca5174d9bec7e7/scripts/slave/recipes/chromium_clang_coverage_reports.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/391406340cb5144eb0a02335d035f7c47e9ae3bb

commit 391406340cb5144eb0a02335d035f7c47e9ae3bb
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue May 29 19:26:35 2018

Coverage: Add builders for code coverage generation on linux.

This CL adds a builder to chromium.fyi to generate code coverage
reports on linux platform.

Bug:  825362 
Change-Id: If3942d9a7b37da6db2d40bc0b04ad7ac89460deb
Reviewed-on: https://chromium-review.googlesource.com/1073071
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562544}
[modify] https://crrev.com/391406340cb5144eb0a02335d035f7c47e9ae3bb/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/391406340cb5144eb0a02335d035f7c47e9ae3bb/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/391406340cb5144eb0a02335d035f7c47e9ae3bb/infra/config/global/luci-scheduler.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/1abd08e0b29b01a695df1612e730411594904d4c

commit 1abd08e0b29b01a695df1612e730411594904d4c
Author: Yuke Liao <liaoyuke@google.com>
Date: Tue May 29 21:57:20 2018

Project Member

Comment 10 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/154bc40b56ae8b15c6eaa6ff32697823b402ae1b

commit 154bc40b56ae8b15c6eaa6ff32697823b402ae1b
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue May 29 23:05:21 2018

Coverage: Use coverage recipe on coverage bots.

This CL uses chromium_clang_coverage_report recipes on
linux-code-coverage-generation bot.

Bug:  825362 
Change-Id: Ia2e7d191944317929fd7db1a4a98bf125f93cd90
Reviewed-on: https://chromium-review.googlesource.com/1077528
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562643}
[modify] https://crrev.com/154bc40b56ae8b15c6eaa6ff32697823b402ae1b/infra/config/global/cr-buildbucket.cfg

Blockedon: 847897
Project Member

Comment 12 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a052e70d08d3b77ce5bd3db2e9b3bc4c91ad698f

commit a052e70d08d3b77ce5bd3db2e9b3bc4c91ad698f
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed May 30 16:44:23 2018

Coverage: use chromium.fyi as mastername in coverage report recipe.

According to the comments in:
https://chromium-review.googlesource.com/c/chromium/src/+/1077974

bucket name shouldn't be used as master name, so this CL changes the
recipe to use chromium.fyi as master name.

Bug:  825362 
Change-Id: I41d7cfb095afcb26b310be53bf949e52438c568f
Reviewed-on: https://chromium-review.googlesource.com/1079206
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/a052e70d08d3b77ce5bd3db2e9b3bc4c91ad698f/scripts/slave/recipes/chromium_clang_coverage_reports.py
[rename] https://crrev.com/a052e70d08d3b77ce5bd3db2e9b3bc4c91ad698f/scripts/slave/recipes/chromium_clang_coverage_reports.expected/full_chromium_fyi_linux_code_coverage_generation.json

Project Member

Comment 13 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9ada730eb14911456597aa7187ff24abf2ee785

commit b9ada730eb14911456597aa7187ff24abf2ee785
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed May 30 16:55:22 2018

Coverage: specify mastername for coverage builders.

The coverage builders are running into builders because mastername is
missing from the properties, this CL adds mastername = luci.chromium.ci
property to the linux coverage builder.

Bug:  825362 
Change-Id: Ie92f8e1803308aa19592f836e7cd4f6448f44ba9
Reviewed-on: https://chromium-review.googlesource.com/1077974
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562871}
[modify] https://crrev.com/b9ada730eb14911456597aa7187ff24abf2ee785/infra/config/global/cr-buildbucket.cfg

Blockedon: 838628
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2510981170faad7e099b71ac41e2f79d44ed5a73

commit 2510981170faad7e099b71ac41e2f79d44ed5a73
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jun 12 02:35:22 2018

Coverage: Add builder for code coverage generation on Mac

This CL adds a builder to chromium.fyi to generate code coverage
reports on Mac platform.

Bug:  825362 
Change-Id: I1ae53ceba643bb6e9b1891e16b83f676220a68db
Reviewed-on: https://chromium-review.googlesource.com/1095122
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566283}
[modify] https://crrev.com/2510981170faad7e099b71ac41e2f79d44ed5a73/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/2510981170faad7e099b71ac41e2f79d44ed5a73/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/2510981170faad7e099b71ac41e2f79d44ed5a73/infra/config/global/luci-scheduler.cfg

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/c81330f7944d8e23ba0b426cff05a9bf78e7468c

commit c81330f7944d8e23ba0b426cff05a9bf78e7468c
Author: Yuke Liao <liaoyuke@google.com>
Date: Tue Jun 12 21:49:20 2018

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e51ca155a3de3097f6869d1b21bf718440a00d0d

commit e51ca155a3de3097f6869d1b21bf718440a00d0d
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jun 12 22:10:52 2018

Coverage: Use post_process to test the recipe and drop the expectation

This CL changes the chromium_clang_coverage_reports recipe to use
post_process for testing and drop the expectation.

Bug:  847897 ,  825362 
Change-Id: I1abec36c8a6e8be2ed4c26187516572224a0f246
Reviewed-on: https://chromium-review.googlesource.com/1095115
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/e51ca155a3de3097f6869d1b21bf718440a00d0d/scripts/slave/README.recipes.md
[modify] https://crrev.com/e51ca155a3de3097f6869d1b21bf718440a00d0d/scripts/slave/recipes/chromium_clang_coverage_reports.py
[delete] https://crrev.com/98b92d03f5edb31cfbab045189970e8fafacc323/scripts/slave/recipes/chromium_clang_coverage_reports.expected/full_chromium_fyi_linux_code_coverage_generation.json

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c11ca62a96ad960411f3e0b8a4d455217e639a8c

commit c11ca62a96ad960411f3e0b8a4d455217e639a8c
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 14 00:20:47 2018

Coverage: Adapt recipe for mac code coverage generation builder

The mac-code-coverage-generation builder has been registered and added
to luci, and this CL modified the chromium_clang_coverage_reports
recipe according to accommodate it.

Bug:  825362 
Change-Id: Ib840306f6e99a35afeb5122a13c7b6d37c3173b3
Reviewed-on: https://chromium-review.googlesource.com/1097996
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/c11ca62a96ad960411f3e0b8a4d455217e639a8c/scripts/slave/recipes/chromium_clang_coverage_reports.py

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/906f7da4e94803292f88eed05701b3d5cf87a4f4

commit 906f7da4e94803292f88eed05701b3d5cf87a4f4
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 14 01:45:50 2018

Coverage: Change the cores of mac-code-coverage-generation from 8 to 24

I just realized luci.chromium.ci sets the default value of cores to 8,
however, the mac-code-coverage-generation builder has 24 cores:
https://chromium-swarm.appspot.com/bot?id=build227-m9

Bug:  825362 
Change-Id: If017fca1c47b798c2573f50d37e1a7823595181c
Reviewed-on: https://chromium-review.googlesource.com/1098645
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567084}
[modify] https://crrev.com/906f7da4e94803292f88eed05701b3d5cf87a4f4/infra/config/global/cr-buildbucket.cfg

Cc: benhenry@chromium.org estaab@chromium.org jchin...@chromium.org
Yuke, could you please share an update of the state of the recipes?

In the yesterday's project review we've agreed that migrating coverage bots to Chromium recipes should be the first step towards handing the project over to ChOps. It looks like you've already made a ton of progress here, which is awesome.
Thanks Max! Before I was out for two months, I had the hardware for Linux and Mac set up properly, they are up and running, and I also had a prototyping of the recipe for code coverage generation. The left work to do is to finish the recipe work and stabilize the pipelines. Given that I'm only doing 20%, my ETA would be by the end of this quarter, if that sgty.
Yuke, that sounds great to me. Thanks for the update!
Status: Closed (was: Started)
Roberto has taken over the migration and a redesign, so I'm closing this one to favor his work.

Sign in to add a comment