New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825360 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
(currently inactive on Chromium)
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR

Blocking:
issue 824187



Sign in to add a comment

permit accepting permissions while in WebVR presentation

Project Member Reported by vollick@chromium.org, Mar 23 2018

Issue description

When we need to accept a permission, we should transition to black and show the dialog and controller so the user can accept/deny.
 

Comment 1 by ymalik@chromium.org, Mar 26 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1f336aabb5a794bf2d631416683ec113fe09d9

commit 4c1f336aabb5a794bf2d631416683ec113fe09d9
Author: Yash Malik <ymalik@google.com>
Date: Wed Mar 28 01:13:03 2018

VR: Show permission prompt while in WebVR

In this CL, we duplicate the hosted ui subtree for WebVR so that the user can
accept permissions while in WebVR mode.

Bug:  825360 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic43116a4dc1c6cfe48076d8ba37b5912f8d09c74
Reviewed-on: https://chromium-review.googlesource.com/982605
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546352}
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/elements/ui_element_type.cc
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/elements/ui_element_type.h
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/model/web_vr_model.h
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/ui.cc
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/ui_scene_creator.h
[modify] https://crrev.com/4c1f336aabb5a794bf2d631416683ec113fe09d9/chrome/browser/vr/ui_unittest.cc

Comment 3 by ymalik@chromium.org, Mar 28 2018

Status: Fixed (was: Started)
Labels: Test-Complete
Status: Verified (was: Fixed)
Verified in build 67.0.3394.0 Canary build.
Components: Blink>WebXR

Sign in to add a comment