New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825356 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR

Blocking:
issue 824187



Sign in to add a comment

when entering webvr show permissions that may be used

Project Member Reported by vollick@chromium.org, Mar 23 2018

Issue description

even if not yet in use, we should indicate what permissions may be used by a site when entering WebVR presentation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dcea2667702a2304aa630471dbcd631e0b89bd3

commit 3dcea2667702a2304aa630471dbcd631e0b89bd3
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Mar 28 22:11:38 2018

[vr] Check for page permissions that may be used

In order for us to display indicators to users when a page
has permission to use a feature (but is not yet using it),
we need to poll as we do for in-use permissions.

Bug:  825356 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7ada19762a17d2428a9cea19f0d8e38e76dfe1c7
Reviewed-on: https://chromium-review.googlesource.com/982092
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546617}
[modify] https://crrev.com/3dcea2667702a2304aa630471dbcd631e0b89bd3/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/3dcea2667702a2304aa630471dbcd631e0b89bd3/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/3dcea2667702a2304aa630471dbcd631e0b89bd3/chrome/browser/vr/model/capturing_state_model.h
[modify] https://crrev.com/3dcea2667702a2304aa630471dbcd631e0b89bd3/chrome/browser/vr/testapp/vr_test_context.cc

Status: Fixed (was: Assigned)
Labels: Test-Complete
Status: Verified (was: Fixed)
Verified on build 67.0.3389.0  Looks good.
Tests have been added to the Manual Test Plans to cover this.
Components: Blink>WebXR

Sign in to add a comment