New issue
Advanced search Search tips

Issue 825349 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

[DevTols] queryObjects returns results

Project Member Reported by kozy@chromium.org, Mar 23 2018

Issue description

Chrome Version: ToT
OS: all

What steps will reproduce the problem?
(1) queryObjects(Foo);

What is the expected result?
returns array with all Foo objects

What happens instead?
returns undefined
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3f34a3f937e43368776d9c686b98302e6eeb698

commit d3f34a3f937e43368776d9c686b98302e6eeb698
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Mar 23 22:40:30 2018

[DevTools] prepare tests for new queryObjects

TBR=pfeldman@chromium.org

Bug:  chromium:825349 
Change-Id: I70390a29c684afa69555b14aa20b96345d5ce1e3
Reviewed-on: https://chromium-review.googlesource.com/978844
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545600}
[modify] https://crrev.com/d3f34a3f937e43368776d9c686b98302e6eeb698/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d3f34a3f937e43368776d9c686b98302e6eeb698/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-expected.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9732f422c76ac9f7043b2786fea289a208471a10

commit 9732f422c76ac9f7043b2786fea289a208471a10
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Mar 23 23:58:55 2018

[inspector] queryObjects returns result

queryObjects command line API return array instead of sending
inspectRequest notification.

R=pfeldman@chromium.org

Bug:  chromium:825349 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie6c64419cb108b313c43b66eab533c5a7d5d9024
Reviewed-on: https://chromium-review.googlesource.com/978464
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52197}
[modify] https://crrev.com/9732f422c76ac9f7043b2786fea289a208471a10/src/inspector/v8-console.cc
[modify] https://crrev.com/9732f422c76ac9f7043b2786fea289a208471a10/test/inspector/runtime/command-line-api-expected.txt
[modify] https://crrev.com/9732f422c76ac9f7043b2786fea289a208471a10/test/inspector/runtime/command-line-api.js

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/caf74f9c61d990af5f619686fa76ddfba5b3cbd1

commit caf74f9c61d990af5f619686fa76ddfba5b3cbd1
Author: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Mar 28 01:49:48 2018

Revert "[inspector] queryObjects returns result"

This reverts commit 9732f422c76ac9f7043b2786fea289a208471a10.

Reason for revert.

Original change's description:
> [inspector] queryObjects returns result
> 
> queryObjects command line API return array instead of sending
> inspectRequest notification.
> 
> R=​pfeldman@chromium.org
> 
> Bug:  chromium:825349 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ie6c64419cb108b313c43b66eab533c5a7d5d9024
> Reviewed-on: https://chromium-review.googlesource.com/978464
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52197}

TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:825349 
Change-Id: I90f93b96981d8218b9ad1dc0f4ebfb5a7cb671bc
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/982431
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52254}
[modify] https://crrev.com/caf74f9c61d990af5f619686fa76ddfba5b3cbd1/src/inspector/v8-console.cc
[modify] https://crrev.com/caf74f9c61d990af5f619686fa76ddfba5b3cbd1/test/inspector/runtime/command-line-api-expected.txt
[modify] https://crrev.com/caf74f9c61d990af5f619686fa76ddfba5b3cbd1/test/inspector/runtime/command-line-api.js

Comment 4 by kozy@chromium.org, Mar 30 2018

Status: WontFix (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a75122ea5922456b53a662e2beb15b419adea3c1

commit a75122ea5922456b53a662e2beb15b419adea3c1
Author: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Mar 30 02:18:48 2018

Revert "[DevTools] prepare tests for new queryObjects"

This reverts commit d3f34a3f937e43368776d9c686b98302e6eeb698.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [DevTools] prepare tests for new queryObjects
> 
> TBR=pfeldman@chromium.org
> 
> Bug:  chromium:825349 
> Change-Id: I70390a29c684afa69555b14aa20b96345d5ce1e3
> Reviewed-on: https://chromium-review.googlesource.com/978844
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545600}

TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:825349 
Change-Id: I21810896da315aea8179938f32e90a2512012252
Reviewed-on: https://chromium-review.googlesource.com/987332
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547074}
[modify] https://crrev.com/a75122ea5922456b53a662e2beb15b419adea3c1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a75122ea5922456b53a662e2beb15b419adea3c1/third_party/WebKit/LayoutTests/http/tests/devtools/console/command-line-api-expected.txt

Sign in to add a comment