New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 825347 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
OoO until Feb 4th
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue v8:7601



Sign in to add a comment

v8_enable_vtunejit flag not working as expected

Reported by rahulcha...@gmail.com, Mar 23 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce the problem:
1. Build chromium with v8_enable_vtunejit=true flag
2. 
3. 

What is the expected behavior?
Build successful

What went wrong?
ERROR at //v8/BUILD.gn:3082:15: Can't load input file.
    deps += [ "//src/third_party/vtune:v8_vtune" ]

Did this work before? N/A 

Chrome version: 65.0.3325.181  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 29.0 r0

Was looking for Javascript profiling in chrome using VTune.
 
Components: -Blink Infra>Client>V8 Build
Labels: -Pri-2 Pri-3
This is a V8 bug, not a Blink one. The way the code's written it looks like this is only expected to work with a standalone V8 build, but you should file a bug at https://bugs.chromium.org/p/v8 to be sure.
Labels: Triaged-ET TE-NeedsTriageHelp
The issue seems to be out of TE-scope as it is related to Build and V8. Hence, adding label TE-NeedsTriageHelp for further help in triaging this issue.

Thanks...!!
Labels: -TE-NeedsTriageHelp -Triaged-ET
Status: Available (was: Unconfirmed)
It's supported in v8 standalone. I don't know if there's support in Chrome. I'd defer to Intel for a good answer.

Debugging a bit:
https://cs.chromium.org/chromium/src/v8/BUILD.gn?q=vtune:v8_vtune&sq=package:chromium&l=3082
can't really work in Chrome, since the // refers to the project base, which is different when embedded. Does it work for you if you just remove the //? Then it is a relative dependency. Feel free to make a CL with that change.
Thank you. I've opened a v8 bug as suggested. 
If I just remove '//' it doesn't work, and has more dependency issues like:

ERROR Unresolved dependencies.
//v8/src/third_party/vtune:v8_vtune(//build/toolchain/win:win_clang_x64)
  needs //:v8(//build/toolchain/win:win_clang_x64)

Needed to look at JITed code profile, f12 profiler tool seems the way to go then?
I think the dependencies within vtune might be wrong, too. They should all be relative and not use the // anywhere. In standalone mode, v8 is in // but in chromium, v8 is in //v8/. So all dependency paths must be relative.
I sent https://chromium-review.googlesource.com/c/v8/v8/+/980557 yesterday, it should take care of that.
CL, lg. If there's another v8-side bug, could you please link it to this one?
Blockedon: v8:7601
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/41aad4bcc05f900ef5407378698a6385507fa8bf

commit 41aad4bcc05f900ef5407378698a6385507fa8bf
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Wed Mar 28 09:36:35 2018

[build] Do not use absolute paths in v8_enable_vtunejit-related blocks.

This prevents the flag from being set from e.g. Chromium. Instead, just use
relative paths like everything else in the build system.

Bug: chromium:825347,  v8:7601 

Change-Id: I080d9999b0b63bafc2c1978f70322eb48814a3b8
Reviewed-on: https://chromium-review.googlesource.com/980557
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52263}
[modify] https://crrev.com/41aad4bcc05f900ef5407378698a6385507fa8bf/BUILD.gn
[modify] https://crrev.com/41aad4bcc05f900ef5407378698a6385507fa8bf/src/third_party/vtune/BUILD.gn

> If there's another v8-side bug, could you please link it to this one?

I've marked  bug v8:7601  as blocking this one (it's the same report but filed against V8).

The commit (once there's a V8 roll) above should allow one to set v8_enable_vtunejit=true from Chromium. I don't know if it makes any difference or if something needs to be done on the Blink/Chromium side for things to work smoothly though.
Labels: -OS-Windows
Owner: raphael....@intel.com
Status: Assigned (was: Available)
Raphael, since you authored the CL, I am assigning this to you so it goes out of our V8 infra triage queue. Please re-assign if this is incorrect.

Sign in to add a comment