Restrict abilities of MessageLoop::current() (and ultimately remove it) |
||
Issue descriptionMessageLoop::current() currently returns a MessageLoop* which enables callers to reach into the internals of base. It also makes replacing base::MessageLoop on a thread a pain because the codebase assumes there is a physical MessageLoop instance. More generic APIs are now ready to take the load (ThreadTaskRunnerHandle, RunLoop, SequenceLocalStorage, FileDescriptorWatcher, etc.) but going through the deprecation phase is hard with MessageLoop::current() constantly lurking. A big swath was made by fdoray@ in issue 650723 but some APIs remain and, moreover, access not being protected means calls that are meant to be for the instance owner only are springing back up post clean up (need a compiler ban or devs will keep writing code they're used to). My plan: - Carve out a separate MessageLoopCurrent interface to be returned from MessageLoop::current() which isn't a full blown MessageLoop. - Highlight everything that is deprecated and its replacement. - From that position it will be possible to make APIs strict to MessageLoop's owner without risking exposing them on MessageLoop::current(). This is a tracker bug, all CLs in this area should be tagged with it.
Showing comments 67 - 166
of 166
Older ›
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a94fe046e576242e35c90994f136b37eab76b8f2 commit a94fe046e576242e35c90994f136b37eab76b8f2 Author: Gabriel Charette <gab@chromium.org> Date: Mon Apr 23 23:39:31 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /net/cookies These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 825327 Change-Id: Ifaba7bb17406a913293c2ba918334d28da4cbc3c Reviewed-on: https://chromium-review.googlesource.com/1024790 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#552902} [modify] https://crrev.com/a94fe046e576242e35c90994f136b37eab76b8f2/net/cookies/cookie_store_unittest.h
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02f1ffc4cf81a6ff16e325ce02a77ef79b3ccb11 commit 02f1ffc4cf81a6ff16e325ce02a77ef79b3ccb11 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 00:33:55 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/subresource_filter These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=battre@chromium.org Bug: 825327 Change-Id: I09f2ec144a8cd311d705ad3cfe3ac6da75cc4ca8 Reviewed-on: https://chromium-review.googlesource.com/1024319 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#552925} [modify] https://crrev.com/02f1ffc4cf81a6ff16e325ce02a77ef79b3ccb11/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc [modify] https://crrev.com/02f1ffc4cf81a6ff16e325ce02a77ef79b3ccb11/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc [modify] https://crrev.com/02f1ffc4cf81a6ff16e325ce02a77ef79b3ccb11/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/02f1ffc4cf81a6ff16e325ce02a77ef79b3ccb11/components/subresource_filter/content/renderer/web_document_subresource_filter_impl.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e678c5514223b3b49d3a9c2b4b80dbf573fde31 commit 7e678c5514223b3b49d3a9c2b4b80dbf573fde31 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 06:13:32 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/test/chromedriver These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=stgao@chromium.org Bug: 825327 Change-Id: Id0af6c00456644d29aa8553a9bafab0a2d92bb4f Reviewed-on: https://chromium-review.googlesource.com/1024479 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553016} [modify] https://crrev.com/7e678c5514223b3b49d3a9c2b4b80dbf573fde31/chrome/test/chromedriver/commands.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/876ce2e89ca990479e67d045054174d7dea4c3d6 commit 876ce2e89ca990479e67d045054174d7dea4c3d6 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 06:38:12 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chromeos/login These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=alemate@chromium.org Bug: 825327 Change-Id: I94fa0384312871ab8e645ad3174f5e380e32a77d Reviewed-on: https://chromium-review.googlesource.com/1024287 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#553019} [modify] https://crrev.com/876ce2e89ca990479e67d045054174d7dea4c3d6/chrome/browser/chromeos/login/saml/saml_offline_signin_limiter_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf03e96fe6ff1aab55b91d1e98331cf5c2d21ed1 commit cf03e96fe6ff1aab55b91d1e98331cf5c2d21ed1 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 07:41:36 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/policy These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=pmarko@chromium.org Bug: 825327 Change-Id: I78406e5535645c6a03c283fe2e22a9f801e7efdd Reviewed-on: https://chromium-review.googlesource.com/1024447 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553025} [modify] https://crrev.com/cf03e96fe6ff1aab55b91d1e98331cf5c2d21ed1/components/policy/core/common/mock_configuration_policy_provider.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbb7d2fb0afd72595f0802a8ea2eb12770325e5e commit bbb7d2fb0afd72595f0802a8ea2eb12770325e5e Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 07:58:06 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/policy These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 825327 Change-Id: Id0fda433bb3e714fb4de1d7d1dfb9d8f429515a7 Reviewed-on: https://chromium-review.googlesource.com/1024313 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#553026} [modify] https://crrev.com/bbb7d2fb0afd72595f0802a8ea2eb12770325e5e/chrome/browser/policy/policy_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6117f22f454a09451cadccf1ca626bf76dcb9446 commit 6117f22f454a09451cadccf1ca626bf76dcb9446 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 08:01:58 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chromeos/policy These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=pastarmovj@chromium.org Bug: 825327 Change-Id: I4c8a61d564fa2c7c87ad95a334267a1715bb7563 Reviewed-on: https://chromium-review.googlesource.com/1024661 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#553027} [modify] https://crrev.com/6117f22f454a09451cadccf1ca626bf76dcb9446/chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc [modify] https://crrev.com/6117f22f454a09451cadccf1ca626bf76dcb9446/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e72ee32220b85cebb2a36329000f93e75c9dfed1 commit e72ee32220b85cebb2a36329000f93e75c9dfed1 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 12:20:34 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/prefs These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=bauerb@chromium.org Bug: 825327 Change-Id: I87bfe63cc53b805a916de25b360c6db5be350358 Reviewed-on: https://chromium-review.googlesource.com/1024507 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553055} [modify] https://crrev.com/e72ee32220b85cebb2a36329000f93e75c9dfed1/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6498ea6ddf487385680aebffd0d0329c0b366ccc commit 6498ea6ddf487385680aebffd0d0329c0b366ccc Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 12:21:25 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chrome_browser_main_android.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=bauerb@chromium.org Bug: 825327 Change-Id: Ia10a44445d3e9b765511fda5e1135afc0d32a338 Reviewed-on: https://chromium-review.googlesource.com/1024710 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#553056} [modify] https://crrev.com/6498ea6ddf487385680aebffd0d0329c0b366ccc/chrome/browser/chrome_browser_main_android.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba97da2d101d7570141b3fe16d34c24cd98df5bb commit ba97da2d101d7570141b3fe16d34c24cd98df5bb Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 13:05:53 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/browser_watcher These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=manzagop@chromium.org Bug: 825327 Change-Id: I6fb6356e6c0b8dded0c990bca7c15012d757405d Reviewed-on: https://chromium-review.googlesource.com/1024390 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553065} [modify] https://crrev.com/ba97da2d101d7570141b3fe16d34c24cd98df5bb/components/browser_watcher/window_hang_monitor_win_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43d908832e9b048f4c667a37efd849c9425219b9 commit 43d908832e9b048f4c667a37efd849c9425219b9 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 13:45:07 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chromecast/media These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=kmackay@chromium.org Bug: 825327 Change-Id: Ic2d81d1bc53eac58a69f323c8ef4820defc8af93 Reviewed-on: https://chromium-review.googlesource.com/1024473 Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553073} [modify] https://crrev.com/43d908832e9b048f4c667a37efd849c9425219b9/chromecast/media/cma/backend/alsa/alsa_volume_control.cc [modify] https://crrev.com/43d908832e9b048f4c667a37efd849c9425219b9/chromecast/media/cma/base/balanced_media_task_runner_unittest.cc [modify] https://crrev.com/43d908832e9b048f4c667a37efd849c9425219b9/chromecast/media/cma/base/buffering_frame_provider_unittest.cc [modify] https://crrev.com/43d908832e9b048f4c667a37efd849c9425219b9/chromecast/media/cma/base/demuxer_stream_adapter_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dacb46542d9005c2007169a8a19f5034e9412d4 commit 1dacb46542d9005c2007169a8a19f5034e9412d4 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 13:45:37 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/extensions/api/settings_private These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 825327 Change-Id: Ib40cfbf453b9a9f5926ea92e7711b3732b365021 Reviewed-on: https://chromium-review.googlesource.com/1024372 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553074} [modify] https://crrev.com/1dacb46542d9005c2007169a8a19f5034e9412d4/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e889470b103d5bf0e4ee28b8d200c39d1a818c0a commit e889470b103d5bf0e4ee28b8d200c39d1a818c0a Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 13:47:17 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chromeos/dbus These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 825327 Change-Id: I0c0e770c71f5b7082cb5aa15fe12108f1fea861f Reviewed-on: https://chromium-review.googlesource.com/1024441 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553077} [modify] https://crrev.com/e889470b103d5bf0e4ee28b8d200c39d1a818c0a/chromeos/dbus/services/service_provider_test_helper.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f592431c9b9eae51fcd179e3a8036f2f3e3410ac commit f592431c9b9eae51fcd179e3a8036f2f3e3410ac Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 13:47:53 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/crash These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 825327 Change-Id: I1b445eb50f48bfd9e52cc13458f936b251fdd47f Reviewed-on: https://chromium-review.googlesource.com/1024373 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553078} [modify] https://crrev.com/f592431c9b9eae51fcd179e3a8036f2f3e3410ac/components/crash/content/browser/crash_handler_host_linux.cc [modify] https://crrev.com/f592431c9b9eae51fcd179e3a8036f2f3e3410ac/components/crash/content/browser/crash_handler_host_linux.h
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be49153bc9f9364e495571583e21e4f354ca2d7e commit be49153bc9f9364e495571583e21e4f354ca2d7e Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 13:49:11 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ui/events/ozone These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=kpschoedel@chromium.org Bug: 825327 Change-Id: Ie381e306bf1ea665a24180ac51c881a220875f3b Reviewed-on: https://chromium-review.googlesource.com/1024471 Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553080} [modify] https://crrev.com/be49153bc9f9364e495571583e21e4f354ca2d7e/ui/events/ozone/device/udev/device_manager_udev.cc [modify] https://crrev.com/be49153bc9f9364e495571583e21e4f354ca2d7e/ui/events/ozone/evdev/event_converter_evdev.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e236324ddc19b7eb2c4a40a0a66014d11a491d93 commit e236324ddc19b7eb2c4a40a0a66014d11a491d93 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 13:49:29 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /services/service_manager These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: I0da1a35816b422a01b88ae1dac4b2f4c400e8aee Reviewed-on: https://chromium-review.googlesource.com/1024285 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553081} [modify] https://crrev.com/e236324ddc19b7eb2c4a40a0a66014d11a491d93/services/service_manager/public/cpp/standalone_service/standalone_service.cc [modify] https://crrev.com/e236324ddc19b7eb2c4a40a0a66014d11a491d93/services/service_manager/tests/service_manager/service_manager_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79805a381181211732387e28b7994bf4808c4739 commit 79805a381181211732387e28b7994bf4808c4739 Author: Pavol Marko <pmarko@chromium.org> Date: Tue Apr 24 13:59:51 2018 Use MessageLoopCurrent::IsSet in /components/policy As stated in message_loop_current.h, |MessageLoopCurrent::IsSet()| should be preferred to checking the return value of |MessageLoopCurrent::Get()|. Bug: 825327 Change-Id: I90bf74dd9929eeb946e8e2e3ee1ac2e9f093a938 Reviewed-on: https://chromium-review.googlesource.com/1025770 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553086} [modify] https://crrev.com/79805a381181211732387e28b7994bf4808c4739/components/policy/core/common/mock_configuration_policy_provider.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/105432621c9c1da597d7e55542007cd28f53d8df commit 105432621c9c1da597d7e55542007cd28f53d8df Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 14:11:13 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ios/web/public/test These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 825327 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibb41d632874e6c54c87755eee78a306f8be1fb0f Reviewed-on: https://chromium-review.googlesource.com/1024766 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553090} [modify] https://crrev.com/105432621c9c1da597d7e55542007cd28f53d8df/ios/web/public/test/web_test_with_web_state.mm
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83e2a87df159cc84834072eab8538a0c3d41be75 commit 83e2a87df159cc84834072eab8538a0c3d41be75 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 14:33:57 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/printing These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=dpapad@chromium.org Bug: 825327 Change-Id: Ib44e36143c5fb3bcb2aa2d84c994a6d3dff1a74c Reviewed-on: https://chromium-review.googlesource.com/1024432 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553096} [modify] https://crrev.com/83e2a87df159cc84834072eab8538a0c3d41be75/chrome/browser/printing/print_job_worker.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf516c7a65bcc7d8fe68536ebce17efdc9917dfc commit cf516c7a65bcc7d8fe68536ebce17efdc9917dfc Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:06:13 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/resource_coordinator These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 825327 Change-Id: I0d98633558525902e6ab91c21ec03e505817ce4f Reviewed-on: https://chromium-review.googlesource.com/1024755 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553109} [modify] https://crrev.com/cf516c7a65bcc7d8fe68536ebce17efdc9917dfc/chrome/browser/resource_coordinator/tab_manager_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0252e22e5a318e8f0c71d41a50a5c74d8671f65 commit d0252e22e5a318e8f0c71d41a50a5c74d8671f65 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:07:17 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chromeos/binder These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=hashimoto@chromium.org Bug: 825327 Change-Id: Ifa839d59418b7a637c228a337b49bbbc811ed494 Reviewed-on: https://chromium-review.googlesource.com/1024251 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553111} [modify] https://crrev.com/d0252e22e5a318e8f0c71d41a50a5c74d8671f65/chromeos/binder/ipc_thread.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a57477f3aa2c33a7de1611b4820ec6b308f3e3d commit 3a57477f3aa2c33a7de1611b4820ec6b308f3e3d Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:07:56 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/common/service_manager These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rockot@chromium.org Bug: 825327 Change-Id: I17d3542e3e7b2e1f6f53c52a7f985a64bf2d076c Reviewed-on: https://chromium-review.googlesource.com/1024713 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553112} [modify] https://crrev.com/3a57477f3aa2c33a7de1611b4820ec6b308f3e3d/content/common/service_manager/service_manager_connection_impl.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2004f4bc6193b1115f1fff051c983f881c6fd2bd commit 2004f4bc6193b1115f1fff051c983f881c6fd2bd Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:12:02 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ui/message_center These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=yoshiki@chromium.org Bug: 825327 Change-Id: I7b0019ea81c06367e407c92196fb55bd57504250 Reviewed-on: https://chromium-review.googlesource.com/1024759 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553118} [modify] https://crrev.com/2004f4bc6193b1115f1fff051c983f881c6fd2bd/ui/message_center/message_center_impl_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/507e59c342db6c5d0fb0ab591c4672e9047e3c8f commit 507e59c342db6c5d0fb0ab591c4672e9047e3c8f Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:18:39 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /base/threading These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=jam@chromium.org Bug: 825327 Change-Id: I1ad5896d82d6b03cff3a481e6898b054157c1ab4 Reviewed-on: https://chromium-review.googlesource.com/1024659 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553123} [modify] https://crrev.com/507e59c342db6c5d0fb0ab591c4672e9047e3c8f/base/threading/thread.h [modify] https://crrev.com/507e59c342db6c5d0fb0ab591c4672e9047e3c8f/base/threading/thread_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9ae07e704e1644ee0313476f6ed466d02573faf commit d9ae07e704e1644ee0313476f6ed466d02573faf Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:26:36 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/timers These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=derat@chromium.org Bug: 825327 Change-Id: I5cc912669a0733a1ac7b89942042c2957ba022f7 Reviewed-on: https://chromium-review.googlesource.com/1024391 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#553127} [modify] https://crrev.com/d9ae07e704e1644ee0313476f6ed466d02573faf/components/timers/alarm_timer_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d628c9477017aa77541fb766ba371f071e67e5a9 commit d628c9477017aa77541fb766ba371f071e67e5a9 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:28:58 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/public/test/test_browser_thread.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: I01cd1c312062bf618b74d65587d13843ba316a93 Reviewed-on: https://chromium-review.googlesource.com/1024765 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553130} [modify] https://crrev.com/d628c9477017aa77541fb766ba371f071e67e5a9/content/public/test/test_browser_thread.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d947b8c37118a64a4fac3930b9c52a90435c2f62 commit d947b8c37118a64a4fac3930b9c52a90435c2f62 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:31:37 2018 Remove usage of MessageLoop in /net/proxy_resolution Patch set 1 was a scripted change but it turned out to be wrong because it was assigning into a MessageLoop* variable. ThreadCheckerImpl and ThreadTaskRunnerHandle are better suited for what the MessageLoop* was used for. As such, its usage was removed entirely in patch set 3. R=mmenke@chromium.org Bug: 825327 Change-Id: I619c27f15c7c51e7f4211398eefaa2b5475681f1 Reviewed-on: https://chromium-review.googlesource.com/1024314 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#553132} [modify] https://crrev.com/d947b8c37118a64a4fac3930b9c52a90435c2f62/net/proxy_resolution/multi_threaded_proxy_resolver_unittest.cc [modify] https://crrev.com/d947b8c37118a64a4fac3930b9c52a90435c2f62/net/proxy_resolution/proxy_config_service_android_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/926fb1a6143034cd4ad50c57b7870d59c1503107 commit 926fb1a6143034cd4ad50c57b7870d59c1503107 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:33:39 2018 Remove MessageLoop::current() in /components/sync Changes in patch set 1 were scripted as part of the effort to restrict exposure of the raw MessageLoop*. In the latest patch set I manually cleaned it up further to get rid of raw MessageLoop* and deprecated MessageLoop::QuitWhenIdleClosure() usage altogether. This CL was uploaded by git cl split (initially). R=mastiz@chromium.org Bug: 825327 Change-Id: Ide7ce6794797611d47cebf7a1d448f0a464ac295 Reviewed-on: https://chromium-review.googlesource.com/1024442 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553134} [modify] https://crrev.com/926fb1a6143034cd4ad50c57b7870d59c1503107/components/sync/engine/net/http_bridge_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/989f91f7f3a497679d059ac1af795886e001565b commit 989f91f7f3a497679d059ac1af795886e001565b Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 15:59:10 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/ssl These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rsleevi@chromium.org Bug: 825327 Change-Id: I145bea58989dc37d67a2d37ce4b14581363ac647 Reviewed-on: https://chromium-review.googlesource.com/1024474 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553142} [modify] https://crrev.com/989f91f7f3a497679d059ac1af795886e001565b/chrome/browser/ssl/ssl_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/882011c4133601dc640a241eb739ae34864c8a5f commit 882011c4133601dc640a241eb739ae34864c8a5f Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 16:17:09 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chromeos/arc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=lhchavez@chromium.org Bug: 825327 Change-Id: I40de071dcef2e6356ce03a851a36e85722b4f00a Reviewed-on: https://chromium-review.googlesource.com/1024317 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#553154} [modify] https://crrev.com/882011c4133601dc640a241eb739ae34864c8a5f/chrome/browser/chromeos/arc/icon_decode_request.h [modify] https://crrev.com/882011c4133601dc640a241eb739ae34864c8a5f/chrome/browser/chromeos/arc/user_session/arc_user_session_service_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d70cc3c35858c713a21339dd754535bc1aa3e95f commit d70cc3c35858c713a21339dd754535bc1aa3e95f Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 17:00:44 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /media/audio These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=olka@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I296b69513d2205d1cba2d75d6a89891ec60a5b38 Reviewed-on: https://chromium-review.googlesource.com/1024249 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553166} [modify] https://crrev.com/d70cc3c35858c713a21339dd754535bc1aa3e95f/media/audio/alive_checker.cc [modify] https://crrev.com/d70cc3c35858c713a21339dd754535bc1aa3e95f/media/audio/audio_input_device.h [modify] https://crrev.com/d70cc3c35858c713a21339dd754535bc1aa3e95f/media/audio/audio_output_device.h [modify] https://crrev.com/d70cc3c35858c713a21339dd754535bc1aa3e95f/media/audio/scoped_task_runner_observer.cc [modify] https://crrev.com/d70cc3c35858c713a21339dd754535bc1aa3e95f/media/audio/scoped_task_runner_observer.h
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d493f21106da2a51325e1e9efc0e0f1215285974 commit d493f21106da2a51325e1e9efc0e0f1215285974 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 18:21:37 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/safe_browsing These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=vakh@chromium.org Bug: 825327 Change-Id: Ic8c07068f4f567da6191716241a39fb3a68e6647 Reviewed-on: https://chromium-review.googlesource.com/1024318 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553206} [modify] https://crrev.com/d493f21106da2a51325e1e9efc0e0f1215285974/components/safe_browsing/db/v4_local_database_manager_unittest.cc [modify] https://crrev.com/d493f21106da2a51325e1e9efc0e0f1215285974/components/safe_browsing/db/whitelist_checker_client_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8dc59eef0f5ca02f5e95e9394b69d0ea357dfb9 commit a8dc59eef0f5ca02f5e95e9394b69d0ea357dfb9 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 21:00:19 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/ui/webui/sync_internals_ui_unittest.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=pavely@chromium.org Bug: 825327 Change-Id: Ic0b91000c8cd7fb5a08d97cf374d2fec8453038e Reviewed-on: https://chromium-review.googlesource.com/1024396 Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553272} [modify] https://crrev.com/a8dc59eef0f5ca02f5e95e9394b69d0ea357dfb9/chrome/browser/ui/webui/sync_internals_ui_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d79c145d8f65a8bdf9c128bf7e01e7b3337c349a commit d79c145d8f65a8bdf9c128bf7e01e7b3337c349a Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 21:03:30 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ipc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=tsepez@chromium.org Bug: 825327 Change-Id: I23484e311db823f08ac571bf34411f960cd8fb3e Reviewed-on: https://chromium-review.googlesource.com/1024316 Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553274} [modify] https://crrev.com/d79c145d8f65a8bdf9c128bf7e01e7b3337c349a/ipc/ipc_mojo_perftest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc5a1d2a6dfcb012b97dda3ed5026452d928efe8 commit dc5a1d2a6dfcb012b97dda3ed5026452d928efe8 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 21:33:42 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /net/spdy These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rch@chromium.org Bug: 825327 Change-Id: I683a3fc7b20d41d4d069fb9e7fd0b4cdcf915028 Reviewed-on: https://chromium-review.googlesource.com/1024494 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553285} [modify] https://crrev.com/dc5a1d2a6dfcb012b97dda3ed5026452d928efe8/net/spdy/chromium/spdy_session_test_util.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ceba6362e17571ac33de89ce7aa42948f3968c2e commit ceba6362e17571ac33de89ce7aa42948f3968c2e Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 21:39:48 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /device These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rockot@chromium.org Bug: 825327 Change-Id: If17acb98d53b8a6a352a0c09699ddb60915393d0 Reviewed-on: https://chromium-review.googlesource.com/1024808 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553292} [modify] https://crrev.com/ceba6362e17571ac33de89ce7aa42948f3968c2e/device/serial/serial_io_handler_win.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aec08d445e7c0ad3d409e046341115aa0706be04 commit aec08d445e7c0ad3d409e046341115aa0706be04 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 21:40:31 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /remoting These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 825327 Change-Id: Ic3627d36d9e562b112766c1d597351caae7c0718 Reviewed-on: https://chromium-review.googlesource.com/1024284 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553293} [modify] https://crrev.com/aec08d445e7c0ad3d409e046341115aa0706be04/remoting/base/auto_thread.h [modify] https://crrev.com/aec08d445e7c0ad3d409e046341115aa0706be04/remoting/client/chromoting_client_runtime.cc [modify] https://crrev.com/aec08d445e7c0ad3d409e046341115aa0706be04/remoting/host/win/wts_session_process_delegate.cc [modify] https://crrev.com/aec08d445e7c0ad3d409e046341115aa0706be04/remoting/test/access_token_fetcher_unittest.cc [modify] https://crrev.com/aec08d445e7c0ad3d409e046341115aa0706be04/remoting/test/app_remoting_test_driver_environment.cc [modify] https://crrev.com/aec08d445e7c0ad3d409e046341115aa0706be04/remoting/test/chromoting_test_driver_environment.cc [modify] https://crrev.com/aec08d445e7c0ad3d409e046341115aa0706be04/remoting/test/test_video_renderer_unittest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9580e9da424ce2f9275f22f33fd26535a32cf7c commit d9580e9da424ce2f9275f22f33fd26535a32cf7c Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 21:58:13 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ui/ozone These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=alexst@chromium.org Bug: 825327 Change-Id: I4a356b3e6ba95ac0e6e500225ca6576519416623 Reviewed-on: https://chromium-review.googlesource.com/1024761 Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#553302} [modify] https://crrev.com/d9580e9da424ce2f9275f22f33fd26535a32cf7c/ui/ozone/platform/wayland/wayland_connection.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6b93644cde969414fce700c7c7d1814f8db624b commit a6b93644cde969414fce700c7c7d1814f8db624b Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 22:01:34 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/renderer These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 825327 Change-Id: Ifc815fd5b8c80c62144137d5a1bdf4c6d8444f85 Reviewed-on: https://chromium-review.googlesource.com/1024438 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553306} [modify] https://crrev.com/a6b93644cde969414fce700c7c7d1814f8db624b/content/renderer/visual_state_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb7239ef3ef1af7bcaf651c1978744e8226ef0c1 commit bb7239ef3ef1af7bcaf651c1978744e8226ef0c1 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 22:03:20 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/public/test These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: I26056af155629353a7a8e0fccf38fc3d2308ecd9 Reviewed-on: https://chromium-review.googlesource.com/1024792 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553307} [modify] https://crrev.com/bb7239ef3ef1af7bcaf651c1978744e8226ef0c1/content/public/test/test_renderer_host.cc [modify] https://crrev.com/bb7239ef3ef1af7bcaf651c1978744e8226ef0c1/content/public/test/test_utils.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19f256be7c9a64e3c40cf8c7e2333d638febde0d commit 19f256be7c9a64e3c40cf8c7e2333d638febde0d Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 22:04:24 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /net/cert These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=eroman@chromium.org Bug: 825327 Change-Id: I981a208163dbff6560debcbdcd2dfb70f64ef717 Reviewed-on: https://chromium-review.googlesource.com/1024406 Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553308} [modify] https://crrev.com/19f256be7c9a64e3c40cf8c7e2333d638febde0d/net/cert/cert_database_mac.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/354a57517c9b58f54e5d2dfd768b640e4178be87 commit 354a57517c9b58f54e5d2dfd768b640e4178be87 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 22:06:42 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/browser/download These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 825327 Change-Id: I6dcd9290b2c6021b914375e8f7fb03065f6299ce Reviewed-on: https://chromium-review.googlesource.com/1024871 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553309} [modify] https://crrev.com/354a57517c9b58f54e5d2dfd768b640e4178be87/content/browser/download/download_browsertest.cc [modify] https://crrev.com/354a57517c9b58f54e5d2dfd768b640e4178be87/content/browser/download/drag_download_file_browsertest.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2baf9059898ca4ba7202e54ac44b72e76114940 commit e2baf9059898ca4ba7202e54ac44b72e76114940 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 22:38:12 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /third_party/blink/renderer/platform/scheduler These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 825327 Change-Id: Ic6d3ecfe4aed463c921eee5c1d13f5be2210e38a Reviewed-on: https://chromium-review.googlesource.com/1024435 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553328} [modify] https://crrev.com/e2baf9059898ca4ba7202e54ac44b72e76114940/third_party/blink/renderer/platform/scheduler/base/task_queue_manager.h
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd2bf5f6f21a4ec78ea9a4210017a00898beddb4 commit fd2bf5f6f21a4ec78ea9a4210017a00898beddb4 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 23:05:23 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=jochen@chromium.org Bug: 825327 Change-Id: I95578c8c278000044d7a16c797f8317f562cc51a Reviewed-on: https://chromium-review.googlesource.com/1024632 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553335} [modify] https://crrev.com/fd2bf5f6f21a4ec78ea9a4210017a00898beddb4/chrome/common/service_process_util_posix.cc [modify] https://crrev.com/fd2bf5f6f21a4ec78ea9a4210017a00898beddb4/chrome/renderer/url_loader_throttle_provider_impl.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400 commit 1e5bed44662eaa70e7e72e25c10f46c3c6dc9400 Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 23:25:49 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /net These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=juliatuttle@chromium.org Bug: 825327 Change-Id: Iddd6fb67987e98cbc4fa6a4b09167124e1f31388 Reviewed-on: https://chromium-review.googlesource.com/1024470 Reviewed-by: Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553356} [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/base/address_tracker_linux.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/base/file_stream_context_win.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/base/network_change_notifier_linux.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/base/network_config_watcher_mac.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/dns/notify_watcher_mac.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/dns/serial_worker_unittest.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/socket/socket_posix.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/socket/udp_socket_posix.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/test/embedded_test_server/embedded_test_server.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/tools/gdig/gdig.cc [modify] https://crrev.com/1e5bed44662eaa70e7e72e25c10f46c3c6dc9400/net/url_request/url_request_filter.cc
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d70e6a0512489842fc604f371338a53c354bfbdc commit d70e6a0512489842fc604f371338a53c354bfbdc Author: Gabriel Charette <gab@chromium.org> Date: Tue Apr 24 23:33:33 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/renderer/media/webrtc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sergeyu@chromium.org Bug: 825327 Change-Id: Ic3521abdd745c1c048dfd9828232eb0e6c351fc2 Reviewed-on: https://chromium-review.googlesource.com/1024760 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553362} [modify] https://crrev.com/d70e6a0512489842fc604f371338a53c354bfbdc/content/renderer/media/webrtc/peer_connection_dependency_factory.cc [modify] https://crrev.com/d70e6a0512489842fc604f371338a53c354bfbdc/content/renderer/media/webrtc/peer_connection_dependency_factory.h
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/152262c65ba2ad36950742613130d002d1dbe162 commit 152262c65ba2ad36950742613130d002d1dbe162 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 03:30:39 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/download These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 825327 Change-Id: I74a210d1851a7f98217ee43c83bad9c369740f0a Reviewed-on: https://chromium-review.googlesource.com/1024762 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553440} [modify] https://crrev.com/152262c65ba2ad36950742613130d002d1dbe162/components/download/internal/common/download_file_impl.cc [modify] https://crrev.com/152262c65ba2ad36950742613130d002d1dbe162/components/download/internal/common/download_file_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6135f5cb806f922eda7154c827585691bdd2dd8 commit f6135f5cb806f922eda7154c827585691bdd2dd8 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 04:05:52 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /base/trace_event These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=ssid@chromium.org Bug: 825327 Change-Id: I69f4952b57c7693c441abe1a6173f453aa10e7e6 Reviewed-on: https://chromium-review.googlesource.com/1024288 Reviewed-by: Siddhartha S <ssid@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553446} [modify] https://crrev.com/f6135f5cb806f922eda7154c827585691bdd2dd8/base/trace_event/trace_log.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c commit 32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 05:10:24 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /mojo These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=sky@chromium.org Bug: 825327 Change-Id: Ieae521d62d35bae3cd5c54309796f2b0c702679c Reviewed-on: https://chromium-review.googlesource.com/1024378 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553454} [modify] https://crrev.com/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c/mojo/edk/system/broker_host.cc [modify] https://crrev.com/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c/mojo/edk/system/broker_host.h [modify] https://crrev.com/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c/mojo/edk/system/channel_posix.cc [modify] https://crrev.com/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c/mojo/edk/system/channel_win.cc [modify] https://crrev.com/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c/mojo/edk/system/node_controller.cc [modify] https://crrev.com/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c/mojo/public/cpp/bindings/lib/connector.cc [modify] https://crrev.com/32044bca2d8effbc75a2bf2cfa98a49aaebdbd8c/mojo/public/cpp/bindings/tests/e2e_perftest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d3f7a83d2c22dfd64471ecc4a821e2581bee665 commit 8d3f7a83d2c22dfd64471ecc4a821e2581bee665 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 13:44:19 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /third_party/blink/renderer/platform These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=mkwst@chromium.org Bug: 825327 Change-Id: Ic19845b885a4527fbdf5acb2e41a4b75153a1998 Reviewed-on: https://chromium-review.googlesource.com/1024395 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553532} [modify] https://crrev.com/8d3f7a83d2c22dfd64471ecc4a821e2581bee665/third_party/blink/renderer/platform/mojo/DEPS [modify] https://crrev.com/8d3f7a83d2c22dfd64471ecc4a821e2581bee665/third_party/blink/renderer/platform/mojo/mojo_helper.h
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbede16b9c5b36400ca9e6b0e0a6d974d3eef1f0 commit bbede16b9c5b36400ca9e6b0e0a6d974d3eef1f0 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 14:04:37 2018 Cleanup MessageLoop::current() usage /content/child Changes in patch set 1 were scripted as part of the effort to restrict exposure of the raw MessageLoop*. I've manually cleaned it up in the latest patch set to remove usage of MessageLoop* another level. This CL was uploaded by git cl split (initially). R=haraken@chromium.org TBR=piman@chromium.org (naming side-effect in ppapi_plugin/) Bug: 825327 Change-Id: Id2c1dcb68c7a8fccafa5e0eee86fb5db82939a2f Reviewed-on: https://chromium-review.googlesource.com/1024654 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553539} [modify] https://crrev.com/bbede16b9c5b36400ca9e6b0e0a6d974d3eef1f0/content/child/child_process.cc [modify] https://crrev.com/bbede16b9c5b36400ca9e6b0e0a6d974d3eef1f0/content/child/child_thread_impl.cc [modify] https://crrev.com/bbede16b9c5b36400ca9e6b0e0a6d974d3eef1f0/content/child/child_thread_impl.h [modify] https://crrev.com/bbede16b9c5b36400ca9e6b0e0a6d974d3eef1f0/content/ppapi_plugin/ppapi_thread.cc [modify] https://crrev.com/bbede16b9c5b36400ca9e6b0e0a6d974d3eef1f0/content/renderer/render_thread_impl.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02089626a2c677e398fa48796cca4ff6229f90d7 commit 02089626a2c677e398fa48796cca4ff6229f90d7 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 15:20:45 2018 Include single_thread_task_runner.h in MessageLoopCurrent since API takes it by value TBR=fdoray@chromium.org Bug: 825327 Change-Id: Iead1c89cfc21458e828db8d3b560643dcd088b08 Reviewed-on: https://chromium-review.googlesource.com/1027793 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553562} [modify] https://crrev.com/02089626a2c677e398fa48796cca4ff6229f90d7/base/message_loop/message_loop_current.h
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad2b0436f9da965bd72e1d88d3d612516f2623c9 commit ad2b0436f9da965bd72e1d88d3d612516f2623c9 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 16:14:47 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chromeos/attestation These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=mnissler@chromium.org Bug: 825327 Change-Id: If841fcb08116a6b73fe0af84c94dd4f17ac9c290 Reviewed-on: https://chromium-review.googlesource.com/1024492 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#553593} [modify] https://crrev.com/ad2b0436f9da965bd72e1d88d3d612516f2623c9/chromeos/attestation/attestation_flow.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48ec838d89ce1767b8cee7acbf108508292ce1c3 commit 48ec838d89ce1767b8cee7acbf108508292ce1c3 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:07:53 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ash/wallpaper These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=xdai@chromium.org Bug: 825327 Change-Id: I25abbbca04c9753f602fa6c9d654f797aecd13bb Reviewed-on: https://chromium-review.googlesource.com/1024294 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553602} [modify] https://crrev.com/48ec838d89ce1767b8cee7acbf108508292ce1c3/ash/wallpaper/wallpaper_controller_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c1a8668d84866ae54ecc046f19583a6fc66a7aa commit 2c1a8668d84866ae54ecc046f19583a6fc66a7aa Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:19:12 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chromecast These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=slan@chromium.org Bug: 825327 Change-Id: I01b6eb1a65d3989f830b34c989ec5a8bbf0ffe41 Reviewed-on: https://chromium-review.googlesource.com/1024530 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Stephen Lanham <slan@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553622} [modify] https://crrev.com/2c1a8668d84866ae54ecc046f19583a6fc66a7aa/chromecast/browser/cast_browser_main_parts.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37272e4cd90b6c06f4541c7caa69ab1b59fa19b4 commit 37272e4cd90b6c06f4541c7caa69ab1b59fa19b4 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:38:03 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/browser/renderer_host/media/video_capture_unittest.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=mcasas@chromium.org Bug: 825327 Change-Id: I2a142815884495810e2e4b1b9df911a70827e076 Reviewed-on: https://chromium-review.googlesource.com/1024475 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553630} [modify] https://crrev.com/37272e4cd90b6c06f4541c7caa69ab1b59fa19b4/content/browser/renderer_host/media/video_capture_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24e8289b9f10f48cac51a0d86b0a26806c37629f commit 24e8289b9f10f48cac51a0d86b0a26806c37629f Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:45:39 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/extensions These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=benwells@chromium.org Bug: 825327 Change-Id: I18dfde173f4dec69a3ab5040a0f62e1e09005fce Reviewed-on: https://chromium-review.googlesource.com/1024394 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553633} [modify] https://crrev.com/24e8289b9f10f48cac51a0d86b0a26806c37629f/chrome/browser/extensions/favicon_downloader.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d52d19a14f5c97465b0c1249193ff131605c4928 commit d52d19a14f5c97465b0c1249193ff131605c4928 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:46:47 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ui/app_list These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=khmel@chromium.org Bug: 825327 Change-Id: I47c48130ebfde9f3fbb8834439a83f419d1faff7 Reviewed-on: https://chromium-review.googlesource.com/1024803 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553634} [modify] https://crrev.com/d52d19a14f5c97465b0c1249193ff131605c4928/ui/app_list/demo/app_list_demo_views.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cecb363d5c50094ce4eabc6cef5a482facfe6f90 commit cecb363d5c50094ce4eabc6cef5a482facfe6f90 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:53:30 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/app_controller_mac_browsertest.mm These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=thakis@chromium.org Bug: 825327 Change-Id: I6aa4991f252ab4079f061f967d142a827c0a7c52 Reviewed-on: https://chromium-review.googlesource.com/1024801 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553638} [modify] https://crrev.com/cecb363d5c50094ce4eabc6cef5a482facfe6f90/chrome/browser/app_controller_mac_browsertest.mm
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5177019d66419b82b496f72f695b9dfb09a9848c commit 5177019d66419b82b496f72f695b9dfb09a9848c Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:54:44 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/extensions/api/downloads These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=benjhayden@chromium.org Bug: 825327 Change-Id: I0ab6cebfc8184be74824fcfdb45b220808c049d3 Reviewed-on: https://chromium-review.googlesource.com/1024374 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553641} [modify] https://crrev.com/5177019d66419b82b496f72f695b9dfb09a9848c/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1545075cd6add82a04aea12a3f5fde30be568095 commit 1545075cd6add82a04aea12a3f5fde30be568095 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:55:40 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chromecast/tracing These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=spang@chromium.org Bug: 825327 Change-Id: I8c5b885a9ceb8069ff004254848b47d5b6fd55d0 Reviewed-on: https://chromium-review.googlesource.com/1024393 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553642} [modify] https://crrev.com/1545075cd6add82a04aea12a3f5fde30be568095/chromecast/tracing/tracing_service_main.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9592d4ed72498e9e6ce90d01ee19a2e116c17638 commit 9592d4ed72498e9e6ce90d01ee19a2e116c17638 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:56:55 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /services/ui These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=ben@chromium.org Bug: 825327 Change-Id: Iff0e9fcf49b0a61b24cbd992b0503365f879a40c Reviewed-on: https://chromium-review.googlesource.com/1024752 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553644} [modify] https://crrev.com/9592d4ed72498e9e6ce90d01ee19a2e116c17638/services/ui/ws/test_utils.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6cc6adc6261be08869595b85ff4672521e3f1b2 commit d6cc6adc6261be08869595b85ff4672521e3f1b2 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:58:01 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/wifi These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=mef@chromium.org Bug: 825327 Change-Id: I2dc4e772428c81ac04ee0be710b65ce8b8d897d5 Reviewed-on: https://chromium-review.googlesource.com/1024476 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553646} [modify] https://crrev.com/d6cc6adc6261be08869595b85ff4672521e3f1b2/components/wifi/wifi_test.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21ff80483b000614faf98d72f4bf47dd89f3337b commit 21ff80483b000614faf98d72f4bf47dd89f3337b Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:59:03 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/spellcheck These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=groby@chromium.org Bug: 825327 Change-Id: I7b103879e33e4c71534ca16b1270949ceb70ce9b Reviewed-on: https://chromium-review.googlesource.com/1024657 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553647} [modify] https://crrev.com/21ff80483b000614faf98d72f4bf47dd89f3337b/components/spellcheck/renderer/spellcheck_provider_test.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92fe7d117fa2ef36ec015a4dab40a0dd8949171e commit 92fe7d117fa2ef36ec015a4dab40a0dd8949171e Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 17:59:59 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /media These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=wolenetz@chromium.org Bug: 825327 Change-Id: I7b560649fba9f86c99d259101bc7abc2434f294d Reviewed-on: https://chromium-review.googlesource.com/1024794 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553648} [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/base/bind_to_current_loop_unittest.cc [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/base/user_input_monitor_linux.cc [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/base/user_input_monitor_win.cc [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/blink/video_decode_stats_reporter_unittest.cc [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/blink/watch_time_reporter_unittest.cc [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/device_monitors/device_monitor_udev.cc [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/device_monitors/device_monitor_udev.h [modify] https://crrev.com/92fe7d117fa2ef36ec015a4dab40a0dd8949171e/media/renderers/video_renderer_impl_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7af3897ba86d15766a88f581498fc53702defb29 commit 7af3897ba86d15766a88f581498fc53702defb29 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 18:02:29 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/renderer/media/stream/media_stream_audio_processor_unittest.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=aluebs@chromium.org Bug: 825327 Change-Id: I9f324105a770fa05c8a0c621eaf21a58664d5447 Reviewed-on: https://chromium-review.googlesource.com/1024796 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553651} [modify] https://crrev.com/7af3897ba86d15766a88f581498fc53702defb29/content/renderer/media/stream/media_stream_audio_processor_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6009a71489a91ecaad95ece0e6e347518230329 commit d6009a71489a91ecaad95ece0e6e347518230329 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 18:06:56 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=bartfab@chromium.org Bug: 825327 Change-Id: I989f21cb92c8cabe876d054e56bdbe03f0b6f0d6 Reviewed-on: https://chromium-review.googlesource.com/1024767 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553654} [modify] https://crrev.com/d6009a71489a91ecaad95ece0e6e347518230329/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/328703247d1246229097ecc24c295d63ce272e51 commit 328703247d1246229097ecc24c295d63ce272e51 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 18:07:29 2018 Migrate MessageLoop::current() to MessageLoopCurrent in test_browser_thread_bundle.cc The scripted change in patch set 1 was incorrect as it didn't consider that TestBrowserThread's constructor is receiving a MessageLoop*. Thankfully, as of recent changes to BrowserThreadImpl/TestBrowserThread this is no longer necessary. Update TestBrowserThread to not require a MessageLoop* and use this to get rid of direct MessageLoop usage in TestBrowserThreadBundle altogether :) This CL was uploaded by git cl split (originally). R=tommi@chromium.org Bug: 825327 Change-Id: I6e529c7a2547bcfa7ae3ee9b017da91f3d068514 Reviewed-on: https://chromium-review.googlesource.com/1024433 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#553655} [modify] https://crrev.com/328703247d1246229097ecc24c295d63ce272e51/base/test/scoped_task_environment.cc [modify] https://crrev.com/328703247d1246229097ecc24c295d63ce272e51/base/test/scoped_task_environment.h [modify] https://crrev.com/328703247d1246229097ecc24c295d63ce272e51/content/public/test/test_browser_thread.cc [modify] https://crrev.com/328703247d1246229097ecc24c295d63ce272e51/content/public/test/test_browser_thread.h [modify] https://crrev.com/328703247d1246229097ecc24c295d63ce272e51/content/public/test/test_browser_thread_bundle.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb23fc7a3faeef3b1df52b60b669186d703abbd4 commit bb23fc7a3faeef3b1df52b60b669186d703abbd4 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 18:09:32 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /components/dom_distiller These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=wychen@chromium.org Bug: 825327 Change-Id: I54dafd02e4631007e7ea15efff66e91f68063a3b Reviewed-on: https://chromium-review.googlesource.com/1024656 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553656} [modify] https://crrev.com/bb23fc7a3faeef3b1df52b60b669186d703abbd4/components/dom_distiller/core/distiller_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e8b57edd86f63b2d6b0c1dce5743a0cdf777f3b commit 5e8b57edd86f63b2d6b0c1dce5743a0cdf777f3b Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 18:32:22 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ui/ozone/platform/drm These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=dnicoara@chromium.org Bug: 825327 Change-Id: I2d0a66205586d87c27d7ba8b87a7d4f4416f1728 Reviewed-on: https://chromium-review.googlesource.com/1024446 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553671} [modify] https://crrev.com/5e8b57edd86f63b2d6b0c1dce5743a0cdf777f3b/ui/ozone/platform/drm/gpu/drm_device.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd3491a524f846649fb511aa2c314f7fff072c97 commit cd3491a524f846649fb511aa2c314f7fff072c97 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 19:40:24 2018 Remove MessageLoop::current() usage in /content/browser/devtools Replacing it with modern RunLoop+QuitClosure usage. R=caseq@chromium.org Bug: 825327 Change-Id: I43e021d3a3c5e76923e77c8d28560931dc3ee866 Reviewed-on: https://chromium-review.googlesource.com/1024445 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553699} [modify] https://crrev.com/cd3491a524f846649fb511aa2c314f7fff072c97/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b13c9d1ed92b83809cfc685d70367ada1bce937b commit b13c9d1ed92b83809cfc685d70367ada1bce937b Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 20:10:34 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /services/network These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=kinuko@chromium.org Bug: 825327 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie66f2b93d069fae255bd65750a27e2aeef819ffd Reviewed-on: https://chromium-review.googlesource.com/1024652 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553710} [modify] https://crrev.com/b13c9d1ed92b83809cfc685d70367ada1bce937b/services/network/network_context.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6b8adf928dca10f18c610dd87efea1dd5c80112 commit a6b8adf928dca10f18c610dd87efea1dd5c80112 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 20:11:12 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ui/views These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=msw@chromium.org Bug: 825327 Change-Id: I508ddefd5a91415253e907811a17b7d11c818a12 Reviewed-on: https://chromium-review.googlesource.com/1024712 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#553711} [modify] https://crrev.com/a6b8adf928dca10f18c610dd87efea1dd5c80112/ui/views/controls/slider.cc [modify] https://crrev.com/a6b8adf928dca10f18c610dd87efea1dd5c80112/ui/views/test/scoped_views_test_helper.h
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbefa1ef232589305ef3dd00f12a15c87abfd705 commit fbefa1ef232589305ef3dd00f12a15c87abfd705 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 20:50:55 2018 Cleanup unused MessageLoopForIO decls in //net R=eroman@chromium.org Bug: 825327 Change-Id: I34f97a20ce9d7e3f61ae58bba839d2a7d490ddcd Reviewed-on: https://chromium-review.googlesource.com/1002657 Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553733} [modify] https://crrev.com/fbefa1ef232589305ef3dd00f12a15c87abfd705/chrome/browser/net/dns_probe_runner_unittest.cc [modify] https://crrev.com/fbefa1ef232589305ef3dd00f12a15c87abfd705/chrome/browser/net/dns_probe_service_unittest.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cc6c4364ba3feff8965333a11b951adca23b5d3 commit 7cc6c4364ba3feff8965333a11b951adca23b5d3 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 20:52:02 2018 [PRESUBMIT] Do not warn on Thread/SequenceCheckerImpl usage. Thread/SequenceCheckerImpl is the right type for tests that went to verify threading correctness (even when compiled in non-dcheck builds). This presubmit was only aimed at plain Thread/SequenceChecker usage. R=dpranke@chromium.org Bug: 825327 Change-Id: I04ed1351728c84a60acee9fe9103e16405992015 Reviewed-on: https://chromium-review.googlesource.com/1028352 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553735} [modify] https://crrev.com/7cc6c4364ba3feff8965333a11b951adca23b5d3/PRESUBMIT.py
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74b0a58281b54826cfcb9af6853c9109e0049f89 commit 74b0a58281b54826cfcb9af6853c9109e0049f89 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 21:23:10 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ui/events These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=sadrul@chromium.org Bug: 825327 Change-Id: Id090f93a7156fcef4c60defd5fb6bc2682e732af Reviewed-on: https://chromium-review.googlesource.com/1024650 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#553753} [modify] https://crrev.com/74b0a58281b54826cfcb9af6853c9109e0049f89/ui/events/platform/x11/x11_event_source_libevent.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99dbfa6d622e2f88d97739cd979837c8f2e46866 commit 99dbfa6d622e2f88d97739cd979837c8f2e46866 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 21:42:39 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/apps/app_shim These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=dominickn@chromium.org Bug: 825327 Change-Id: I5c912f4262563d87f0043f3a8eff0e7792751256 Reviewed-on: https://chromium-review.googlesource.com/1024431 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553760} [modify] https://crrev.com/99dbfa6d622e2f88d97739cd979837c8f2e46866/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bb3c64173f2679a4f15602d68e539295f4be187 commit 5bb3c64173f2679a4f15602d68e539295f4be187 Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 22:28:05 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /gin These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=jochen@chromium.org Bug: 825327 Change-Id: I2900d3ff9c29bb0044ec7d7d8351f5369522a0df Reviewed-on: https://chromium-review.googlesource.com/1024653 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553795} [modify] https://crrev.com/5bb3c64173f2679a4f15602d68e539295f4be187/gin/isolate_holder.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e672d1d76a120fec8e05ef490806ae416d9680db commit e672d1d76a120fec8e05ef490806ae416d9680db Author: Gabriel Charette <gab@chromium.org> Date: Wed Apr 25 23:03:38 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /content/browser/renderer_host/media These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=hubbe@chromium.org Bug: 825327 Change-Id: Ifccb0682900e0015ef59bed96592d03275217e24 Reviewed-on: https://chromium-review.googlesource.com/1024663 Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553804} [modify] https://crrev.com/e672d1d76a120fec8e05ef490806ae416d9680db/content/browser/renderer_host/media/media_stream_manager.cc [modify] https://crrev.com/e672d1d76a120fec8e05ef490806ae416d9680db/content/browser/renderer_host/media/media_stream_manager.h [modify] https://crrev.com/e672d1d76a120fec8e05ef490806ae416d9680db/content/browser/renderer_host/media/media_stream_manager_unittest.cc
,
Apr 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb6928930fc1fb8e29aebc6dd24af31367719bfb commit cb6928930fc1fb8e29aebc6dd24af31367719bfb Author: Gabriel Charette <gab@chromium.org> Date: Thu Apr 26 00:37:56 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /ios/web These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 825327 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic89cc4297947534db6418c8c1b65f18a9528c71f Reviewed-on: https://chromium-review.googlesource.com/1024872 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#553851} [modify] https://crrev.com/cb6928930fc1fb8e29aebc6dd24af31367719bfb/ios/web/public/app/web_main_parts.h [modify] https://crrev.com/cb6928930fc1fb8e29aebc6dd24af31367719bfb/ios/web/public/global_state/ios_global_state.mm [modify] https://crrev.com/cb6928930fc1fb8e29aebc6dd24af31367719bfb/ios/web/service_manager_connection_impl.cc [modify] https://crrev.com/cb6928930fc1fb8e29aebc6dd24af31367719bfb/ios/web/webui/url_fetcher_block_adapter_unittest.mm
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4 commit bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4 Author: Gabriel Charette <gab@chromium.org> Date: Fri Apr 27 19:55:25 2018 [MessageLoopCurrent] Remove unused redundant ScopedNestableTaskAllower constructor Following https://chromium-review.googlesource.com/c/chromium/src/+/1020288 TBR=nick@chromium.org (trivial rename in comment in content/public/test/frame_load_waiter.h) Bug: 825327 Change-Id: I5ef7bc522a74fd9c783183ce2baca87ea3fc3291 Reviewed-on: https://chromium-review.googlesource.com/1020804 Reviewed-by: Nick Carter <nick@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554467} [modify] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/base/message_loop/message_loop.h [modify] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/base/message_loop/message_loop_current.cc [modify] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/base/message_loop/message_loop_current.h [modify] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/components/gcm_driver/gcm_driver_desktop_unittest.cc [modify] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/content/public/test/frame_load_waiter.h [modify] https://crrev.com/bfad9ffe79b1b4f01d39a89ae2d8cb096c70d8a4/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5eeeb7196150ff00c5dede0cd8a5fc40a0f7409 commit f5eeeb7196150ff00c5dede0cd8a5fc40a0f7409 Author: Gabriel Charette <gab@chromium.org> Date: Fri Apr 27 21:34:43 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /chrome/browser/printing/cloud_print Patch set 1 changes were initially scripted as part of the effort to restrict exposure of the raw MessageLoop*. Further manual cleanup was done after identifying that MockLaunchd itself didn't need the full power of a MessageLoop*. Please CQ if LGTY This CL was uploaded by git cl split (initially). Bug: 825327 Change-Id: I6c250e0b44c27df6792fe0fbdad4a78608a98441 Reviewed-on: https://chromium-review.googlesource.com/1024453 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#554516} [modify] https://crrev.com/f5eeeb7196150ff00c5dede0cd8a5fc40a0f7409/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/f5eeeb7196150ff00c5dede0cd8a5fc40a0f7409/chrome/common/mac/mock_launchd.cc [modify] https://crrev.com/f5eeeb7196150ff00c5dede0cd8a5fc40a0f7409/chrome/common/mac/mock_launchd.h [modify] https://crrev.com/f5eeeb7196150ff00c5dede0cd8a5fc40a0f7409/chrome/common/service_process_util_mac_unittest.mm
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/810f3f43028e7b7458042a263042bad9d655d268 commit 810f3f43028e7b7458042a263042bad9d655d268 Author: Gabriel Charette <gab@chromium.org> Date: Fri Apr 27 22:28:14 2018 Migrate MessageLoop::current() to MessageLoopCurrent in /base These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=mark@chromium.org Bug: 825327 Change-Id: I5266e83a811ad85b43bebf1cecebd73b744d3ec3 Reviewed-on: https://chromium-review.googlesource.com/1024491 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554533} [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/files/file_descriptor_watcher_posix.cc [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/message_loop/message_loop.h [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/message_loop/message_loop_current.h [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/message_loop/message_loop_io_posix_unittest.cc [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/message_loop/message_loop_unittest.cc [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/message_loop/message_pump_glib_unittest.cc [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/test/power_monitor_test_base.cc [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/test/scoped_mock_time_message_loop_task_runner.cc [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/test/scoped_mock_time_message_loop_task_runner.h [modify] https://crrev.com/810f3f43028e7b7458042a263042bad9d655d268/base/test/scoped_mock_time_message_loop_task_runner_unittest.cc
,
Apr 30 2018
Here's a script to cleanup unused message_loop.h includes (and re-add missing ones). Fix() is invoked for all files in the codebase, on the matching .h before .cc when applicable (so if it's removed in .h but needed in .cc, it will be added back there). There were 631 unused message_loop.h includes identified by this script out of 1858 https://cs.chromium.org/search/?q=message_loop%5C.h&p=185&sq=package:chromium&type=cs)
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/697593400db4d3ee5806d85c1a35f13a1cd8d10c commit 697593400db4d3ee5806d85c1a35f13a1cd8d10c Author: Gabriel Charette <gab@chromium.org> Date: Mon Apr 30 21:23:40 2018 Remove MessageLoop::current() usage in /content/browser/browser_thread_unittest.cc (and modernize usage of RunLoop) Bug: 825327 Change-Id: I4a453384ea9f9735824c1259bd82c590571ff038 Reviewed-on: https://chromium-review.googlesource.com/1024798 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554880} [modify] https://crrev.com/697593400db4d3ee5806d85c1a35f13a1cd8d10c/content/browser/browser_thread_unittest.cc
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1452023fc22f9fb0c84ab579d7141a423fa6e98b commit 1452023fc22f9fb0c84ab579d7141a423fa6e98b Author: Gabriel Charette <gab@chromium.org> Date: Mon Apr 30 23:27:22 2018 [MessageLoop] Fix IWYU for (SingleThread|Sequenced)TaskRunner Precursor to land https://chromium-review.googlesource.com/c/chromium/src/+/1035788 Scripted used @ https://crbug.com/825327#c152 R=fdoray@chromium.org TBR=jam@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I5a356e8004b633283a0615a73bb52ed703d97965 Reviewed-on: https://chromium-review.googlesource.com/1035807 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554924} [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/layers/heads_up_display_layer_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/layers/texture_layer.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/layers/texture_layer_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/raster/one_copy_raster_buffer_provider.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/raster/staging_buffer_pool.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/resources/resource_pool.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/test/layer_tree_pixel_resource_test.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/test/pixel_test.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/trees/layer_tree_frame_sink.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/cc/trees/layer_tree_frame_sink_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/android/oom_intervention/near_oom_monitor.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/android/oom_intervention/near_oom_monitor_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/background/background_mode_manager_aura.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/background/background_mode_manager_chromeos.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/background/background_mode_manager_mac.mm [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/background/background_mode_manager_win.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/chrome_service.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/chromeos/assistant/platform_audio_input_host.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/chromeos/customization/customization_wallpaper_util.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/chromeos/power/ml/idle_event_notifier.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/component_updater/optimization_hints_component_installer_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/conflicts/enumerate_input_method_editors_win.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/conflicts/module_inspector_win.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/download/download_service_factory.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/extensions/external_registry_loader_win.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/feedback/feedback_uploader_chrome.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/media/media_engagement_contents_observer.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/password_manager/native_backend_kwallet_x.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/password_manager/native_backend_libsecret.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/password_manager/password_store_x.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/password_manager/password_store_x_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/predictors/autocomplete_action_predictor_table.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/predictors/predictor_database_factory.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/predictors/resource_prefetch_predictor_tables.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/prefs/profile_pref_store_manager.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/safe_browsing/download_protection/download_feedback_service_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/safe_browsing/download_protection/two_phase_uploader_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/themes/custom_theme_supplier.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/browser/vr/assets_loader.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chrome/common/conflicts/module_watcher_win.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromecast/browser/metrics/external_metrics.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromecast/device/bluetooth/le/gatt_client_manager_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromecast/device/bluetooth/le/le_scan_manager_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromecast/device/bluetooth/le/le_scan_manager_impl_test.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromecast/media/audio/cast_audio_manager.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromecast/media/audio/cast_audio_manager_alsa.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromecast/media/cma/backend/stream_mixer.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromeos/process_proxy/process_proxy_registry.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromeos/services/assistant/service.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/chromeos/services/device_sync/device_sync_service_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/data_reduction_proxy/core/browser/network_properties_manager_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/domain_reliability/service_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/download/content/factory/download_service_factory.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/download/downloader/in_progress/in_progress_cache_impl_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/download/internal/background_service/in_memory_download_driver.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/download/internal/common/download_task_runner.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/nacl/browser/pnacl_host.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/net_log/net_export_file_writer.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/offline_pages/core/offline_page_archiver_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/offline_pages/core/prefetch/store/prefetch_store.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/password_manager/core/browser/mock_password_store.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/password_manager/core/browser/test_password_store.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/payments/core/test_payment_request_delegate.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/policy/core/common/cloud/machine_level_user_cloud_policy_manager_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/policy/core/common/cloud/machine_level_user_cloud_policy_store.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/safe_browsing/db/v4_local_database_manager.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/safe_browsing/db/v4_local_database_manager_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/safe_browsing/triggers/ad_sampler_trigger.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/safe_browsing/triggers/suspicious_site_trigger.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/services/heap_profiling/public/cpp/client.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/services/leveldb/leveldb_service_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/storage_monitor/storage_monitor_chromeos.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/update_client/component_unpacker_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/update_client/url_request_post_interceptor.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/client/client_layer_tree_frame_sink.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/host/host_frame_sink_manager.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/service/display/display.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/service/display/gl_renderer_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/service/display_embedder/software_output_surface.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/service/frame_sinks/direct_layer_tree_frame_sink.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/service/frame_sinks/frame_sink_manager_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/service/frame_sinks/video_detector.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/viz/service/main/viz_main_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/components/webcrypto/webcrypto_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/appcache/appcache_service_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/appcache/appcache_storage_impl_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/compositor/in_process_display_client.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/devtools/devtools_stream_file.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/dom_storage/session_storage_context_mojo.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/dom_storage/session_storage_leveldb_wrapper_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/download/download_utils.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/hyphenation/hyphenation_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/loader/temporary_file_stream.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/media/android/media_resource_getter_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/renderer_host/media/media_stream_manager.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/browser/renderer_host/pepper/pepper_file_io_host.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/common/associated_interface_provider_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/common/possibly_associated_interface_ptr.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/public/test/test_download_http_response.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/android/synchronous_layer_tree_frame_sink.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/categorized_worker_pool.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/fetchers/resource_fetcher_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/indexed_db/indexed_db_database_callbacks_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/indexed_db/webidbcursor_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/input/widget_input_handler_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/input/widget_input_handler_manager.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/loader/sync_load_context.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/loader/tracked_child_url_loader_factory_bundle.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/loader/web_data_consumer_handle_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/audio_input_ipc_factory.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/mojo_audio_output_ipc.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/render_media_log.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/stream/apply_constraints_processor.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/stream/user_media_client_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/webrtc/rtc_certificate_generator.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/webrtc/rtc_rtp_receiver.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/webrtc/rtc_rtp_sender.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media/webrtc/webrtc_media_stream_adapter.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media_recorder/h264_encoder.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media_recorder/media_recorder_handler.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media_recorder/vea_encoder.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/media_recorder/vpx_encoder.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/mojo/blink_interface_registry_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/notifications/notification_dispatcher.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/render_thread_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/render_view_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/render_widget.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/service_worker/embedded_worker_instance_client_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/service_worker/service_worker_message_filter.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/service_worker/service_worker_network_provider.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/renderer/worker_thread_message_filter.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/content/test/layouttest_support.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/device/bluetooth/bluetooth_adapter_mac.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/device/bluetooth/bluetooth_device_win.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/extensions/browser/api/lock_screen_data/data_item_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/gin/per_isolate_data.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/gpu/command_buffer/service/scheduler.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/headless/public/util/throttled_dispatcher.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/chrome/browser/application_context_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/chrome/browser/services/gcm/ios_chrome_gcm_profile_service_factory.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/chrome/browser/share_extension/share_extension_item_receiver.mm [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/components/io_thread/ios_io_thread.mm [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/net/cookies/cookie_store_ios_test_util.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ios/web_view/internal/ios_global_state_web_view_configuration.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ipc/ipc_mojo_bootstrap.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/ipc/ipc_sync_channel.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/audio/alive_checker.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/audio/alive_checker_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/audio/mock_audio_debug_recording_manager.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/base/android/media_codec_loop_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/base/user_input_monitor.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/blink/video_decode_stats_reporter.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/blink/video_decode_stats_reporter_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/blink/watch_time_reporter.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/blink/watch_time_reporter_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/capture/video/chromeos/camera_device_delegate.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/capture/video/chromeos/camera_hal_delegate.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/capture/video/chromeos/camera_hal_dispatcher_impl_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/capture/video/chromeos/stream_buffer_manager.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/capture/video/chromeos/video_capture_device_chromeos_halv3.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/capture/video/chromeos/video_capture_device_factory_chromeos.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/device_monitors/device_monitor_mac.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/android/avda_codec_allocator.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/android/codec_image_group_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/android/fake_codec_allocator.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/android/video_frame_factory_impl.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/gpu_jpeg_decode_accelerator_factory.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/gpu_jpeg_encode_accelerator_factory.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/ipc/service/vda_video_decoder_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/windows/d3d11_video_decoder.h [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/gpu/windows/d3d11_video_decoder_unittest.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/mojo/clients/mojo_jpeg_decode_accelerator.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/media/mojo/test/mojo_video_decoder_integration_test.cc [modify] https://crrev.com/1452023fc22f9fb0c84ab579d7141a423fa6e98b/mojo/public/cpp/bindings/lib/associated_binding.cc [modify] https://crrev.com/14
,
May 1 2018
Actually, here's a slightly better script than #151 used to fix up message_loop.h includes (this one doesn't remove the include even if only a MessageLoop* is used, avoids introducing IWYU errors, doesn't bother replacing includes with fwd-decls where it could).
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a92b7636ee62464d7fba67e25274a51b91c54579 commit a92b7636ee62464d7fba67e25274a51b91c54579 Author: Gabriel Charette <gab@chromium.org> Date: Tue May 01 19:20:32 2018 [MessageLoop] Fix random IWYU preventing message_loop.h cleanup Precursor for https://chromium-review.googlesource.com/c/chromium/src/+/1035788 TBR=fdoray@chromium.org Bug: 825327 Change-Id: Ic6e7440c152dde11b6cab9c1ccddd46106d48d8b Reviewed-on: https://chromium-review.googlesource.com/1037634 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555135} [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/chrome/browser/sessions/session_service_test_helper.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/chrome/test/chromedriver/net/url_request_context_getter.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/content/browser/browsing_data/conditional_cache_deletion_helper.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/content/renderer/media/stream/media_stream_video_source.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/content/renderer/media/stream/mock_media_stream_video_source.cc [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/jingle/glue/thread_wrapper.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/media/base/fake_text_track_stream.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/ppapi/thunk/enter.cc [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/remoting/host/resizing_host_observer.cc [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/ui/aura/test/window_event_dispatcher_test_api.cc [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/ui/aura/window_event_dispatcher.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/ui/aura/window_tree_host.h [modify] https://crrev.com/a92b7636ee62464d7fba67e25274a51b91c54579/ui/events/gestures/gesture_recognizer_impl.cc
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/629ba73c96e4d8903ab360a7c14ff314851b584b commit 629ba73c96e4d8903ab360a7c14ff314851b584b Author: Gabriel Charette <gab@chromium.org> Date: Tue May 01 22:53:54 2018 [MessageLoop] Fix message_loop.h includes Removing 622 unnecessary includes and adding 14 missing includes. Script used @ https://crbug.com/825327#c155 (tweaked from https://crbug.com/825327#c151) R=fdoray@chromium.org TBR=jam@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I943b9cd10d3c4ee7fb096c648a618a9a7032684c Reviewed-on: https://chromium-review.googlesource.com/1035788 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#555209} [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/android_webview/browser/find_helper.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/android_webview/browser/net/input_stream_reader.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/android_webview/renderer/aw_content_renderer_client.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/ash/message_center/message_center_view.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/ash/shelf/shelf_view_test_api.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/ash/shell/content/client/shell_browser_main_parts.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/ash/test/ash_test_base.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/files/file_proxy_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/files/file_util_proxy_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/files/important_file_writer_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/message_loop/message_pump_android.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/message_loop/message_pump_io_ios_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/message_loop/message_pump_perftest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/message_loop/message_pump_win.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/pending_task.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/process/launch_win.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/run_loop.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/sequence_checker_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/system_monitor/system_monitor.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/task/cancelable_task_tracker_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/task_scheduler/task_scheduler_impl.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/test/scoped_mock_time_message_loop_task_runner.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/tools_sanity_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/base/win/wrapped_window_proc_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/cc/raster/raster_buffer_provider_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/cc/scheduler/scheduler_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/cc/test/run_all_perftests.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/app/chrome_main_delegate.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/android/data_usage/data_use_tab_model_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/apps/app_window_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/autofill/autofill_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/autofill/autofill_server_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/autofill/autofill_uitest_util.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/background/background_application_list_model_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browser_about_handler_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browser_keyevents_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browsing_data/browsing_data_cache_storage_helper_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browsing_data/browsing_data_indexed_db_helper_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/browsing_data/counters/browsing_data_counter_utils_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/captive_portal/captive_portal_service.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chrome_content_browser_client_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/attestation/platform_verification_flow.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/boot_times_recorder.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/customization/customization_document_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/file_manager/file_watcher_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/first_run/drive_first_run_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/input_method/textinput_test_helper.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/lock/screen_locker_tester.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/oobe_localization_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/screens/network_screen_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/screens/update_screen_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/signin/device_id_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/signin/oauth2_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/mobile/mobile_activator.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/policy/device_local_account_policy_service.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/policy/dm_token_storage_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/power/extension_event_observer_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/power/renderer_freezer.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/power/renderer_freezer_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/settings/device_settings_test_helper.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/settings/device_settings_test_helper.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/settings/session_manager_operation.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/system/automatic_reboot_manager.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/system_logs/device_event_log_source.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/chromeos/tether/tether_service_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/content_settings/content_settings_default_provider_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/content_settings/content_settings_policy_provider_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/devtools/device/port_forwarding_controller.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/devtools/device/usb/android_usb_socket.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/download/download_item_model_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/download/notification/download_notification_interactive_uitest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/active_tab_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/activity_log/activity_log_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/image_writer_private/image_writer_private_apitest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/image_writer_private/test_utils.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/notifications/notifications_apitest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/tabs/tabs_test.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/crx_installer_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/error_console/error_console_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/extension_action_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/extension_storage_monitor_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/extension_uninstall_dialog.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/install_signer.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/pack_extension_job.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/startup_helper.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/test_extension_prefs.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/updater/extension_updater_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/updater/update_service_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/extensions/zipfile_installer_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/geolocation/geolocation_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/history/android/sqlite_cursor_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/history/history_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/history/history_test_utils.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/icon_loader_auralinux.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/icon_loader_chromeos.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/icon_loader_mac.mm [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/icon_loader_win.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/lifetime/application_lifetime.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/local_discovery/service_discovery_client_impl.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/media/cast_transport_host_filter_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/media_galleries/fileapi/readahead_file_stream_reader.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/metrics/thread_watcher.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/net/chrome_url_request_context_getter.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/net/dns_probe_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/net/network_connection_tracker_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/net/referrer.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/notifications/message_center_notifications_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/plugins/plugin_finder.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/plugins/plugin_info_host_impl_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/policy/cloud/device_management_service_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/prefs/proxy_policy_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/previews/previews_service_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/printing/print_view_manager_base.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/process_singleton_posix.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/profiles/profile_downloader.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/profiles/profile_list_desktop_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/profiles/profile_manager.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/profiles/profile_manager_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/profiles/profile_window_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/push_messaging/push_messaging_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/download_protection/download_feedback_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/download_protection/two_phase_uploader_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/protocol_manager_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/safe_browsing_database.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/search/iframe_source_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sessions/session_service.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sessions/session_service_test_helper.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sessions/session_service_test_helper.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sessions/session_service_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/shell_integration_linux.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/shell_integration_win.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/signin/chrome_signin_client_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/site_details_browsertest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/status_icons/status_icon_menu_model.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sync/glue/extensions_activity_monitor_unittest.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sync/profile_sync_test_util.h [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sync/test/integration/bookmarks_helper.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sync/test/integration/passwords_helper.cc [modify] https://crrev.com/629ba73c96e4d8903ab360a7c14ff314851b584b/chrome/browser/sync/test/integration/sync_test.cc [modify] https://crrev.com/629b
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/574b31d732489b963637a25707c8840d5dc3e6e4 commit 574b31d732489b963637a25707c8840d5dc3e6e4 Author: Gabriel Charette <gab@chromium.org> Date: Fri May 11 18:54:32 2018 [PRESUBMIT] Adjust MessageLoop::QuitWhenIdleClosure presubmit to encompass in-progress API move to MessageLoopCurrent R=dpranke@chromium.org Bug: 825327 Change-Id: I962ba3c652fa0ca38e69e6bf830d3846b28a3f8f Reviewed-on: https://chromium-review.googlesource.com/1055729 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557962} [modify] https://crrev.com/574b31d732489b963637a25707c8840d5dc3e6e4/PRESUBMIT.py
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/574b31d732489b963637a25707c8840d5dc3e6e4 commit 574b31d732489b963637a25707c8840d5dc3e6e4 Author: Gabriel Charette <gab@chromium.org> Date: Fri May 11 18:54:32 2018 [PRESUBMIT] Adjust MessageLoop::QuitWhenIdleClosure presubmit to encompass in-progress API move to MessageLoopCurrent R=dpranke@chromium.org Bug: 825327 Change-Id: I962ba3c652fa0ca38e69e6bf830d3846b28a3f8f Reviewed-on: https://chromium-review.googlesource.com/1055729 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557962} [modify] https://crrev.com/574b31d732489b963637a25707c8840d5dc3e6e4/PRESUBMIT.py
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/889b87cc1d7fc9ecff6154e0cc142e58f4179b02 commit 889b87cc1d7fc9ecff6154e0cc142e58f4179b02 Author: Gabriel Charette <gab@chromium.org> Date: Fri May 11 22:23:36 2018 [MessageLoopForIO] Rename variables after standardizing MessagePumpForIO::FdWatchController class name. Missed those in associated migration. Alleviates reading confusion I experienced while reviewing https://chromium-review.googlesource.com/c/chromium/src/+/695914 R=fdoray@chromium.org, scottmg@chromium.org Bug: 825327 Change-Id: I2f9befb037d7931ef4471da660c3f9eeb91e8ecd Reviewed-on: https://chromium-review.googlesource.com/1054414 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558040} [modify] https://crrev.com/889b87cc1d7fc9ecff6154e0cc142e58f4179b02/base/files/file_descriptor_watcher_posix.cc [modify] https://crrev.com/889b87cc1d7fc9ecff6154e0cc142e58f4179b02/components/crash/content/browser/crash_handler_host_linux.cc [modify] https://crrev.com/889b87cc1d7fc9ecff6154e0cc142e58f4179b02/components/crash/content/browser/crash_handler_host_linux.h
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bc8841a12af7169cfa68997bcf2793e5dffda3a commit 5bc8841a12af7169cfa68997bcf2793e5dffda3a Author: Gabriel Charette <gab@chromium.org> Date: Wed May 16 03:28:25 2018 [MessageLoopCurrent] Move QuitWhenIdleClosure to RunLoop I was about to migrate MessageLoop::QuitWhenIdleClosure() to MessageLoopCurrent::QuitWhenIdleClosure() but figured this should really just be alongside similar deprecated methods moved to RunLoop last year. This CL is a contract that I'll TBR mass migrate calls to MessageLoop::QuitWhenIdleClosure() to it after this lands (and fix includes where relevant). R=danakj@chromium.org, kylechar@chromium.org Bug: 825327 Change-Id: I3a544a3735427dfac5e57c4e266be9901fbb67ec Reviewed-on: https://chromium-review.googlesource.com/1055808 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#558956} [modify] https://crrev.com/5bc8841a12af7169cfa68997bcf2793e5dffda3a/base/run_loop.cc [modify] https://crrev.com/5bc8841a12af7169cfa68997bcf2793e5dffda3a/base/run_loop.h
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea9180109b256256802c204bb18b0381f392d21e commit ea9180109b256256802c204bb18b0381f392d21e Author: Gabriel Charette <gab@chromium.org> Date: Wed May 16 11:53:44 2018 [MessageLoop cleanup] Mass migrate away from MessageLoop::QuitWhenIdleClosure(). TBR=danakj@chromium.org, kylechar@chromium.org Bug: 825327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0d9637bd1a7ef0c7096482d0e612f67da3a8dc1d Reviewed-on: https://chromium-review.googlesource.com/1055887 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#559043} [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/base/files/file_path_watcher_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/base/message_loop/message_loop_task_runner_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/base/message_loop/message_pump_glib_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/base/observer_list_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/captive_portal/captive_portal_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/devtools/device/adb/mock_adb_server.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/devtools/device/port_forwarding_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/history/redirect_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/media/webrtc/desktop_media_list_ash_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/net/predictor_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/plugins/plugin_power_saver_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/printing/printing_layout_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/service_process/service_process_control_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/ui/browser_focus_uitest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/ui/views/keyboard_access_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/common/mac/mock_launchd.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/service/service_process.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/test/base/browser_with_test_window_test.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/test/base/interactive_test_utils_cocoa.mm [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/chrome/test/base/interactive_test_utils_views.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/autofill/core/browser/autofill_download_manager_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/dom_distiller/standalone/content_extractor_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/history/core/browser/history_querying_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/history/core/browser/history_service_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/history/core/test/history_backend_db_base_test.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/storage_monitor/storage_monitor_linux_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/sync/engine/sequenced_model_worker_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/components/timers/alarm_timer_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/browser_associated_interface_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/devtools/devtools_manager_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/oop_browsertest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/renderer_host/input/gesture_event_queue_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/browser/renderer_host/render_widget_host_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/renderer/device_sensors/device_motion_event_pump_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/shell/browser/layout_test/layout_test_browser_main.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/content/shell/browser/shell.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/device/geolocation/geolocation_provider_impl_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/google_apis/gcm/engine/connection_factory_impl_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/headless/lib/browser/headless_browser_impl.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/jingle/glue/thread_wrapper_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/media/audio/audio_input_controller_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/media/audio/audio_low_latency_input_output_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/media/audio/win/audio_low_latency_output_win_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/media/filters/ffmpeg_demuxer_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/media/renderers/renderer_impl_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/net/dns/dns_config_service_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/net/dns/host_resolver_impl_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/net/socket/client_socket_pool_base_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/net/socket/ssl_server_socket_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/net/tools/quic/synchronous_host_resolver.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/net/url_request/url_request_test_util.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/net/url_request/url_request_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/base/auto_thread_task_runner_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/base/auto_thread_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/host/daemon_process_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/host/host_change_notification_listener_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/host/win/worker_process_launcher_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/protocol/authenticator_test_base.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/protocol/channel_multiplexer_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/protocol/connection_tester.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/protocol/monitored_video_stub_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/protocol/pseudotcp_adapter_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/ui/events/gesture_detection/gesture_provider_unittest.cc [modify] https://crrev.com/ea9180109b256256802c204bb18b0381f392d21e/ui/views/widget/native_widget_mac_unittest.mm
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87f2bef7a8714f6c2337792673a93796f10e6b3a commit 87f2bef7a8714f6c2337792673a93796f10e6b3a Author: Gabriel Charette <gab@chromium.org> Date: Thu May 17 20:37:53 2018 [MessageLoop cleanup] Finish mass migration off MessageLoop::QuitWhenIdleClosure(). Adjusted script used for https://chromium-review.googlesource.com/c/chromium/src/+/1055887 to catch cases where it was used as a non-static method. TBR=danakj@chromium.org, kylechar@chromium.org Bug: 825327 Change-Id: I93325081d5f53726c2649b204df952afd2c80a0c Reviewed-on: https://chromium-review.googlesource.com/1064811 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#559662} [modify] https://crrev.com/87f2bef7a8714f6c2337792673a93796f10e6b3a/chrome/browser/app_controller_mac_browsertest.mm [modify] https://crrev.com/87f2bef7a8714f6c2337792673a93796f10e6b3a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc [modify] https://crrev.com/87f2bef7a8714f6c2337792673a93796f10e6b3a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc [modify] https://crrev.com/87f2bef7a8714f6c2337792673a93796f10e6b3a/chrome/browser/metrics/thread_watcher_unittest.cc [modify] https://crrev.com/87f2bef7a8714f6c2337792673a93796f10e6b3a/content/browser/download/download_browsertest.cc [modify] https://crrev.com/87f2bef7a8714f6c2337792673a93796f10e6b3a/content/child/child_thread_impl.cc
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f536a88e25b936a34db5800f4412603de7746404 commit f536a88e25b936a34db5800f4412603de7746404 Author: Gabriel Charette <gab@chromium.org> Date: Fri May 18 00:36:12 2018 [MessageLoop cleanup] Get rid of very last(?) caller to static QuitWhenIdleClosure() This is the ForUI equivalent of https://chromium-review.googlesource.com/c/chromium/src/+/1064811 And cleanup a few includes I missed in that previous CL. TBR=danakj@chromium.org, kylechar@chromium.org Bug: 825327 Change-Id: I0e947c9d0441101b24ee8f21c77cd24f0ec78fa1 Reviewed-on: https://chromium-review.googlesource.com/1065017 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#559753} [modify] https://crrev.com/f536a88e25b936a34db5800f4412603de7746404/chrome/browser/app_controller_mac_browsertest.mm [modify] https://crrev.com/f536a88e25b936a34db5800f4412603de7746404/chrome/browser/extensions/activity_log/counting_policy_unittest.cc [modify] https://crrev.com/f536a88e25b936a34db5800f4412603de7746404/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc [modify] https://crrev.com/f536a88e25b936a34db5800f4412603de7746404/content/browser/download/download_browsertest.cc [modify] https://crrev.com/f536a88e25b936a34db5800f4412603de7746404/content/browser/download/drag_download_file_browsertest.cc [modify] https://crrev.com/f536a88e25b936a34db5800f4412603de7746404/content/child/child_thread_impl.cc
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5110d6ba39549b71be178fb0e72b0577e9cfa716 commit 5110d6ba39549b71be178fb0e72b0577e9cfa716 Author: Gabriel Charette <gab@chromium.org> Date: Fri May 18 16:04:46 2018 [MessageLoop cleanup] Remove unused MessageLoopCurrent::QuitWhenIdleClosure method I realized @ https://chromium-review.googlesource.com/c/chromium/src/+/1055729/1/PRESUBMIT.py#416 that I should really complete the migration off MessageLoop::QuitWhenIdleClosure and then further realized it should really be coalesced with similar RunLoop helpers (already covered in presubmit by "RunLoop::QuitCurrent*"). This is the last CL to make that so. R=danakj@chromium.org, dpranke@chromium.org, kylechar@chromium.org Bug: 825327 Change-Id: Id0fa7ca441b60e90b4ebadfa7fc705690a4aecba Reviewed-on: https://chromium-review.googlesource.com/1055891 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#559914} [modify] https://crrev.com/5110d6ba39549b71be178fb0e72b0577e9cfa716/PRESUBMIT.py [modify] https://crrev.com/5110d6ba39549b71be178fb0e72b0577e9cfa716/base/message_loop/message_loop_current.cc [modify] https://crrev.com/5110d6ba39549b71be178fb0e72b0577e9cfa716/base/message_loop/message_loop_current.h
,
Aug 23
Showing comments 67 - 166
of 166
Older ›
|
||
►
Sign in to add a comment |
||
