New issue
Advanced search Search tips

Issue 825313 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug



Sign in to add a comment

[Remoting Mobile] protocol::PerfTracker rate accessors should be const methods

Project Member Reported by yuweih@chromium.org, Mar 23 2018

Issue description

Currently they are not const because RateCounters evicts old samples when calling RateCounter::Rate(). This is unimportant detail to the PerfTracker so we could just mark these RateCounters mutable to allow Rate() to be called in const methods.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16cddbea1a32052045101a2f1858114368125066

commit 16cddbea1a32052045101a2f1858114368125066
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Mar 27 00:47:04 2018

[Remoting Mobile] Allow protocol::PerfTracker's rate accessors to be const methods

Currently we need to pass a raw pointer of PerfTracker to ClientTelemetryLogger
because its rate accessors are not const, that's because RateCounter::Rate()
evicts obsolete data points. Given that evicting obsolete data points doesn't
quite change the stats result, we can simply const_cast the eviction logic.

This CL also changes the VLOG level of the perf stats to 0 to allow them to be
printed to the console.

Bug:  825313 
Change-Id: Idf8a9c5dd5190566b75a4b60720cd605be774329
Reviewed-on: https://chromium-review.googlesource.com/978662
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545910}
[modify] https://crrev.com/16cddbea1a32052045101a2f1858114368125066/remoting/base/rate_counter.cc
[modify] https://crrev.com/16cddbea1a32052045101a2f1858114368125066/remoting/base/rate_counter.h
[modify] https://crrev.com/16cddbea1a32052045101a2f1858114368125066/remoting/client/chromoting_session.cc
[modify] https://crrev.com/16cddbea1a32052045101a2f1858114368125066/remoting/client/client_telemetry_logger.cc
[modify] https://crrev.com/16cddbea1a32052045101a2f1858114368125066/remoting/client/client_telemetry_logger.h
[modify] https://crrev.com/16cddbea1a32052045101a2f1858114368125066/remoting/client/client_telemetry_logger_unittest.cc
[modify] https://crrev.com/16cddbea1a32052045101a2f1858114368125066/remoting/protocol/performance_tracker.h

Comment 2 by yuweih@chromium.org, Mar 28 2018

Status: Fixed (was: Assigned)

Sign in to add a comment