usb : print bcdDevice string to kernel dmesg |
||||||||||
Issue descriptionI'd be really useful to print the bcdDevice string (device release number) since some accessories we are working with have evolving firmware versions, and we'd like to get this logged clearly in our feedback reports, which captures /var/log/messages.
,
Mar 23 2018
,
Mar 24 2018
,
Mar 25 2018
Landed in greg's usb-testing. Cherry-picked here for v4.14: https://chromium-review.googlesource.com/979609
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1c0595db0aa2212e67a8a5a4677d1c3d61961bf8 commit 1c0595db0aa2212e67a8a5a4677d1c3d61961bf8 Author: Benson Leung <bleung@chromium.org> Date: Mon Mar 26 18:03:33 2018 FROMGIT: USB: announce bcdDevice as well as idVendor, idProduct. Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 73c6d3b284cf7b31c03fdaa2476f48f8da0932f8 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git branch usb-testing) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:825307 TEST=check that the "bcdDevice=" value appears on USB enumeration and that it reflects the same value for same device as lsusb -v. Change-Id: I8e79f1f2af6b49f568b3c0f46bb54dba7722f8af Reviewed-on: https://chromium-review.googlesource.com/979609 Commit-Ready: Benson Leung <bleung@google.com> Tested-by: Benson Leung <bleung@google.com> Reviewed-by: Grant Grundler <grundler@chromium.org> [modify] https://crrev.com/1c0595db0aa2212e67a8a5a4677d1c3d61961bf8/drivers/usb/core/hub.c
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/02be2d585fded270a4e7f86b622f9ff42866ae86 commit 02be2d585fded270a4e7f86b622f9ff42866ae86 Author: Benson Leung <bleung@chromium.org> Date: Thu Mar 29 09:54:51 2018 FROMGIT: USB: announce bcdDevice as well as idVendor, idProduct. Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 73c6d3b284cf7b31c03fdaa2476f48f8da0932f8 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git branch usb-testing) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:825307 TEST=check that the "bcdDevice=" value appears on USB enumeration and that it reflects the same value for same device as lsusb -v. Change-Id: I8e79f1f2af6b49f568b3c0f46bb54dba7722f8af Reviewed-on: https://chromium-review.googlesource.com/980659 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> [modify] https://crrev.com/02be2d585fded270a4e7f86b622f9ff42866ae86/drivers/usb/core/hub.c
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b6c42bcaf3039063bf9ba987ecaf85291f1f2c85 commit b6c42bcaf3039063bf9ba987ecaf85291f1f2c85 Author: Benson Leung <bleung@chromium.org> Date: Thu Mar 29 09:54:58 2018 FROMGIT: USB: announce bcdDevice as well as idVendor, idProduct. Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 73c6d3b284cf7b31c03fdaa2476f48f8da0932f8 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git branch usb-testing) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:825307 TEST=check that the "bcdDevice=" value appears on USB enumeration and that it reflects the same value for same device as lsusb -v. Change-Id: I8e79f1f2af6b49f568b3c0f46bb54dba7722f8af Reviewed-on: https://chromium-review.googlesource.com/980657 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> [modify] https://crrev.com/b6c42bcaf3039063bf9ba987ecaf85291f1f2c85/drivers/usb/core/hub.c
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/693fde3b6f30cd16b8f35b2a06fabc309c420388 commit 693fde3b6f30cd16b8f35b2a06fabc309c420388 Author: Benson Leung <bleung@chromium.org> Date: Thu Mar 29 09:54:53 2018 FROMGIT: USB: announce bcdDevice as well as idVendor, idProduct. Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 73c6d3b284cf7b31c03fdaa2476f48f8da0932f8 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git branch usb-testing) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:825307 TEST=check that the "bcdDevice=" value appears on USB enumeration and that it reflects the same value for same device as lsusb -v. Change-Id: I8e79f1f2af6b49f568b3c0f46bb54dba7722f8af Reviewed-on: https://chromium-review.googlesource.com/980658 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> [modify] https://crrev.com/693fde3b6f30cd16b8f35b2a06fabc309c420388/drivers/usb/core/hub.c
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8744efa719fee562bc28c931473375b2b1602703 commit 8744efa719fee562bc28c931473375b2b1602703 Author: Benson Leung <bleung@chromium.org> Date: Thu Mar 29 20:32:57 2018 FROMGIT: USB: announce bcdDevice as well as idVendor, idProduct. Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 73c6d3b284cf7b31c03fdaa2476f48f8da0932f8 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git branch usb-testing) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:825307 TEST=check that the "bcdDevice=" value appears on USB enumeration and that it reflects the same value for same device as lsusb -v. Change-Id: I8e79f1f2af6b49f568b3c0f46bb54dba7722f8af Reviewed-on: https://chromium-review.googlesource.com/980656 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> [modify] https://crrev.com/8744efa719fee562bc28c931473375b2b1602703/drivers/usb/core/hub.c
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ab7e30cfa61c9de8674dfb9bbdd99589e943cf3a commit ab7e30cfa61c9de8674dfb9bbdd99589e943cf3a Author: Benson Leung <bleung@chromium.org> Date: Thu Mar 29 20:33:05 2018 FROMGIT: USB: announce bcdDevice as well as idVendor, idProduct. Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (cherry picked from commit 73c6d3b284cf7b31c03fdaa2476f48f8da0932f8 git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git branch usb-testing) Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:825307 TEST=check that the "bcdDevice=" value appears on USB enumeration and that it reflects the same value for same device as lsusb -v. Change-Id: I8e79f1f2af6b49f568b3c0f46bb54dba7722f8af Reviewed-on: https://chromium-review.googlesource.com/980655 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> [modify] https://crrev.com/ab7e30cfa61c9de8674dfb9bbdd99589e943cf3a/drivers/usb/core/hub.c
,
Mar 29 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bleung@chromium.org
, Mar 23 2018